All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
@ 2021-12-27 10:46 Lukasz Majewski
  2021-12-27 10:46 ` [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name Lukasz Majewski
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Lukasz Majewski @ 2021-12-27 10:46 UTC (permalink / raw)
  To: u-boot, Stefano Babic, Tom Rini
  Cc: Lukasz Majewski, Fabio Estevam, NXP i.MX U-Boot Team

Now the dts information corresponds to the one available in the kernel.
With this patch applied the 'mtd list' shows proper names and
offsets for MTD partitions.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

(no changes since v1)

 arch/arm/dts/imx28-xea.dts | 55 +++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 21 deletions(-)

diff --git a/arch/arm/dts/imx28-xea.dts b/arch/arm/dts/imx28-xea.dts
index de049042f8..34af6cf67f 100644
--- a/arch/arm/dts/imx28-xea.dts
+++ b/arch/arm/dts/imx28-xea.dts
@@ -86,27 +86,40 @@
 		spi-max-frequency = <40000000>;
 		reg = <0>;
 
-		partition@0 {
-			label = "SPL (spi)";
-			reg = <0x0 0x10000>;
-			read-only;
-		};
-		partition@1 {
-			label = "u-boot (spi)";
-			reg = <0x10000 0x70000>;
-			read-only;
-		};
-		partition@2 {
-			label = "uboot-env (spi)";
-			reg = <0x80000 0x20000>;
-		};
-		partition@3 {
-			label = "kernel (spi)";
-			reg = <0x100000 0x400000>;
-		};
-		partition@4 {
-			label = "swupdate (spi)";
-			reg = <0x50000 0x800000>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			partition@0 {
+				    label = "SPL";
+				    reg = <0x0 0x10000>;
+				    read-only;
+			};
+			partition@10000 {
+				    label = "u-boot";
+				    reg = <0x10000 0x70000>;
+				    read-only;
+			};
+			partition@80000 {
+				    label = "uboot-env1";
+				    reg = <0x80000 0x10000>;
+			};
+			partition@90000 {
+				    label = "uboot-env2";
+				    reg = <0x90000 0x10000>;
+			};
+			partition@A0000 {
+				    label = "rescue";
+				    reg = <0xA0000 0xF40000>;
+			};
+			partition@FE0000 {
+				    label = "spl-boot-data1";
+				    reg = <0xFE0000 0x10000>;
+			};
+			partition@FF0000 {
+				    label = "spl-boot-data2";
+				    reg = <0xFF0000 0x10000>;
+			};
 		};
 	};
 };
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name
  2021-12-27 10:46 [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Lukasz Majewski
@ 2021-12-27 10:46 ` Lukasz Majewski
  2022-02-19 13:07   ` sbabic
  2021-12-27 10:46 ` [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot Lukasz Majewski
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Lukasz Majewski @ 2021-12-27 10:46 UTC (permalink / raw)
  To: u-boot, Stefano Babic, Tom Rini; +Cc: Lukasz Majewski

After this change it would be possible to use 'mtd' command to get access
to XEA's SPI-NOR partitions by name (e.g. SPL), not by offsets.

To enable this feature the CONFIG_SPI_FLASH_MTD needs to be defined in the
Kconfig, not in xea.h.

=> mtd list
=> mtd read spl-boot-data1 ${loadaddr} 0x0 4
=> md.l ${loadaddr} 1

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

(no changes since v1)

 configs/imx28_xea_defconfig | 4 ++--
 include/configs/xea.h       | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/configs/imx28_xea_defconfig b/configs/imx28_xea_defconfig
index 63ab8349cd..5566945183 100644
--- a/configs/imx28_xea_defconfig
+++ b/configs/imx28_xea_defconfig
@@ -60,8 +60,6 @@ CONFIG_CMD_REGULATOR=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_MTDPARTS=y
-CONFIG_MTDIDS_DEFAULT="nor0=spi3.0"
-CONFIG_MTDPARTS_DEFAULT="spi3.0:64k(SPL),448k(uboot),128k(envs),384k(unused1),4096k(kernel),8192k(swupdate),-(unused2)"
 CONFIG_DOS_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
@@ -87,6 +85,7 @@ CONFIG_MXS_GPIO=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_MXS=y
 CONFIG_MTD=y
+CONFIG_DM_MTD=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SF_DEFAULT_BUS=3
 CONFIG_SF_DEFAULT_MODE=0x0
@@ -96,6 +95,7 @@ CONFIG_SPI_FLASH_ISSI=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
+CONFIG_SPI_FLASH_MTD=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ADDR_ENABLE=y
 CONFIG_PHY_ADDR=1
diff --git a/include/configs/xea.h b/include/configs/xea.h
index 5081cc8691..c3f25b5aa1 100644
--- a/include/configs/xea.h
+++ b/include/configs/xea.h
@@ -29,10 +29,6 @@
 #define CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS	(SZ_32K / 0x200)
 #define CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR	(SZ_1M / 0x200)
 
-#ifndef CONFIG_SPL_BUILD
-#define CONFIG_SPI_FLASH_MTD
-#endif
-
 /* Memory configuration */
 #define PHYS_SDRAM_1			0x40000000	/* Base address */
 #define PHYS_SDRAM_1_SIZE		0x10000000	/* Max 256 MB RAM */
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot
  2021-12-27 10:46 [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Lukasz Majewski
  2021-12-27 10:46 ` [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name Lukasz Majewski
@ 2021-12-27 10:46 ` Lukasz Majewski
  2022-02-05 11:29   ` Stefano Babic
  2022-02-05 16:43   ` sbabic
  2021-12-27 10:46 ` [PATCH v2 4/4] arm: dts: Enable support for USB on XEA (imx28) board Lukasz Majewski
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 14+ messages in thread
From: Lukasz Majewski @ 2021-12-27 10:46 UTC (permalink / raw)
  To: u-boot, Stefano Babic, Tom Rini
  Cc: Lukasz Majewski, Jaehoon Chung, Rick Chen, Simon Glass

The new configs/imx28_xea_sb_defconfig is introduced to facilitate
building the single binary u-boot.sb fox XEA board.

The biggest distinction from "normal" XEA imx28_xea_sb_defconfig is
support for USB mass storage devices (pen drives).

To achieve that, the CONFIG_DM_USB is enabled and supported.

Signed-off-by: Lukasz Majewski <lukma@denx.de>

---

Changes in v2:
- Add support for using 'mtd' command with SPI-NOR partitions

 configs/imx28_xea_sb_defconfig | 112 +++++++++++++++++++++++++++++++++
 1 file changed, 112 insertions(+)
 create mode 100644 configs/imx28_xea_sb_defconfig

diff --git a/configs/imx28_xea_sb_defconfig b/configs/imx28_xea_sb_defconfig
new file mode 100644
index 0000000000..8dadae30f0
--- /dev/null
+++ b/configs/imx28_xea_sb_defconfig
@@ -0,0 +1,112 @@
+CONFIG_ARM=y
+CONFIG_SPL_SYS_THUMB_BUILD=y
+CONFIG_ARCH_MX28=y
+CONFIG_SYS_TEXT_BASE=0x40002000
+CONFIG_SYS_MALLOC_F_LEN=0x800
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_DM_GPIO=y
+CONFIG_SPL_DM_SPI=y
+CONFIG_DEFAULT_DEVICE_TREE="imx28-xea"
+CONFIG_SPL_TEXT_BASE=0x1000
+CONFIG_TARGET_XEA=y
+CONFIG_SPL_SYS_MALLOC_F_LEN=0x1000
+CONFIG_SPL=y
+CONFIG_ENV_OFFSET_REDUND=0x90000
+CONFIG_SPL_PAYLOAD="u-boot.img"
+CONFIG_SYS_LOAD_ADDR=0x42000000
+CONFIG_FIT=y
+CONFIG_OF_BOARD_SETUP=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="console=ttyAMA0,115200n8"
+CONFIG_USE_PREBOOT=y
+CONFIG_PREBOOT="run prebootcmd"
+CONFIG_BOARD_EARLY_INIT_F=y
+# CONFIG_SPL_FRAMEWORK is not set
+CONFIG_SPL_BOARD_INIT=y
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
+CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
+CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0
+CONFIG_SUPPORT_EMMC_BOOT_OVERRIDE_PART_CONFIG=y
+CONFIG_SPL_DMA=y
+CONFIG_SPL_DM_SPI_FLASH=y
+CONFIG_SPL_OS_BOOT=y
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_SPL=y
+CONFIG_CMD_ASKENV=y
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_DM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_MTD=y
+# CONFIG_CMD_PINMUX is not set
+CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_OF_CONTROL=y
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent interrupts"
+CONFIG_SPL_OF_PLATDATA=y
+# CONFIG_SPL_OF_PLATDATA_PARENT is not set
+CONFIG_ENV_OVERWRITE=y
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_USE_ENV_SPI_BUS=y
+CONFIG_ENV_SPI_BUS=3
+CONFIG_USE_ENV_SPI_CS=y
+CONFIG_ENV_SPI_CS=0
+CONFIG_USE_ENV_SPI_MAX_HZ=y
+CONFIG_ENV_SPI_MAX_HZ=40000000
+CONFIG_USE_ENV_SPI_MODE=y
+CONFIG_ENV_SPI_MODE=0x0
+CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_DM=y
+CONFIG_SPL_DM=y
+CONFIG_DEVRES=y
+# CONFIG_SPL_BLK is not set
+CONFIG_MXS_GPIO=y
+CONFIG_SUPPORT_EMMC_BOOT=y
+CONFIG_MMC_MXS=y
+CONFIG_MTD=y
+CONFIG_DM_MTD=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SF_DEFAULT_BUS=3
+CONFIG_SF_DEFAULT_MODE=0x0
+CONFIG_SF_DEFAULT_SPEED=40000000
+CONFIG_SPI_FLASH_SFDP_SUPPORT=y
+CONFIG_SPI_FLASH_ISSI=y
+CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_STMICRO=y
+# CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
+CONFIG_SPI_FLASH_MTD=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_ADDR_ENABLE=y
+CONFIG_PHY_ADDR=1
+CONFIG_PHY_FIXED=y
+CONFIG_DM_ETH=y
+CONFIG_FEC_MXC=y
+CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_MXS=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_CONS_INDEX=0
+CONFIG_SPI=y
+CONFIG_DM_SPI=y
+CONFIG_MXS_SPI=y
+CONFIG_USB=y
+# CONFIG_SPL_DM_USB is not set
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_STORAGE=y
+CONFIG_FS_FAT=y
+# CONFIG_SPL_OF_LIBFDT is not set
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 4/4] arm: dts: Enable support for USB on XEA (imx28) board
  2021-12-27 10:46 [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Lukasz Majewski
  2021-12-27 10:46 ` [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name Lukasz Majewski
  2021-12-27 10:46 ` [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot Lukasz Majewski
@ 2021-12-27 10:46 ` Lukasz Majewski
  2022-02-05 16:40   ` sbabic
  2021-12-27 12:43 ` [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Tom Rini
  2022-02-05 16:44 ` sbabic
  4 siblings, 1 reply; 14+ messages in thread
From: Lukasz Majewski @ 2021-12-27 10:46 UTC (permalink / raw)
  To: u-boot, Stefano Babic, Tom Rini
  Cc: Lukasz Majewski, Fabio Estevam, NXP i.MX U-Boot Team

This change enables the support for USB with DM on the XEA (imx28)
board.

Signed-off-by: Lukasz Majewski <lukma@denx.de>

---

(no changes since v1)

 arch/arm/dts/imx28-xea.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/dts/imx28-xea.dts b/arch/arm/dts/imx28-xea.dts
index 34af6cf67f..f4b503cf65 100644
--- a/arch/arm/dts/imx28-xea.dts
+++ b/arch/arm/dts/imx28-xea.dts
@@ -41,6 +41,15 @@
 		enable-active-high;
 		regulator-boot-on;
 	};
+
+	reg_usb_5v: regulator-usb-5v {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };
 
 &mac0 {
@@ -123,3 +132,12 @@
 		};
 	};
 };
+
+&usb0 {
+	vbus-supply = <&reg_usb_5v>;
+	status = "okay";
+};
+
+&usbphy0 {
+	status = "okay";
+};
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
  2021-12-27 10:46 [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Lukasz Majewski
                   ` (2 preceding siblings ...)
  2021-12-27 10:46 ` [PATCH v2 4/4] arm: dts: Enable support for USB on XEA (imx28) board Lukasz Majewski
@ 2021-12-27 12:43 ` Tom Rini
  2021-12-27 13:20   ` Lukasz Majewski
  2022-02-05 16:44 ` sbabic
  4 siblings, 1 reply; 14+ messages in thread
From: Tom Rini @ 2021-12-27 12:43 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: u-boot, Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:

> Now the dts information corresponds to the one available in the kernel.
> With this patch applied the 'mtd list' shows proper names and
> offsets for MTD partitions.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

And this has been submitted upstream, yes?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
  2021-12-27 12:43 ` [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Tom Rini
@ 2021-12-27 13:20   ` Lukasz Majewski
  2021-12-27 13:21     ` Tom Rini
  0 siblings, 1 reply; 14+ messages in thread
From: Lukasz Majewski @ 2021-12-27 13:20 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot, Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Hi Tom,

> On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> 
> > Now the dts information corresponds to the one available in the
> > kernel. With this patch applied the 'mtd list' shows proper names
> > and offsets for MTD partitions.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> 
> And this has been submitted upstream, yes?
> 

The code has been modified to support the 'mtd' command and setting
partition info from DTS.

Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
  2021-12-27 13:20   ` Lukasz Majewski
@ 2021-12-27 13:21     ` Tom Rini
  2021-12-27 14:59       ` Lukasz Majewski
  0 siblings, 1 reply; 14+ messages in thread
From: Tom Rini @ 2021-12-27 13:21 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: u-boot, Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

On Mon, Dec 27, 2021 at 02:20:04PM +0100, Lukasz Majewski wrote:
> Hi Tom,
> 
> > On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> > 
> > > Now the dts information corresponds to the one available in the
> > > kernel. With this patch applied the 'mtd list' shows proper names
> > > and offsets for MTD partitions.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> > 
> > And this has been submitted upstream, yes?
> > 
> 
> The code has been modified to support the 'mtd' command and setting
> partition info from DTS.
> 
> Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.

Right.  And have you updated / are you updating the upstream dts file?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
  2021-12-27 13:21     ` Tom Rini
@ 2021-12-27 14:59       ` Lukasz Majewski
  2021-12-27 15:00         ` Tom Rini
  0 siblings, 1 reply; 14+ messages in thread
From: Lukasz Majewski @ 2021-12-27 14:59 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot, Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi Tom,

> On Mon, Dec 27, 2021 at 02:20:04PM +0100, Lukasz Majewski wrote:
> > Hi Tom,
> >   
> > > On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> > >   
> > > > Now the dts information corresponds to the one available in the
> > > > kernel. With this patch applied the 'mtd list' shows proper
> > > > names and offsets for MTD partitions.
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>    
> > > 
> > > And this has been submitted upstream, yes?
> > >   
> > 
> > The code has been modified to support the 'mtd' command and setting
> > partition info from DTS.
> > 
> > Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.
> >  
> 
> Right.  And have you updated / are you updating the upstream dts file?
> 

Yes, I do update the u-boot DTS upstream file.

(And this corresponds to the SPI-NOR layout that we do have in the
kernel upstream DTS code).


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
  2021-12-27 14:59       ` Lukasz Majewski
@ 2021-12-27 15:00         ` Tom Rini
  0 siblings, 0 replies; 14+ messages in thread
From: Tom Rini @ 2021-12-27 15:00 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: u-boot, Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

On Mon, Dec 27, 2021 at 03:59:28PM +0100, Lukasz Majewski wrote:
> Hi Tom,
> 
> > On Mon, Dec 27, 2021 at 02:20:04PM +0100, Lukasz Majewski wrote:
> > > Hi Tom,
> > >   
> > > > On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> > > >   
> > > > > Now the dts information corresponds to the one available in the
> > > > > kernel. With this patch applied the 'mtd list' shows proper
> > > > > names and offsets for MTD partitions.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>    
> > > > 
> > > > And this has been submitted upstream, yes?
> > > >   
> > > 
> > > The code has been modified to support the 'mtd' command and setting
> > > partition info from DTS.
> > > 
> > > Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.
> > >  
> > 
> > Right.  And have you updated / are you updating the upstream dts file?
> > 
> 
> Yes, I do update the u-boot DTS upstream file.
> 
> (And this corresponds to the SPI-NOR layout that we do have in the
> kernel upstream DTS code).

OK, thanks.  In the future please note what kernel release you're
re-syncing this from.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot
  2021-12-27 10:46 ` [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot Lukasz Majewski
@ 2022-02-05 11:29   ` Stefano Babic
  2022-02-05 16:43   ` sbabic
  1 sibling, 0 replies; 14+ messages in thread
From: Stefano Babic @ 2022-02-05 11:29 UTC (permalink / raw)
  To: Lukasz Majewski, u-boot, Stefano Babic, Tom Rini
  Cc: Jaehoon Chung, Rick Chen, Simon Glass

Hi Lukasz,

I added myself the file to xea/MAINTAINERS.

Regards,
Stefano

On 27.12.21 11:46, Lukasz Majewski wrote:
> The new configs/imx28_xea_sb_defconfig is introduced to facilitate
> building the single binary u-boot.sb fox XEA board.
> 
> The biggest distinction from "normal" XEA imx28_xea_sb_defconfig is
> support for USB mass storage devices (pen drives).
> 
> To achieve that, the CONFIG_DM_USB is enabled and supported.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> 
> ---
> 
> Changes in v2:
> - Add support for using 'mtd' command with SPI-NOR partitions
> 
>   configs/imx28_xea_sb_defconfig | 112 +++++++++++++++++++++++++++++++++
>   1 file changed, 112 insertions(+)
>   create mode 100644 configs/imx28_xea_sb_defconfig
> 
> diff --git a/configs/imx28_xea_sb_defconfig b/configs/imx28_xea_sb_defconfig
> new file mode 100644
> index 0000000000..8dadae30f0
> --- /dev/null
> +++ b/configs/imx28_xea_sb_defconfig
> @@ -0,0 +1,112 @@
> +CONFIG_ARM=y
> +CONFIG_SPL_SYS_THUMB_BUILD=y
> +CONFIG_ARCH_MX28=y
> +CONFIG_SYS_TEXT_BASE=0x40002000
> +CONFIG_SYS_MALLOC_F_LEN=0x800
> +CONFIG_SPL_LIBCOMMON_SUPPORT=y
> +CONFIG_SPL_LIBGENERIC_SUPPORT=y
> +CONFIG_NR_DRAM_BANKS=1
> +CONFIG_DM_GPIO=y
> +CONFIG_SPL_DM_SPI=y
> +CONFIG_DEFAULT_DEVICE_TREE="imx28-xea"
> +CONFIG_SPL_TEXT_BASE=0x1000
> +CONFIG_TARGET_XEA=y
> +CONFIG_SPL_SYS_MALLOC_F_LEN=0x1000
> +CONFIG_SPL=y
> +CONFIG_ENV_OFFSET_REDUND=0x90000
> +CONFIG_SPL_PAYLOAD="u-boot.img"
> +CONFIG_SYS_LOAD_ADDR=0x42000000
> +CONFIG_FIT=y
> +CONFIG_OF_BOARD_SETUP=y
> +CONFIG_USE_BOOTARGS=y
> +CONFIG_BOOTARGS="console=ttyAMA0,115200n8"
> +CONFIG_USE_PREBOOT=y
> +CONFIG_PREBOOT="run prebootcmd"
> +CONFIG_BOARD_EARLY_INIT_F=y
> +# CONFIG_SPL_FRAMEWORK is not set
> +CONFIG_SPL_BOARD_INIT=y
> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
> +CONFIG_SPL_SYS_MALLOC_SIMPLE=y
> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
> +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0
> +CONFIG_SUPPORT_EMMC_BOOT_OVERRIDE_PART_CONFIG=y
> +CONFIG_SPL_DMA=y
> +CONFIG_SPL_DM_SPI_FLASH=y
> +CONFIG_SPL_OS_BOOT=y
> +CONFIG_HUSH_PARSER=y
> +CONFIG_CMD_SPL=y
> +CONFIG_CMD_ASKENV=y
> +CONFIG_CMD_GREPENV=y
> +CONFIG_CMD_DM=y
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_MTD=y
> +# CONFIG_CMD_PINMUX is not set
> +CONFIG_CMD_SPI=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_CACHE=y
> +CONFIG_CMD_REGULATOR=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_FS_GENERIC=y
> +CONFIG_CMD_MTDPARTS=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_SPL_OF_CONTROL=y
> +CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent interrupts"
> +CONFIG_SPL_OF_PLATDATA=y
> +# CONFIG_SPL_OF_PLATDATA_PARENT is not set
> +CONFIG_ENV_OVERWRITE=y
> +CONFIG_ENV_IS_IN_SPI_FLASH=y
> +CONFIG_USE_ENV_SPI_BUS=y
> +CONFIG_ENV_SPI_BUS=3
> +CONFIG_USE_ENV_SPI_CS=y
> +CONFIG_ENV_SPI_CS=0
> +CONFIG_USE_ENV_SPI_MAX_HZ=y
> +CONFIG_ENV_SPI_MAX_HZ=40000000
> +CONFIG_USE_ENV_SPI_MODE=y
> +CONFIG_ENV_SPI_MODE=0x0
> +CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> +CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_DM=y
> +CONFIG_SPL_DM=y
> +CONFIG_DEVRES=y
> +# CONFIG_SPL_BLK is not set
> +CONFIG_MXS_GPIO=y
> +CONFIG_SUPPORT_EMMC_BOOT=y
> +CONFIG_MMC_MXS=y
> +CONFIG_MTD=y
> +CONFIG_DM_MTD=y
> +CONFIG_DM_SPI_FLASH=y
> +CONFIG_SF_DEFAULT_BUS=3
> +CONFIG_SF_DEFAULT_MODE=0x0
> +CONFIG_SF_DEFAULT_SPEED=40000000
> +CONFIG_SPI_FLASH_SFDP_SUPPORT=y
> +CONFIG_SPI_FLASH_ISSI=y
> +CONFIG_SPI_FLASH_SPANSION=y
> +CONFIG_SPI_FLASH_STMICRO=y
> +# CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
> +CONFIG_SPI_FLASH_MTD=y
> +CONFIG_PHYLIB=y
> +CONFIG_PHY_ADDR_ENABLE=y
> +CONFIG_PHY_ADDR=1
> +CONFIG_PHY_FIXED=y
> +CONFIG_DM_ETH=y
> +CONFIG_FEC_MXC=y
> +CONFIG_MII=y
> +CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_MXS=y
> +CONFIG_DM_REGULATOR=y
> +CONFIG_DM_REGULATOR_FIXED=y
> +CONFIG_DM_REGULATOR_GPIO=y
> +CONFIG_CONS_INDEX=0
> +CONFIG_SPI=y
> +CONFIG_DM_SPI=y
> +CONFIG_MXS_SPI=y
> +CONFIG_USB=y
> +# CONFIG_SPL_DM_USB is not set
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_STORAGE=y
> +CONFIG_FS_FAT=y
> +# CONFIG_SPL_OF_LIBFDT is not set

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v2 4/4] arm: dts: Enable support for USB on XEA (imx28) board
  2021-12-27 10:46 ` [PATCH v2 4/4] arm: dts: Enable support for USB on XEA (imx28) board Lukasz Majewski
@ 2022-02-05 16:40   ` sbabic
  0 siblings, 0 replies; 14+ messages in thread
From: sbabic @ 2022-02-05 16:40 UTC (permalink / raw)
  To: Lukasz Majewski, u-boot

> This change enables the support for USB with DM on the XEA (imx28)
> board.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot
  2021-12-27 10:46 ` [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot Lukasz Majewski
  2022-02-05 11:29   ` Stefano Babic
@ 2022-02-05 16:43   ` sbabic
  1 sibling, 0 replies; 14+ messages in thread
From: sbabic @ 2022-02-05 16:43 UTC (permalink / raw)
  To: Lukasz Majewski, u-boot

> The new configs/imx28_xea_sb_defconfig is introduced to facilitate
> building the single binary u-boot.sb fox XEA board.
> The biggest distinction from "normal" XEA imx28_xea_sb_defconfig is
> support for USB mass storage devices (pen drives).
> To achieve that, the CONFIG_DM_USB is enabled and supported.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description
  2021-12-27 10:46 [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Lukasz Majewski
                   ` (3 preceding siblings ...)
  2021-12-27 12:43 ` [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Tom Rini
@ 2022-02-05 16:44 ` sbabic
  4 siblings, 0 replies; 14+ messages in thread
From: sbabic @ 2022-02-05 16:44 UTC (permalink / raw)
  To: Lukasz Majewski, u-boot

> Now the dts information corresponds to the one available in the kernel.
> With this patch applied the 'mtd list' shows proper names and
> offsets for MTD partitions.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name
  2021-12-27 10:46 ` [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name Lukasz Majewski
@ 2022-02-19 13:07   ` sbabic
  0 siblings, 0 replies; 14+ messages in thread
From: sbabic @ 2022-02-19 13:07 UTC (permalink / raw)
  To: Lukasz Majewski, u-boot

> After this change it would be possible to use 'mtd' command to get access
> to XEA's SPI-NOR partitions by name (e.g. SPL), not by offsets.
> To enable this feature the CONFIG_SPI_FLASH_MTD needs to be defined in the
> Kconfig, not in xea.h.
> => mtd list
> => mtd read spl-boot-data1 ${loadaddr} 0x0 4
> => md.l ${loadaddr} 1
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-02-19 13:08 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-27 10:46 [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Lukasz Majewski
2021-12-27 10:46 ` [PATCH v2 2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name Lukasz Majewski
2022-02-19 13:07   ` sbabic
2021-12-27 10:46 ` [PATCH v2 3/4] arm: xea: config: Provide special defconfig for a single binary u-boot Lukasz Majewski
2022-02-05 11:29   ` Stefano Babic
2022-02-05 16:43   ` sbabic
2021-12-27 10:46 ` [PATCH v2 4/4] arm: dts: Enable support for USB on XEA (imx28) board Lukasz Majewski
2022-02-05 16:40   ` sbabic
2021-12-27 12:43 ` [PATCH v2 1/4] xea: dts: Update the SPI-NOR flash memory partitions description Tom Rini
2021-12-27 13:20   ` Lukasz Majewski
2021-12-27 13:21     ` Tom Rini
2021-12-27 14:59       ` Lukasz Majewski
2021-12-27 15:00         ` Tom Rini
2022-02-05 16:44 ` sbabic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.