* [PATCH] media: atmel-isc: get rid of an unused var
@ 2017-10-31 9:37 Mauro Carvalho Chehab
2017-11-02 3:04 ` Yang, Wenyou
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2017-10-31 9:37 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab, Songjun Wu
drivers/media/platform/atmel/atmel-isc.c: In function 'isc_async_complete':
drivers/media/platform/atmel/atmel-isc.c:1900:28: warning: variable 'sd_entity' set but not used [-Wunused-but-set-variable]
struct isc_subdev_entity *sd_entity;
^~~~~~~~~
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
drivers/media/platform/atmel/atmel-isc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
index 2c40a7886542..8b37656f035d 100644
--- a/drivers/media/platform/atmel/atmel-isc.c
+++ b/drivers/media/platform/atmel/atmel-isc.c
@@ -1897,7 +1897,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)
{
struct isc_device *isc = container_of(notifier->v4l2_dev,
struct isc_device, v4l2_dev);
- struct isc_subdev_entity *sd_entity;
struct video_device *vdev = &isc->video_dev;
struct vb2_queue *q = &isc->vb2_vidq;
int ret;
@@ -1910,8 +1909,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)
isc->current_subdev = container_of(notifier,
struct isc_subdev_entity, notifier);
- sd_entity = isc->current_subdev;
-
mutex_init(&isc->lock);
init_completion(&isc->comp);
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: atmel-isc: get rid of an unused var
2017-10-31 9:37 [PATCH] media: atmel-isc: get rid of an unused var Mauro Carvalho Chehab
@ 2017-11-02 3:04 ` Yang, Wenyou
0 siblings, 0 replies; 2+ messages in thread
From: Yang, Wenyou @ 2017-11-02 3:04 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, Songjun Wu
On 2017/10/31 17:37, Mauro Carvalho Chehab wrote:
> drivers/media/platform/atmel/atmel-isc.c: In function 'isc_async_complete':
> drivers/media/platform/atmel/atmel-isc.c:1900:28: warning: variable 'sd_entity' set but not used [-Wunused-but-set-variable]
> struct isc_subdev_entity *sd_entity;
> ^~~~~~~~~
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Wenyou Yang <wenyou.yang@microchip.com>
> ---
> drivers/media/platform/atmel/atmel-isc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
> index 2c40a7886542..8b37656f035d 100644
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -1897,7 +1897,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)
> {
> struct isc_device *isc = container_of(notifier->v4l2_dev,
> struct isc_device, v4l2_dev);
> - struct isc_subdev_entity *sd_entity;
> struct video_device *vdev = &isc->video_dev;
> struct vb2_queue *q = &isc->vb2_vidq;
> int ret;
> @@ -1910,8 +1909,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)
>
> isc->current_subdev = container_of(notifier,
> struct isc_subdev_entity, notifier);
> - sd_entity = isc->current_subdev;
> -
> mutex_init(&isc->lock);
> init_completion(&isc->comp);
>
Best Regards,
Wenyou Yang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-02 3:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 9:37 [PATCH] media: atmel-isc: get rid of an unused var Mauro Carvalho Chehab
2017-11-02 3:04 ` Yang, Wenyou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.