All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd
@ 2021-02-01 19:24 Fabrice Fontaine
  2021-02-02 15:40 ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2021-02-01 19:24 UTC (permalink / raw)
  To: buildroot

Fixes:
 - https://bugs.buildroot.org/show_bug.cgi?id=13506

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/dhcpcd/dhcpcd.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index cb269f1138..81e87369ad 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -46,6 +46,7 @@ endef
 
 define DHCPCD_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
+	mkdir -p $(TARGET_DIR)/var/db/dhcpcd
 endef
 
 # When network-manager is enabled together with dhcpcd, it will use
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd
  2021-02-01 19:24 [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd Fabrice Fontaine
@ 2021-02-02 15:40 ` Peter Korsgaard
  2021-02-02 17:03   ` Fabrice Fontaine
  2021-02-02 17:40   ` Nicolas Cavallari
  0 siblings, 2 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-02-02 15:40 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - https://bugs.buildroot.org/show_bug.cgi?id=13506

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/dhcpcd/dhcpcd.mk | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
 > index cb269f1138..81e87369ad 100644
 > --- a/package/dhcpcd/dhcpcd.mk
 > +++ b/package/dhcpcd/dhcpcd.mk
 > @@ -46,6 +46,7 @@ endef
 
 >  define DHCPCD_INSTALL_TARGET_CMDS
 >  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
 > +	mkdir -p $(TARGET_DIR)/var/db/dhcpcd

What is stored here? Does it need to persist over reboots? How should a
readonly rootfs be handled? Could we perhaps make it a symlink to /run
or similar?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd
  2021-02-02 15:40 ` Peter Korsgaard
@ 2021-02-02 17:03   ` Fabrice Fontaine
  2021-02-02 17:58     ` Peter Korsgaard
  2021-02-02 17:40   ` Nicolas Cavallari
  1 sibling, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2021-02-02 17:03 UTC (permalink / raw)
  To: buildroot

Le mar. 2 f?vr. 2021 ? 16:40, Peter Korsgaard <peter@korsgaard.com> a ?crit :
>
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>
>  > Fixes:
>  >  - https://bugs.buildroot.org/show_bug.cgi?id=13506
>
>  > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>  > ---
>  >  package/dhcpcd/dhcpcd.mk | 1 +
>  >  1 file changed, 1 insertion(+)
>
>  > diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
>  > index cb269f1138..81e87369ad 100644
>  > --- a/package/dhcpcd/dhcpcd.mk
>  > +++ b/package/dhcpcd/dhcpcd.mk
>  > @@ -46,6 +46,7 @@ endef
>
>  >  define DHCPCD_INSTALL_TARGET_CMDS
>  >      $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
>  > +    mkdir -p $(TARGET_DIR)/var/db/dhcpcd
>
> What is stored here? Does it need to persist over reboots? How should a
> readonly rootfs be handled? Could we perhaps make it a symlink to /run
> or similar?
I'll set this patch as "not applicable" as dhcpcd installs back this
directory since version 9.2.0 and
https://github.com/rsmarples/dhcpcd/commit/4d695e1ca3b87b45d5e5fa5119ddcb8a086ca9a0
>
> --
> Bye, Peter Korsgaard
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd
  2021-02-02 15:40 ` Peter Korsgaard
  2021-02-02 17:03   ` Fabrice Fontaine
@ 2021-02-02 17:40   ` Nicolas Cavallari
  2021-02-02 17:59     ` Peter Korsgaard
  1 sibling, 1 reply; 6+ messages in thread
From: Nicolas Cavallari @ 2021-02-02 17:40 UTC (permalink / raw)
  To: buildroot

On 02/02/2021 16:40, Peter Korsgaard wrote:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> 
>   > Fixes:
>   >  - https://bugs.buildroot.org/show_bug.cgi?id=13506
> 
>   > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>   > ---
>   >  package/dhcpcd/dhcpcd.mk | 1 +
>   >  1 file changed, 1 insertion(+)
> 
>   > diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
>   > index cb269f1138..81e87369ad 100644
>   > --- a/package/dhcpcd/dhcpcd.mk
>   > +++ b/package/dhcpcd/dhcpcd.mk
>   > @@ -46,6 +46,7 @@ endef
>   
>   >  define DHCPCD_INSTALL_TARGET_CMDS
>   >  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
>   > +	mkdir -p $(TARGET_DIR)/var/db/dhcpcd
> 
> What is stored here? Does it need to persist over reboots? How should a
> readonly rootfs be handled? Could we perhaps make it a symlink to /run
> or similar?
> 

It stores DHCP DUID and IPv6 stable privacy secrets.  It must persist 
over reboots, or the features that need them must be disabled or 
configured not to.

Apparently, dhcpcd is smart enough to detect read only systems and plan 
accordingly, but i did not test it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd
  2021-02-02 17:03   ` Fabrice Fontaine
@ 2021-02-02 17:58     ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-02-02 17:58 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Le mar. 2 f?vr. 2021 ? 16:40, Peter Korsgaard <peter@korsgaard.com> a ?crit :
 >> 
 >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
 >> 
 >> > Fixes:
 >> >  - https://bugs.buildroot.org/show_bug.cgi?id=13506
 >> 
 >> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> > ---
 >> >  package/dhcpcd/dhcpcd.mk | 1 +
 >> >  1 file changed, 1 insertion(+)
 >> 
 >> > diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
 >> > index cb269f1138..81e87369ad 100644
 >> > --- a/package/dhcpcd/dhcpcd.mk
 >> > +++ b/package/dhcpcd/dhcpcd.mk
 >> > @@ -46,6 +46,7 @@ endef
 >> 
 >> >  define DHCPCD_INSTALL_TARGET_CMDS
 >> >      $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
 >> > +    mkdir -p $(TARGET_DIR)/var/db/dhcpcd
 >> 
 >> What is stored here? Does it need to persist over reboots? How should a
 >> readonly rootfs be handled? Could we perhaps make it a symlink to /run
 >> or similar?
 > I'll set this patch as "not applicable" as dhcpcd installs back this
 > directory since version 9.2.0 and
 > https://github.com/rsmarples/dhcpcd/commit/4d695e1ca3b87b45d5e5fa5119ddcb8a086ca9a0

Ok, so we would only need it for 2020.02.x / 2020.11.x then. I'll add it
now.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd
  2021-02-02 17:40   ` Nicolas Cavallari
@ 2021-02-02 17:59     ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-02-02 17:59 UTC (permalink / raw)
  To: buildroot

>>>>> "Nicolas" == Nicolas Cavallari <nicolas.cavallari@green-communications.fr> writes:

 >> > +	mkdir -p $(TARGET_DIR)/var/db/dhcpcd
 >> 
 >> What is stored here? Does it need to persist over reboots? How should a
 >> readonly rootfs be handled? Could we perhaps make it a symlink to /run
 >> or similar?
 >> 

 > It stores DHCP DUID and IPv6 stable privacy secrets.  It must persist
 > over reboots, or the features that need them must be disabled or
 > configured not to.

 > Apparently, dhcpcd is smart enough to detect read only systems and
 > plan accordingly, but i did not test it.

OK, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-02 17:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 19:24 [Buildroot] [PATCH 1/1] package/dhcpcd: create /var/db/dhcpcd Fabrice Fontaine
2021-02-02 15:40 ` Peter Korsgaard
2021-02-02 17:03   ` Fabrice Fontaine
2021-02-02 17:58     ` Peter Korsgaard
2021-02-02 17:40   ` Nicolas Cavallari
2021-02-02 17:59     ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.