[PATCH V2] virtio-gpio: Specify character encoding for gpio names

[PATCH V2] virtio-gpio: Specify character encoding for gpio names

[Viresh Kumar]

Specify 7-bit ASCII character encoding for GPIO names strings.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/115
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
V2:
- Use ASCII instead of UTF-8.

 virtio-gpio.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/virtio-gpio.tex b/virtio-gpio.tex
index 5da16d920aa3..3c614ec97b92 100644
--- a/virtio-gpio.tex
+++ b/virtio-gpio.tex
@@ -119,7 +119,8 @@ \subsubsection{requestq Operation: Get Line Names}\label{sec:Device Types / GPIO
 order of the GPIO line numbers. The names of the GPIO lines are optional and may
 be present only for a subset of GPIO lines. If missing, then a zero-byte must be
 present for the GPIO line. If present, the name string must be zero-terminated
-and the name must be unique within a GPIO Device.
+and the name must be unique within a GPIO Device. The names of the GPIO lines
+are encoded in 7-bit ASCII.
 
 These names of the GPIO lines should be most meaningful producer names for the
 system, such as name indicating the usage. For example "MMC-CD", "Red LED Vdd"
-- 
2.31.1.272.g89b43f80a514

Re: [PATCH V2] virtio-gpio: Specify character encoding for gpio names

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

On Thu, Aug 19, 2021 at 09:26:54AM +0530, Viresh Kumar wrote:
> Specify 7-bit ASCII character encoding for GPIO names strings.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/115
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V2:
> - Use ASCII instead of UTF-8.
> 
>  virtio-gpio.tex | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Looks good, thank you. Let's vote again.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[virtio-dev] Re: [PATCH V2] virtio-gpio: Specify character encoding for gpio names

[Cornelia Huck]

On Thu, Aug 19 2021, Viresh Kumar <viresh.kumar@linaro.org> wrote:

> Specify 7-bit ASCII character encoding for GPIO names strings.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/115
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V2:
> - Use ASCII instead of UTF-8.
>
>  virtio-gpio.tex | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org