[PATCH 1/2] can: usb: esd_usb2: Replaced stale MODULE_AUTHOR tag

[PATCH 1/2] can: usb: esd_usb2: Replaced stale MODULE_AUTHOR tag

[Stefan Mätje]

The original author of the module left our company. Replaced the email
in the MODULE_AUTHOR() macro with a valid one.

Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
---
 drivers/net/can/usb/esd_usb2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index be928ce62d32..6183b7707ad7 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -2,6 +2,7 @@
  * CAN driver for esd CAN-USB/2 and CAN-USB/Micro
  *
  * Copyright (C) 2010-2012 Matthias Fuchs <matthias.fuchs@esd.eu>, esd gmbh
+ * Copyright (C)      2017 Stefan Maetje <stefan.maetje@esd.eu>, esd gmbh
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published
@@ -26,7 +27,7 @@
 #include <linux/can/dev.h>
 #include <linux/can/error.h>

-MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
+MODULE_AUTHOR("Stefan Maetje <stefan.maetje@esd.eu>");
 MODULE_DESCRIPTION("CAN driver for esd CAN-USB/2 and CAN-USB/Micro
interfaces");
 MODULE_LICENSE("GPL v2");

-- 
2.11.0

Re: [PATCH 1/2] can: usb: esd_usb2: Replaced stale MODULE_AUTHOR tag

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1788 bytes --]

On 10/18/2017 01:25 PM, Stefan Mätje wrote:
> The original author of the module left our company. Replaced the email
> in the MODULE_AUTHOR() macro with a valid one.
> 
> Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
> ---
>  drivers/net/can/usb/esd_usb2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
> index be928ce62d32..6183b7707ad7 100644
> --- a/drivers/net/can/usb/esd_usb2.c
> +++ b/drivers/net/can/usb/esd_usb2.c
> @@ -2,6 +2,7 @@
>   * CAN driver for esd CAN-USB/2 and CAN-USB/Micro
>   *
>   * Copyright (C) 2010-2012 Matthias Fuchs <matthias.fuchs@esd.eu>, esd gmbh
> + * Copyright (C)      2017 Stefan Maetje <stefan.maetje@esd.eu>, esd gmbh

Hmmm a copyright for a one liner?

>   *
>   * This program is free software; you can redistribute it and/or modify it
>   * under the terms of the GNU General Public License as published
> @@ -26,7 +27,7 @@
>  #include <linux/can/dev.h>
>  #include <linux/can/error.h>
> 
> -MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
> +MODULE_AUTHOR("Stefan Maetje <stefan.maetje@esd.eu>");

Maybe you should create a roll email address at your company and change
Matthias Fuchs's email to something like kernel@esd.eu. Think about
adding you or that role email to the MAINTAINERS file.

>  MODULE_DESCRIPTION("CAN driver for esd CAN-USB/2 and CAN-USB/Micro
> interfaces");
>  MODULE_LICENSE("GPL v2");
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] can: usb: esd_usb2: Replaced stale MODULE_AUTHOR tag

[Stefan Mätje]

Am 18.10.2017 um 13:48 schrieb Marc Kleine-Budde:
> On 10/18/2017 01:25 PM, Stefan Mätje wrote:
>> The original author of the module left our company. Replaced the email
>> in the MODULE_AUTHOR() macro with a valid one.
>>
>> Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
>> ---
>>  drivers/net/can/usb/esd_usb2.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
>> index be928ce62d32..6183b7707ad7 100644
>> --- a/drivers/net/can/usb/esd_usb2.c
>> +++ b/drivers/net/can/usb/esd_usb2.c
>> @@ -2,6 +2,7 @@
>>   * CAN driver for esd CAN-USB/2 and CAN-USB/Micro
>>   *
>>   * Copyright (C) 2010-2012 Matthias Fuchs <matthias.fuchs@esd.eu>, esd gmbh
>> + * Copyright (C)      2017 Stefan Maetje <stefan.maetje@esd.eu>, esd gmbh
> 
> Hmmm a copyright for a one liner?

Yes, it's somewhat ridiculous but I only wanted to make it clear not to
use Matthias's address any more already at the top of the source file.

>>   *
>>   * This program is free software; you can redistribute it and/or modify it
>>   * under the terms of the GNU General Public License as published
>> @@ -26,7 +27,7 @@
>>  #include <linux/can/dev.h>
>>  #include <linux/can/error.h>
>>
>> -MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
>> +MODULE_AUTHOR("Stefan Maetje <stefan.maetje@esd.eu>");
> 
> Maybe you should create a roll email address at your company and change
> Matthias Fuchs's email to something like kernel@esd.eu. Think about
> adding you or that role email to the MAINTAINERS file.

I would suggest an email address of "linux-kernel@esd.eu" which would
result then in

MODULE_AUTHOR("<linux-kernel@esd.eu>")

Would that be ok?

On the other hand I would hesitate to add that email address to the
kernel's MAINTAINER file. Then it would stand side by side to your and
Wolfgang Grandeggers email adresses under "CAN NETWORK DRIVERS".

Or do you mean to create a new section only describing the esd driver
for the CAN-USB/2? Wouldn't that be overkill also?

>>  MODULE_DESCRIPTION("CAN driver for esd CAN-USB/2 and CAN-USB/Micro
>> interfaces");
>>  MODULE_LICENSE("GPL v2");
>>
> 
> Marc

Re: [PATCH 1/2] can: usb: esd_usb2: Replaced stale MODULE_AUTHOR tag

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 2814 bytes --]

On 10/18/2017 04:35 PM, Stefan Mätje wrote:
> Am 18.10.2017 um 13:48 schrieb Marc Kleine-Budde:
>> On 10/18/2017 01:25 PM, Stefan Mätje wrote:
>>> The original author of the module left our company. Replaced the email
>>> in the MODULE_AUTHOR() macro with a valid one.
>>>
>>> Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
>>> ---
>>>  drivers/net/can/usb/esd_usb2.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
>>> index be928ce62d32..6183b7707ad7 100644
>>> --- a/drivers/net/can/usb/esd_usb2.c
>>> +++ b/drivers/net/can/usb/esd_usb2.c
>>> @@ -2,6 +2,7 @@
>>>   * CAN driver for esd CAN-USB/2 and CAN-USB/Micro
>>>   *
>>>   * Copyright (C) 2010-2012 Matthias Fuchs <matthias.fuchs@esd.eu>, esd gmbh
>>> + * Copyright (C)      2017 Stefan Maetje <stefan.maetje@esd.eu>, esd gmbh
>>
>> Hmmm a copyright for a one liner?
> 
> Yes, it's somewhat ridiculous but I only wanted to make it clear not to
> use Matthias's address any more already at the top of the source file.
> 
>>>   *
>>>   * This program is free software; you can redistribute it and/or modify it
>>>   * under the terms of the GNU General Public License as published
>>> @@ -26,7 +27,7 @@
>>>  #include <linux/can/dev.h>
>>>  #include <linux/can/error.h>
>>>
>>> -MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
>>> +MODULE_AUTHOR("Stefan Maetje <stefan.maetje@esd.eu>");
>>
>> Maybe you should create a roll email address at your company and change
>> Matthias Fuchs's email to something like kernel@esd.eu. Think about
>> adding you or that role email to the MAINTAINERS file.
> 
> I would suggest an email address of "linux-kernel@esd.eu" which would
> result then in
> 
> MODULE_AUTHOR("<linux-kernel@esd.eu>")
> 
> Would that be ok?

I was thinking of:

-MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
+MODULE_AUTHOR("Matthias Fuchs <linux-kernel@esd.eu>");

aswell as for the copyright.

> On the other hand I would hesitate to add that email address to the
> kernel's MAINTAINER file. Then it would stand side by side to your and
> Wolfgang Grandeggers email adresses under "CAN NETWORK DRIVERS".
> 
> Or do you mean to create a new section only describing the esd driver
> for the CAN-USB/2?

Yes.

> Wouldn't that be overkill also?

No, that's what that file is used for. All automated scripts use this
file instead of the copyright line or the MODULE_AUTHOR.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] can: usb: esd_usb2: Replaced stale MODULE_AUTHOR tag

[Stefan Mätje]

Am 19.10.2017 um 09:55 schrieb Marc Kleine-Budde:
> On 10/18/2017 04:35 PM, Stefan Mätje wrote:
>> Am 18.10.2017 um 13:48 schrieb Marc Kleine-Budde:
>>> On 10/18/2017 01:25 PM, Stefan Mätje wrote:
>>>> The original author of the module left our company. Replaced the email
>>>> in the MODULE_AUTHOR() macro with a valid one.
>>>>
>>>> Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
>>>> ---
>>>>  drivers/net/can/usb/esd_usb2.c | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
>>>> index be928ce62d32..6183b7707ad7 100644
>>>> --- a/drivers/net/can/usb/esd_usb2.c
>>>> +++ b/drivers/net/can/usb/esd_usb2.c
>>>> @@ -2,6 +2,7 @@
>>>>   * CAN driver for esd CAN-USB/2 and CAN-USB/Micro
>>>>   *
>>>>   * Copyright (C) 2010-2012 Matthias Fuchs <matthias.fuchs@esd.eu>, esd gmbh
>>>> + * Copyright (C)      2017 Stefan Maetje <stefan.maetje@esd.eu>, esd gmbh
>>>
>>> Hmmm a copyright for a one liner?
>>
>> Yes, it's somewhat ridiculous but I only wanted to make it clear not to
>> use Matthias's address any more already at the top of the source file.
>>
>>>>   *
>>>>   * This program is free software; you can redistribute it and/or modify it
>>>>   * under the terms of the GNU General Public License as published
>>>> @@ -26,7 +27,7 @@
>>>>  #include <linux/can/dev.h>
>>>>  #include <linux/can/error.h>
>>>>
>>>> -MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
>>>> +MODULE_AUTHOR("Stefan Maetje <stefan.maetje@esd.eu>");
>>>
>>> Maybe you should create a roll email address at your company and change
>>> Matthias Fuchs's email to something like kernel@esd.eu. Think about
>>> adding you or that role email to the MAINTAINERS file.
>>
>> I would suggest an email address of "linux-kernel@esd.eu" which would
>> result then in
>>
>> MODULE_AUTHOR("<linux-kernel@esd.eu>")
>>
>> Would that be ok?
> 
> I was thinking of:
> 
> -MODULE_AUTHOR("Matthias Fuchs <matthias.fuchs@esd.eu>");
> +MODULE_AUTHOR("Matthias Fuchs <linux-kernel@esd.eu>");
> 
> aswell as for the copyright.

That looks good for me.

> 
>> On the other hand I would hesitate to add that email address to the
>> kernel's MAINTAINER file. Then it would stand side by side to your and
>> Wolfgang Grandeggers email adresses under "CAN NETWORK DRIVERS".
>>
>> Or do you mean to create a new section only describing the esd driver
>> for the CAN-USB/2?
> 
> Yes.
> 
>> Wouldn't that be overkill also?
> 
> No, that's what that file is used for. All automated scripts use this
> file instead of the copyright line or the MODULE_AUTHOR.
> 
> Marc

But after discussing your proposal with the MODULE_AUTHOR stuff again
with some other people in house I would like to recall this patch
request and drop it entirely for the moment.

I think we will come back later on this.

Thank you for your effort.

Stefan