All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel+amd-gfx@molgen.mpg.de>
To: Dennis Li <Dennis.Li@amd.com>
Cc: Alex Deucher <alexdeucher@gmail.com>,
	Tao Zhou <Tao.Zhou1@amd.com>,
	amd-gfx@lists.freedesktop.org, Guchun Chen <Guchun.Chen@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset
Date: Mon, 13 Jul 2020 15:10:00 +0200	[thread overview]
Message-ID: <8cc739a2-b0ab-1423-b3d2-a823217ae168@molgen.mpg.de> (raw)
In-Reply-To: <DM5PR12MB2533EF1CF7F4AC2D83DCC2DDED650@DM5PR12MB2533.namprd12.prod.outlook.com>

Dear Dennis,


Am 10.07.20 um 10:39 schrieb Li, Dennis:

> I used our internal tool to make GPU hang and do stress test.

Interesting. I want to have such a tool. ;-)

So you noticed it during testing with that tool, and not by somebody 
experiencing this in production?

> In kernel, when GPU hang, driver has multi-paths to enter 
> amdgpu_device_gpu_recover, the  atomic  adev->in_gpu_reset is used
> to avoid re-entering GPU recovery. During GPU reset and resume, it
> is unsafe that other threads access GPU, which maybe cause GPU reset 
> failed. Therefore the new rw_semaphore  adev->reset_sem is 
> introduced, which protect GPU from being accessed by external
> threads when doing recovery.

Thank you for the explanation. It’d be great if you added this to the
commit message.


Kind regards,

Paul
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-07-13 13:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  7:48 [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset Dennis Li
2020-07-08 11:42 ` Paul Menzel
2020-07-10  8:39   ` Li, Dennis
2020-07-13 13:10     ` Paul Menzel [this message]
2020-07-10 12:52 ` Christian König
2020-07-10 14:33 ` Andrey Grodzovsky
2020-07-12  5:31   ` Li, Dennis
2020-07-13  3:40     ` Andrey Grodzovsky
2020-07-10 15:07 ` Andrey Grodzovsky
2020-07-10 17:24   ` Li, Dennis
2020-07-10 17:54     ` Andrey Grodzovsky
2020-07-11  3:26       ` Li, Dennis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cc739a2-b0ab-1423-b3d2-a823217ae168@molgen.mpg.de \
    --to=pmenzel+amd-gfx@molgen.mpg.de \
    --cc=Dennis.Li@amd.com \
    --cc=Guchun.Chen@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Tao.Zhou1@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.