From: Paul Menzel <pmenzel+amd-gfx@molgen.mpg.de>
To: Dennis Li <Dennis.Li@amd.com>
Cc: Alex Deucher <alexdeucher@gmail.com>,
Tao Zhou <Tao.Zhou1@amd.com>, Guchun Chen <Guchun.Chen@amd.com>,
amd-gfx@lists.freedesktop.org,
Hawkin Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset
Date: Wed, 8 Jul 2020 13:42:28 +0200 [thread overview]
Message-ID: <b398cbc4-7dfa-c5de-e806-492e08f2da37@molgen.mpg.de> (raw)
In-Reply-To: <20200708074800.10093-1-Dennis.Li@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]
Dear Dennis,
Thank you for you patch.
On 2020-07-08 09:48, Dennis Li wrote:
> During GPU reset, driver should hold on all external access to
> GPU, otherwise psp will randomly fail to do post, and then cause
> system hang.
Maybe update the commit message summary to read:
> Avoid external GPU access on GPU reset to fix system hang
As I am also experiencing system hangs, it would be great to have more
details. What systems are affected? What PSP firmware version? Will the
PSP firmware be fixed, or is the Linux driver violating the API.
How can the hang be reproduced?
Lastly, please explain your changes? Why does `atomic_read()` help for
example?
> v2:
> 1. add rwlock for some ioctls, debugfs and file-close function.
> 2. change to use dqm->is_resetting and dqm_lock for protection in kfd
> driver.
> 3. remove try_lock and change adev->in_gpu_reset as atomic, to avoid
> re-enter GPU recovery for the same GPU hang.
>
> Signed-off-by: Dennis Li <Dennis.Li@amd.com>
> Change-Id: I7f77a72795462587ed7d5f51fe53a594a0f1f708
[…]
Kind regards,
Paul
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-07-08 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 7:48 [PATCH v2] drm/amdgpu: fix system hang issue during GPU reset Dennis Li
2020-07-08 11:42 ` Paul Menzel [this message]
2020-07-10 8:39 ` Li, Dennis
2020-07-13 13:10 ` Paul Menzel
2020-07-10 12:52 ` Christian König
2020-07-10 14:33 ` Andrey Grodzovsky
2020-07-12 5:31 ` Li, Dennis
2020-07-13 3:40 ` Andrey Grodzovsky
2020-07-10 15:07 ` Andrey Grodzovsky
2020-07-10 17:24 ` Li, Dennis
2020-07-10 17:54 ` Andrey Grodzovsky
2020-07-11 3:26 ` Li, Dennis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b398cbc4-7dfa-c5de-e806-492e08f2da37@molgen.mpg.de \
--to=pmenzel+amd-gfx@molgen.mpg.de \
--cc=Dennis.Li@amd.com \
--cc=Guchun.Chen@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Tao.Zhou1@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.