[PATCH] tracing/probes: Mark expected switch fall-through

[PATCH] tracing/probes: Mark expected switch fall-through

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:
kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   arg++; /* Skip '+', because kstrtol() rejects it. */
   ~~~^~
kernel/trace/trace_probe.c:303:2: note: here
  case '-':
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 kernel/trace/trace_probe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 9962cb5da8ac..89da34b326e3 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,
 
 	case '+':	/* deref memory */
 		arg++;	/* Skip '+', because kstrtol() rejects it. */
+		/* fall through */
 	case '-':
 		tmp = strchr(arg, '(');
 		if (!tmp)
-- 
2.20.1

Re: [PATCH] tracing/probes: Mark expected switch fall-through

[Steven Rostedt]

On Tue, 12 Feb 2019 15:10:40 -0600
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:
> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    arg++; /* Skip '+', because kstrtol() rejects it. */
>    ~~~^~
> kernel/trace/trace_probe.c:303:2: note: here
>   case '-':
>   ^~~~

I also already applied this patch (still need to run through tests)

  http://lkml.kernel.org/r/20190114203039.16535-1-malat@debian.org

-- Steve

> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  kernel/trace/trace_probe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 9962cb5da8ac..89da34b326e3 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,
>  
>  	case '+':	/* deref memory */
>  		arg++;	/* Skip '+', because kstrtol() rejects it. */
> +		/* fall through */
>  	case '-':
>  		tmp = strchr(arg, '(');
>  		if (!tmp)

Re: [PATCH] tracing/probes: Mark expected switch fall-through

[Gustavo A. R. Silva]

On 2/13/19 8:04 AM, Steven Rostedt wrote:
> On Tue, 12 Feb 2019 15:10:40 -0600
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:
>> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    arg++; /* Skip '+', because kstrtol() rejects it. */
>>    ~~~^~
>> kernel/trace/trace_probe.c:303:2: note: here
>>   case '-':
>>   ^~~~
> 
> I also already applied this patch (still need to run through tests)
> 
>   http://lkml.kernel.org/r/20190114203039.16535-1-malat@debian.org
> 

Oh, that's great. :)

Thanks
--
Gustavo