From: Joe Perches <joe@perches.com>
To: Khalid Aziz <khalid@gonehiking.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use
Date: Fri, 16 Apr 2021 17:09:21 -0700 [thread overview]
Message-ID: <8cf34ba1ecc98fd16eb29d298e7a924db810923d.camel@perches.com> (raw)
In-Reply-To: <a5a70c48-d980-b0e0-6bbd-34dae9c59c59@gonehiking.org>
On Fri, 2021-04-16 at 14:41 -0600, Khalid Aziz wrote:
> On 4/15/21 8:08 PM, Joe Perches wrote:
> > And while it's a lot more code, I'd prefer a solution that looks more
> > like the other commonly used kernel logging extension mechanisms
> > where adapter is placed before the format, ... in the argument list.
>
> Hi Joe,
>
> I don't mind making these changes. It is quite a bit of code but
> consistency with other kernel code is useful. Would you like to finalize
> this patch, or would you prefer that I take this patch as starting point
> and finalize it?
Probably better to apply Maciej's patches first and then something
like this.
btw: the coccinelle script was
@@
expression a, b;
@@
\(blogic_announce\|blogic_info\|blogic_notice\|blogic_warn\|blogic_err\)(
- a, b
+ b, a
, ...)
next prev parent reply other threads:[~2021-04-17 0:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 22:38 [PATCH 0/5] Bring the BusLogic host bus adapter driver up to Y2021 Maciej W. Rozycki
2021-04-14 22:39 ` [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use Maciej W. Rozycki
2021-04-16 2:08 ` Joe Perches
2021-04-16 10:48 ` Maciej W. Rozycki
2021-04-16 14:02 ` Joe Perches
2021-04-16 14:28 ` Maciej W. Rozycki
2021-04-16 15:12 ` Joe Perches
2021-04-17 11:39 ` David Laight
2021-04-17 14:01 ` Maciej W. Rozycki
2021-04-16 20:41 ` Khalid Aziz
2021-04-17 0:09 ` Joe Perches [this message]
2021-04-16 19:34 ` Khalid Aziz
2021-04-14 22:39 ` [PATCH 2/5] scsi: BusLogic: Avoid unbounded `vsprintf' use Maciej W. Rozycki
2021-04-16 19:54 ` Khalid Aziz
2021-04-14 22:39 ` [PATCH 3/5] scsi: Provide for avoiding trailing allocation length with VPD inquiries Maciej W. Rozycki
2021-04-14 22:39 ` [PATCH 4/5] scsi: Avoid using reserved length byte " Maciej W. Rozycki
2021-04-14 22:39 ` [PATCH 5/5] scsi: Set allocation length to 255 for ATA Information VPD page Maciej W. Rozycki
2021-04-15 12:42 ` Nix
2021-04-16 15:18 ` Maciej W. Rozycki
2021-04-16 19:36 ` [PATCH 0/5] Bring the BusLogic host bus adapter driver up to Y2021 Khalid Aziz
2021-04-16 21:25 ` Maciej W. Rozycki
2021-04-18 20:21 ` Ondrej Zary
2021-04-19 15:06 ` Khalid Aziz
2021-04-19 16:01 ` Maciej W. Rozycki
2021-04-20 2:16 ` Khalid Aziz
2021-04-20 18:02 ` Maciej W. Rozycki
2021-04-22 2:36 ` Khalid Aziz
2021-04-22 16:27 ` Maciej W. Rozycki
2021-04-22 18:07 ` Khalid Aziz
2021-04-22 23:19 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cf34ba1ecc98fd16eb29d298e7a924db810923d.camel@perches.com \
--to=joe@perches.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.