* [PATCH net] scripts/pahole-flags.sh: Make sure pahole --version works
@ 2021-12-31 7:56 Saeed Mahameed
2022-01-05 13:42 ` Daniel Borkmann
0 siblings, 1 reply; 4+ messages in thread
From: Saeed Mahameed @ 2021-12-31 7:56 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, bpf, Saeed Mahameed, Andrii Nakryiko, Jiri Olsa
From: Saeed Mahameed <saeedm@nvidia.com>
I had a broken pahole and it's been driving me crazy to see tons of the
following error messages on every build.
pahole: symbol lookup error: pahole: undefined symbol: btf_gen_floats
scripts/pahole-flags.sh: line 12: [: : integer expression expected
scripts/pahole-flags.sh: line 16: [: : integer expression expected
Address this by redirecting pahole --version stderr to devnull,
and validate stdout has a non empty string, otherwise exit silently.
Fixes: 9741e07ece7c ("kbuild: Unify options for BTF generation for vmlinux and modules")
CC: Andrii Nakryiko <andrii@kernel.org>
CC: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
scripts/pahole-flags.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
index e6093adf4c06..b3b53f890d40 100755
--- a/scripts/pahole-flags.sh
+++ b/scripts/pahole-flags.sh
@@ -7,7 +7,8 @@ if ! [ -x "$(command -v ${PAHOLE})" ]; then
exit 0
fi
-pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/')
+pahole_ver=$(${PAHOLE} --version 2>/dev/null | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/')
+[ -z "${pahole_ver}" ] && exit 0
if [ "${pahole_ver}" -ge "118" ] && [ "${pahole_ver}" -le "121" ]; then
# pahole 1.18 through 1.21 can't handle zero-sized per-CPU vars
--
2.33.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] scripts/pahole-flags.sh: Make sure pahole --version works 2021-12-31 7:56 [PATCH net] scripts/pahole-flags.sh: Make sure pahole --version works Saeed Mahameed @ 2022-01-05 13:42 ` Daniel Borkmann 2022-01-05 22:14 ` Saeed Mahameed 0 siblings, 1 reply; 4+ messages in thread From: Daniel Borkmann @ 2022-01-05 13:42 UTC (permalink / raw) To: Saeed Mahameed, David S. Miller, Jakub Kicinski Cc: netdev, bpf, Saeed Mahameed, Andrii Nakryiko, Jiri Olsa On 12/31/21 8:56 AM, Saeed Mahameed wrote: > From: Saeed Mahameed <saeedm@nvidia.com> > > I had a broken pahole and it's been driving me crazy to see tons of the > following error messages on every build. > > pahole: symbol lookup error: pahole: undefined symbol: btf_gen_floats > scripts/pahole-flags.sh: line 12: [: : integer expression expected > scripts/pahole-flags.sh: line 16: [: : integer expression expected > > Address this by redirecting pahole --version stderr to devnull, > and validate stdout has a non empty string, otherwise exit silently. I'll leave this up to Andrii, but broken pahole version sounds like it would have been better to fix the local pahole installation instead [rather than the kernel having to guard against it, especially if it's driving you crazy]? I could image that silent exit on empty version string due to broken pahole deployment might rather waste developer's time to then go and debug why btf wasn't generated.. > Fixes: 9741e07ece7c ("kbuild: Unify options for BTF generation for vmlinux and modules") > CC: Andrii Nakryiko <andrii@kernel.org> > CC: Jiri Olsa <jolsa@redhat.com> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > --- > scripts/pahole-flags.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh > index e6093adf4c06..b3b53f890d40 100755 > --- a/scripts/pahole-flags.sh > +++ b/scripts/pahole-flags.sh > @@ -7,7 +7,8 @@ if ! [ -x "$(command -v ${PAHOLE})" ]; then > exit 0 > fi > > -pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') > +pahole_ver=$(${PAHOLE} --version 2>/dev/null | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') > +[ -z "${pahole_ver}" ] && exit 0 > > if [ "${pahole_ver}" -ge "118" ] && [ "${pahole_ver}" -le "121" ]; then > # pahole 1.18 through 1.21 can't handle zero-sized per-CPU vars > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] scripts/pahole-flags.sh: Make sure pahole --version works 2022-01-05 13:42 ` Daniel Borkmann @ 2022-01-05 22:14 ` Saeed Mahameed 2022-01-06 3:45 ` Andrii Nakryiko 0 siblings, 1 reply; 4+ messages in thread From: Saeed Mahameed @ 2022-01-05 22:14 UTC (permalink / raw) To: Daniel Borkmann Cc: David S. Miller, Jakub Kicinski, netdev, bpf, Saeed Mahameed, Andrii Nakryiko, Jiri Olsa On Wed, Jan 05, 2022 at 02:42:01PM +0100, Daniel Borkmann wrote: >On 12/31/21 8:56 AM, Saeed Mahameed wrote: >>From: Saeed Mahameed <saeedm@nvidia.com> >> >>I had a broken pahole and it's been driving me crazy to see tons of the >>following error messages on every build. >> >>pahole: symbol lookup error: pahole: undefined symbol: btf_gen_floats >>scripts/pahole-flags.sh: line 12: [: : integer expression expected >>scripts/pahole-flags.sh: line 16: [: : integer expression expected >> >>Address this by redirecting pahole --version stderr to devnull, >>and validate stdout has a non empty string, otherwise exit silently. > >I'll leave this up to Andrii, but broken pahole version sounds like it would >have been better to fix the local pahole installation instead [rather than the >kernel having to guard against it, especially if it's driving you crazy]? > Already did :) >I could image that silent exit on empty version string due to broken pahole >deployment might rather waste developer's time to then go and debug why btf >wasn't generated.. > Good point, I was mainly thinking about developers who are not familiar with btf and who have no time debugging irrelevant build issues, but up to you, I personally like silent build scripts. >>Fixes: 9741e07ece7c ("kbuild: Unify options for BTF generation for vmlinux and modules") >>CC: Andrii Nakryiko <andrii@kernel.org> >>CC: Jiri Olsa <jolsa@redhat.com> >>Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> >>--- >> scripts/pahole-flags.sh | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >>diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh >>index e6093adf4c06..b3b53f890d40 100755 >>--- a/scripts/pahole-flags.sh >>+++ b/scripts/pahole-flags.sh >>@@ -7,7 +7,8 @@ if ! [ -x "$(command -v ${PAHOLE})" ]; then >> exit 0 >> fi >>-pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') >>+pahole_ver=$(${PAHOLE} --version 2>/dev/null | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') >>+[ -z "${pahole_ver}" ] && exit 0 >> if [ "${pahole_ver}" -ge "118" ] && [ "${pahole_ver}" -le "121" ]; then >> # pahole 1.18 through 1.21 can't handle zero-sized per-CPU vars >> > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] scripts/pahole-flags.sh: Make sure pahole --version works 2022-01-05 22:14 ` Saeed Mahameed @ 2022-01-06 3:45 ` Andrii Nakryiko 0 siblings, 0 replies; 4+ messages in thread From: Andrii Nakryiko @ 2022-01-06 3:45 UTC (permalink / raw) To: Saeed Mahameed Cc: Daniel Borkmann, David S. Miller, Jakub Kicinski, Networking, bpf, Saeed Mahameed, Andrii Nakryiko, Jiri Olsa On Wed, Jan 5, 2022 at 2:14 PM Saeed Mahameed <saeed@kernel.org> wrote: > > On Wed, Jan 05, 2022 at 02:42:01PM +0100, Daniel Borkmann wrote: > >On 12/31/21 8:56 AM, Saeed Mahameed wrote: > >>From: Saeed Mahameed <saeedm@nvidia.com> > >> > >>I had a broken pahole and it's been driving me crazy to see tons of the > >>following error messages on every build. > >> > >>pahole: symbol lookup error: pahole: undefined symbol: btf_gen_floats > >>scripts/pahole-flags.sh: line 12: [: : integer expression expected > >>scripts/pahole-flags.sh: line 16: [: : integer expression expected > >> > >>Address this by redirecting pahole --version stderr to devnull, > >>and validate stdout has a non empty string, otherwise exit silently. > > > >I'll leave this up to Andrii, but broken pahole version sounds like it would > >have been better to fix the local pahole installation instead [rather than the > >kernel having to guard against it, especially if it's driving you crazy]? > > > > Already did :) > > >I could image that silent exit on empty version string due to broken pahole > >deployment might rather waste developer's time to then go and debug why btf > >wasn't generated.. > > > > Good point, I was mainly thinking about developers who are not familiar with btf > and who have no time debugging irrelevant build issues, but up to you, I > personally like silent build scripts. > Sorry, trying to understand. If you didn't use BTF (and thus CONFIG_DEBUG_INFO_BTF is not set), is pahole still being called? If yes, we might want to address that, I suppose. But if you have a broken pahole that emits something to stderr (undefined symbol in shared library), then I agree with Daniel that we shouldn't be working around that in Linux build script. > >>Fixes: 9741e07ece7c ("kbuild: Unify options for BTF generation for vmlinux and modules") > >>CC: Andrii Nakryiko <andrii@kernel.org> > >>CC: Jiri Olsa <jolsa@redhat.com> > >>Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > >>--- > >> scripts/pahole-flags.sh | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >>diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh > >>index e6093adf4c06..b3b53f890d40 100755 > >>--- a/scripts/pahole-flags.sh > >>+++ b/scripts/pahole-flags.sh > >>@@ -7,7 +7,8 @@ if ! [ -x "$(command -v ${PAHOLE})" ]; then > >> exit 0 > >> fi > >>-pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') > >>+pahole_ver=$(${PAHOLE} --version 2>/dev/null | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') > >>+[ -z "${pahole_ver}" ] && exit 0 > >> if [ "${pahole_ver}" -ge "118" ] && [ "${pahole_ver}" -le "121" ]; then > >> # pahole 1.18 through 1.21 can't handle zero-sized per-CPU vars > >> > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-06 3:46 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-31 7:56 [PATCH net] scripts/pahole-flags.sh: Make sure pahole --version works Saeed Mahameed 2022-01-05 13:42 ` Daniel Borkmann 2022-01-05 22:14 ` Saeed Mahameed 2022-01-06 3:45 ` Andrii Nakryiko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.