From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Mikhail Zhilkin <csharper2005@gmail.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: NOGUCHI Hiroshi <drvlabo@gmail.com>, Karim <Karimdplay@gmail.com>, M <x1@disroot.org>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser Date: Thu, 7 Apr 2022 09:48:49 +0200 [thread overview] Message-ID: <8d0d8b27-35ff-3693-cf80-897b80c26b4e@linaro.org> (raw) In-Reply-To: <20220406195946.2019-1-csharper2005@gmail.com> On 06/04/2022 21:59, Mikhail Zhilkin wrote: > Add YAML binding for Sercomm partition parser. > > Signed-off-by: Mikhail Zhilkin <csharper2005@gmail.com> > --- > .../mtd/partitions/sercomm,sc-partitions.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > (...) > + > +properties: > + compatible: > + const: sercomm,sc-partitions > + > + scpart-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Partition id in Sercomm partition map Do you really need it? The reg should define the order, unless you expect some incomplete partition list? In any case this requires vendor prefix. > + > +required: > + - compatible Missing reg. > + - scpart-id > + > +additionalProperties: false Are you sure that you tested your bindings? You miss here address/size cells and children, so you should have big fat warning. Plus your DTS example has error and does not compile... Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Mikhail Zhilkin <csharper2005@gmail.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: NOGUCHI Hiroshi <drvlabo@gmail.com>, Karim <Karimdplay@gmail.com>, M <x1@disroot.org>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser Date: Thu, 7 Apr 2022 09:48:49 +0200 [thread overview] Message-ID: <8d0d8b27-35ff-3693-cf80-897b80c26b4e@linaro.org> (raw) In-Reply-To: <20220406195946.2019-1-csharper2005@gmail.com> On 06/04/2022 21:59, Mikhail Zhilkin wrote: > Add YAML binding for Sercomm partition parser. > > Signed-off-by: Mikhail Zhilkin <csharper2005@gmail.com> > --- > .../mtd/partitions/sercomm,sc-partitions.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > (...) > + > +properties: > + compatible: > + const: sercomm,sc-partitions > + > + scpart-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Partition id in Sercomm partition map Do you really need it? The reg should define the order, unless you expect some incomplete partition list? In any case this requires vendor prefix. > + > +required: > + - compatible Missing reg. > + - scpart-id > + > +additionalProperties: false Are you sure that you tested your bindings? You miss here address/size cells and children, so you should have big fat warning. Plus your DTS example has error and does not compile... Best regards, Krzysztof ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-04-07 7:48 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-06 19:55 [PATCH v2 0/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser Mikhail Zhilkin 2022-04-06 19:55 ` Mikhail Zhilkin 2022-04-06 19:59 ` [PATCH v2 1/2] " Mikhail Zhilkin 2022-04-06 19:59 ` Mikhail Zhilkin 2022-04-07 7:48 ` Krzysztof Kozlowski [this message] 2022-04-07 7:48 ` Krzysztof Kozlowski 2022-04-09 12:26 ` Mikhail Zhilkin 2022-04-09 12:26 ` Mikhail Zhilkin 2022-04-09 12:43 ` Krzysztof Kozlowski 2022-04-09 12:43 ` Krzysztof Kozlowski 2022-04-09 18:04 ` Mikhail Zhilkin 2022-04-09 18:04 ` Mikhail Zhilkin 2022-04-09 18:17 ` Mikhail Zhilkin 2022-04-09 18:17 ` Mikhail Zhilkin 2022-04-10 8:18 ` Krzysztof Kozlowski 2022-04-10 8:18 ` Krzysztof Kozlowski 2022-04-28 15:24 ` Mikhail Zhilkin 2022-04-28 15:24 ` Mikhail Zhilkin 2022-04-29 6:46 ` Krzysztof Kozlowski 2022-04-29 6:46 ` Krzysztof Kozlowski 2022-04-29 15:26 ` Mikhail Zhilkin 2022-04-29 15:26 ` Mikhail Zhilkin 2022-04-29 20:22 ` Krzysztof Kozlowski 2022-04-29 20:22 ` Krzysztof Kozlowski 2022-04-30 8:04 ` Mikhail Zhilkin 2022-04-30 8:04 ` Mikhail Zhilkin 2022-04-30 14:35 ` Krzysztof Kozlowski 2022-04-30 14:35 ` Krzysztof Kozlowski 2022-04-30 18:54 ` Mikhail Zhilkin 2022-04-30 18:54 ` Mikhail Zhilkin 2022-05-01 8:17 ` Krzysztof Kozlowski 2022-05-01 8:17 ` Krzysztof Kozlowski 2022-05-01 14:51 ` Mikhail Zhilkin 2022-05-01 14:51 ` Mikhail Zhilkin 2022-05-01 16:17 ` Krzysztof Kozlowski 2022-05-01 16:17 ` Krzysztof Kozlowski 2022-05-02 5:42 ` Mikhail Zhilkin 2022-05-02 5:42 ` Mikhail Zhilkin 2022-04-10 8:14 ` Krzysztof Kozlowski 2022-04-10 8:14 ` Krzysztof Kozlowski 2022-04-07 13:50 ` Rob Herring 2022-04-07 13:50 ` Rob Herring 2022-04-09 12:35 ` Mikhail Zhilkin 2022-04-09 12:35 ` Mikhail Zhilkin 2022-04-09 12:49 ` Krzysztof Kozlowski 2022-04-09 12:49 ` Krzysztof Kozlowski 2022-04-10 6:54 ` Mikhail Zhilkin 2022-04-10 6:54 ` Mikhail Zhilkin 2022-04-06 20:00 ` [PATCH v2 2/2] mtd: parsers: add support for Sercomm partitions Mikhail Zhilkin 2022-04-06 20:00 ` Mikhail Zhilkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8d0d8b27-35ff-3693-cf80-897b80c26b4e@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=Karimdplay@gmail.com \ --cc=csharper2005@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=drvlabo@gmail.com \ --cc=krzk+dt@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=vigneshr@ti.com \ --cc=x1@disroot.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.