Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Hi Pedro,

On 09/02/22 22:35, Pedro Aguilar wrote:
> Hi Giulio,
> 
> On 2/8/22 23:54, Giulio Benetti wrote:
>> Hi again Pedro,
>>
>> I've reproduced the build failure with your previous attached .config
>> file and this patch fixes it. So below...
>>
>> On 08/02/22 23:06, Giulio Benetti wrote:
>>> Hi Pedro,
>>>
>>> On 08/02/22 22:37, Pedro Aguilar wrote:
>>>> If it's not present, enable libiconv.
>>> Here it's missing:
>>> Fixes:
>>> URL to autobuilder failure
>>
>> ...please provide the autobuilder failure URL and if it doesn't exist
>> than we don't need it.
> 
> AFAIK, the build failure fixed by this patch was not reported by the
> autobuilder, so I'm afraid there isn't any URL to share.
> 
> In a previous email I wrongly mentioned that it fixed an autobuilder
> failure, but all those failures are linked to another issue that seems
> to be fixed by a patch sent by Fabrice, although I haven't tested it:
> 
> https://lists.buildroot.org/pipermail/buildroot/2022-February/636041.html

Ok, so no autobuilder failure.

> May be the commit message of the current v2 patch can remain as is.

Can you improve the commit log a bit? Try to 'git log --grep=' some file 
which has that fix, or git blame it so you can find the commit log and 
imitate it. That's the best way to learn how to write commit logs.

Because "Add BR2_ENABLE_LOCALE as dependency." doesn't mean that much,
and "If it's not present, enable libiconv." doesn't sound so good.

What about:
```
package/guile: fix build failure due to missing libiconv

When building package guile with BR2_ENABLE_LOCALE=n we get the 
following error:
```
In file included from filesys.c:95:
ports-internal.h:26:10: fatal error: iconv.h: No such file or directory
    26 | #include <iconv.h>
       |          ^~~~~~~~~
compilation terminated.
```

So let's fix it by selecting BR2_PACKAGE_LIBICONV and adding libiconv 
package as dependency.

Signed-off-by: Pedro...
```

Can you please a V3 with this also pointing the V1->V2, V2->V3 changes?

Thank you!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot