Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Hi again Pedro,

I've reproduced the build failure with your previous attached .config 
file and this patch fixes it. So below...

On 08/02/22 23:06, Giulio Benetti wrote:
> Hi Pedro,
> 
> On 08/02/22 22:37, Pedro Aguilar wrote:
>> If it's not present, enable libiconv.
> Here it's missing:
> Fixes:
> URL to autobuilder failure

...please provide the autobuilder failure URL and if it doesn't exist 
than we don't need it.

So once done this I can give you my Review.

Waiting for V2 with improved commit log then.

Thank you!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> 
> And also I can't find guile failing due to LIBICONV.
> 
> At least, I only find:
> http://autobuild.buildroot.net/?reason=guile-3.0.7
> 
> But it seems to be about another problem(to be solved too).
> 
> Can you please point the autobuilder failure?
> Otherwise I can't test/review your patch.
> 
> Thank you!
> Best regards
> -- Giulio Benetti Benetti Engineering sas
>> Signed-off-by: Pedro Aguilar<paguilar@paguilar.org>
>>
>> ---
>> Changes v1 -> v2:
>>     - Use BR2_ENABLE_LOCALE if selected, otherwise use libiconv
>>       as before (pointed out by Thomas and Giulio)
>> ---
>>    package/guile/Config.in | 1 +
>>    package/guile/guile.mk  | 4 ++++
>>    2 files changed, 5 insertions(+)
>>
>> diff --git a/package/guile/Config.in b/package/guile/Config.in
>> index b1182a4cee..f70e674018 100644
>> --- a/package/guile/Config.in
>> +++ b/package/guile/Config.in
>> @@ -9,6 +9,7 @@ config BR2_PACKAGE_GUILE
>>    	select BR2_PACKAGE_LIBFFI
>>    	select BR2_PACKAGE_GMP
>>    	select BR2_PACKAGE_BDWGC
>> +	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>>    	help
>>    	  Guile is an interpreter and compiler for the Scheme
>>    	  programming language, a clean and elegant dialect of Lisp.
>> diff --git a/package/guile/guile.mk b/package/guile/guile.mk
>> index 0f245fca76..03420407f8 100644
>> --- a/package/guile/guile.mk
>> +++ b/package/guile/guile.mk
>> @@ -18,6 +18,10 @@ GUILE_CPE_ID_VENDOR = gnu
>>    GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf
>>    HOST_GUILE_DEPENDENCIES = host-libunistring host-libffi host-gmp host-bdwgc host-flex host-pkgconf host-gettext
>>    
>> +ifeq ($(BR2_ENABLE_LOCALE),)
>> +GUILE_DEPENDENCIES += libiconv
>> +endif
>> +
>>    # The HAVE_GC* CFLAGS specify that we will use internal callbacks
>>    # instead of the ones provided by
>>    # bdwgc. Eg. HAVE_GC_SET_FINALIZER_NOTIFIER specifies that we won't
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot