* [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome model
@ 2021-03-03 15:45 Babu Moger
2021-03-03 16:22 ` david.edmondson
0 siblings, 1 reply; 4+ messages in thread
From: Babu Moger @ 2021-03-03 15:45 UTC (permalink / raw)
To: pbonzini, richard.henderson, ehabkost
Cc: babu.moger, pankaj.gupta, qemu-devel
Found the following cpu feature bits missing from EPYC-Rome model.
ibrs : Indirect Branch Restricted Speculation
ssbd : Speculative Store Bypass Disable
These new features will be added in EPYC-Rome-v2. The -cpu help output
after the change.
x86 EPYC-Rome (alias configured by machine type)
x86 EPYC-Rome-v1 AMD EPYC-Rome Processor
x86 EPYC-Rome-v2 AMD EPYC-Rome Processor
Reported-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
---
v2: Model-id remains same between EPYC-Rome-v1 and EPYC-Rome-v2.
Removed model-id in the patch.
target/i386/cpu.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 6a53446e6a..30e7188b0e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -4179,6 +4179,18 @@ static X86CPUDefinition builtin_x86_defs[] = {
.xlevel = 0x8000001E,
.model_id = "AMD EPYC-Rome Processor",
.cache_info = &epyc_rome_cache_info,
+ .versions = (X86CPUVersionDefinition[]) {
+ { .version = 1 },
+ {
+ .version = 2,
+ .props = (PropValue[]) {
+ { "ibrs", "on" },
+ { "amd-ssbd", "on" },
+ { /* end of list */ }
+ }
+ },
+ { /* end of list */ }
+ }
},
{
.name = "EPYC-Milan",
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome model
2021-03-03 15:45 [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome model Babu Moger
@ 2021-03-03 16:22 ` david.edmondson
[not found] ` <CAATJJ0KLga4V1vhyaAi9A6Gd6sXXah=RKo6PYEztgsjMmCHUww@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: david.edmondson @ 2021-03-03 16:22 UTC (permalink / raw)
To: Babu Moger, pbonzini, richard.henderson, ehabkost
Cc: babu.moger, pankaj.gupta, qemu-devel
On Wednesday, 2021-03-03 at 09:45:30 -06, Babu Moger wrote:
> Found the following cpu feature bits missing from EPYC-Rome model.
> ibrs : Indirect Branch Restricted Speculation
> ssbd : Speculative Store Bypass Disable
>
> These new features will be added in EPYC-Rome-v2. The -cpu help output
> after the change.
>
> x86 EPYC-Rome (alias configured by machine type)
> x86 EPYC-Rome-v1 AMD EPYC-Rome Processor
> x86 EPYC-Rome-v2 AMD EPYC-Rome Processor
>
> Reported-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> ---
> v2: Model-id remains same between EPYC-Rome-v1 and EPYC-Rome-v2.
> Removed model-id in the patch.
>
> target/i386/cpu.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 6a53446e6a..30e7188b0e 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -4179,6 +4179,18 @@ static X86CPUDefinition builtin_x86_defs[] = {
> .xlevel = 0x8000001E,
> .model_id = "AMD EPYC-Rome Processor",
> .cache_info = &epyc_rome_cache_info,
> + .versions = (X86CPUVersionDefinition[]) {
> + { .version = 1 },
> + {
> + .version = 2,
> + .props = (PropValue[]) {
> + { "ibrs", "on" },
> + { "amd-ssbd", "on" },
> + { /* end of list */ }
> + }
> + },
> + { /* end of list */ }
> + }
> },
> {
> .name = "EPYC-Milan",
dme.
--
And the sign said: long haired freaky people need not apply.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome model
[not found] ` <CAATJJ0KLga4V1vhyaAi9A6Gd6sXXah=RKo6PYEztgsjMmCHUww@mail.gmail.com>
@ 2021-04-08 15:28 ` Babu Moger
2021-04-08 20:46 ` Eduardo Habkost
0 siblings, 1 reply; 4+ messages in thread
From: Babu Moger @ 2021-04-08 15:28 UTC (permalink / raw)
To: Christian Ehrhardt, Eduardo Habkost
Cc: Eduardo Habkost, Richard Henderson, qemu-devel, david.edmondson,
pankaj.gupta, Igor Mammedov, Paolo Bonzini
> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Thursday, April 1, 2021 3:06 AM
> To: david.edmondson@oracle.com
> Cc: Moger, Babu <Babu.Moger@amd.com>; Paolo Bonzini
> <pbonzini@redhat.com>; Richard Henderson
> <richard.henderson@linaro.org>; Eduardo Habkost
> <ehabkost@redhat.com>; pankaj.gupta@cloud.ionos.com
> Subject: Re: [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome
> model
>
> On Wed, Mar 3, 2021 at 5:24 PM <david.edmondson@oracle.com> wrote:
> >
> > On Wednesday, 2021-03-03 at 09:45:30 -06, Babu Moger wrote:
> >
> > > Found the following cpu feature bits missing from EPYC-Rome model.
> > > ibrs : Indirect Branch Restricted Speculation
> > > ssbd : Speculative Store Bypass Disable
> > >
> > > These new features will be added in EPYC-Rome-v2. The -cpu help
> > > output after the change.
> > >
> > > x86 EPYC-Rome (alias configured by machine type)
> > > x86 EPYC-Rome-v1 AMD EPYC-Rome Processor
> > > x86 EPYC-Rome-v2 AMD EPYC-Rome Processor
> > >
> > > Reported-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> > > Signed-off-by: Babu Moger <babu.moger@amd.com>
> > > Signed-off-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> >
> > Reviewed-by: David Edmondson <david.edmondson@oracle.com>
>
> Hi,
> this change/discussion seems as it was good back then but I realized it wasn't
> applied in git yet.
> Was there a different thread discussing what holds it back that I could not yet
> find?
> Since we are already in v6.0.0-rc1 the window to get it in shrinks, so I wanted
> to give this a gentle ping.
Eduardo,
Do you have any concerns with these patches? It is also fixing another
problem reported here.
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1915063
Can you please pull these changes?
Thanks
Babu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome model
2021-04-08 15:28 ` Babu Moger
@ 2021-04-08 20:46 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2021-04-08 20:46 UTC (permalink / raw)
To: Babu Moger
Cc: Richard Henderson, qemu-devel, Christian Ehrhardt,
david.edmondson, pankaj.gupta, Igor Mammedov, Paolo Bonzini
On Thu, Apr 08, 2021 at 10:28:21AM -0500, Babu Moger wrote:
>
>
> > -----Original Message-----
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Sent: Thursday, April 1, 2021 3:06 AM
> > To: david.edmondson@oracle.com
> > Cc: Moger, Babu <Babu.Moger@amd.com>; Paolo Bonzini
> > <pbonzini@redhat.com>; Richard Henderson
> > <richard.henderson@linaro.org>; Eduardo Habkost
> > <ehabkost@redhat.com>; pankaj.gupta@cloud.ionos.com
> > Subject: Re: [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome
> > model
> >
> > On Wed, Mar 3, 2021 at 5:24 PM <david.edmondson@oracle.com> wrote:
> > >
> > > On Wednesday, 2021-03-03 at 09:45:30 -06, Babu Moger wrote:
> > >
> > > > Found the following cpu feature bits missing from EPYC-Rome model.
> > > > ibrs : Indirect Branch Restricted Speculation
> > > > ssbd : Speculative Store Bypass Disable
> > > >
> > > > These new features will be added in EPYC-Rome-v2. The -cpu help
> > > > output after the change.
> > > >
> > > > x86 EPYC-Rome (alias configured by machine type)
> > > > x86 EPYC-Rome-v1 AMD EPYC-Rome Processor
> > > > x86 EPYC-Rome-v2 AMD EPYC-Rome Processor
> > > >
> > > > Reported-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> > > > Signed-off-by: Babu Moger <babu.moger@amd.com>
> > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> > >
> > > Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> >
> > Hi,
> > this change/discussion seems as it was good back then but I realized it wasn't
> > applied in git yet.
> > Was there a different thread discussing what holds it back that I could not yet
> > find?
> > Since we are already in v6.0.0-rc1 the window to get it in shrinks, so I wanted
> > to give this a gentle ping.
>
> Eduardo,
> Do you have any concerns with these patches? It is also fixing another
> problem reported here.
> https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1915063
> Can you please pull these changes?
I'm so sorry for missing this when it was submitted in March.
I'm queueing it right now and I'm going to submit a pull request
very soon, for -rc4.
--
Eduardo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-08 20:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 15:45 [PATCH v2] i386: Add missing cpu feature bits in EPYC-Rome model Babu Moger
2021-03-03 16:22 ` david.edmondson
[not found] ` <CAATJJ0KLga4V1vhyaAi9A6Gd6sXXah=RKo6PYEztgsjMmCHUww@mail.gmail.com>
2021-04-08 15:28 ` Babu Moger
2021-04-08 20:46 ` Eduardo Habkost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.