All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: "Krzysztof Hałasa" <khalasa@piap.pl>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo
Date: Wed, 06 Oct 2021 09:36:05 +0200	[thread overview]
Message-ID: <8d54835921f1648a4d50d8d4e160b5a12582590f.camel@pengutronix.de> (raw)
In-Reply-To: <m3sfxen0yw.fsf@t19.piap.pl>

Am Mittwoch, dem 06.10.2021 um 08:04 +0200 schrieb Krzysztof Hałasa:
> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
> for SOC_IMX6Q.
> 
I don't think that's helpful, you would need to at least also print
"Dual" to make it correct. The Solo is just a fused down version of the
DualLite, just as the Dual is a fused down version of the Quad.

Quad/DualLite refers to the two different die versions of the chip.

Regards,
Lucas

> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index b407b024dde3..b6f2f2ea8e65 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -143,7 +143,7 @@ config SOC_IMX6
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  
>  config SOC_IMX6Q
> -	bool "i.MX6 Quad/DualLite support"
> +	bool "i.MX6 Quad/DualLite/Solo support"
>  	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_775420
> @@ -153,7 +153,7 @@ config SOC_IMX6Q
>  	select SOC_IMX6
>  
>  	help
> -	  This enables support for Freescale i.MX6 Quad processor.
> +	  This enables support for Freescale i.MX6 Quad/DualLite/Solo processors.
>  
>  config SOC_IMX6SL
>  	bool "i.MX6 SoloLite support"
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..8cc8a2ed1d12 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = {
>  	NULL,
>  };
>  
> -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)")
> +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)")
>  	.l2c_aux_val 	= 0,
>  	.l2c_aux_mask	= ~0,
>  	.smp		= smp_ops(imx_smp_ops),
> 



WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de>
To: "Krzysztof Hałasa" <khalasa@piap.pl>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@gmail.com>,
	 NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo
Date: Wed, 06 Oct 2021 09:36:05 +0200	[thread overview]
Message-ID: <8d54835921f1648a4d50d8d4e160b5a12582590f.camel@pengutronix.de> (raw)
In-Reply-To: <m3sfxen0yw.fsf@t19.piap.pl>

Am Mittwoch, dem 06.10.2021 um 08:04 +0200 schrieb Krzysztof Hałasa:
> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
> for SOC_IMX6Q.
> 
I don't think that's helpful, you would need to at least also print
"Dual" to make it correct. The Solo is just a fused down version of the
DualLite, just as the Dual is a fused down version of the Quad.

Quad/DualLite refers to the two different die versions of the chip.

Regards,
Lucas

> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index b407b024dde3..b6f2f2ea8e65 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -143,7 +143,7 @@ config SOC_IMX6
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  
>  config SOC_IMX6Q
> -	bool "i.MX6 Quad/DualLite support"
> +	bool "i.MX6 Quad/DualLite/Solo support"
>  	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_775420
> @@ -153,7 +153,7 @@ config SOC_IMX6Q
>  	select SOC_IMX6
>  
>  	help
> -	  This enables support for Freescale i.MX6 Quad processor.
> +	  This enables support for Freescale i.MX6 Quad/DualLite/Solo processors.
>  
>  config SOC_IMX6SL
>  	bool "i.MX6 SoloLite support"
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..8cc8a2ed1d12 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = {
>  	NULL,
>  };
>  
> -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)")
> +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)")
>  	.l2c_aux_val 	= 0,
>  	.l2c_aux_mask	= ~0,
>  	.smp		= smp_ops(imx_smp_ops),
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-06  7:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  6:04 [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo Krzysztof Hałasa
2021-10-06  6:04 ` Krzysztof Hałasa
2021-10-06  6:17 ` Ahmad Fatoum
2021-10-06  6:17   ` Ahmad Fatoum
2021-10-06  7:36 ` Lucas Stach [this message]
2021-10-06  7:36   ` Lucas Stach
2021-10-06  8:17   ` Krzysztof Hałasa
2021-10-06  8:17     ` Krzysztof Hałasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d54835921f1648a4d50d8d4e160b5a12582590f.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=khalasa@piap.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.