* [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-20 7:13 ` YueHaibing
0 siblings, 0 replies; 7+ messages in thread
From: YueHaibing @ 2020-03-20 7:13 UTC (permalink / raw)
To: ldewangan, jonathanh, dan.j.williams, vkoul, thierry.reding, swarren
Cc: dmaengine, linux-tegra, linux-kernel, digetx, YueHaibing
When CONFIG_PM is disabled, gcc warning this:
drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
Make it as __maybe_unused to fix the warnings,
also remove unneeded function declarations.
Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/dma/tegra20-apb-dma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 4e295d121be6..b33000976f66 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -263,8 +263,6 @@ static inline struct device *tdc2dev(struct tegra_dma_channel *tdc)
}
static dma_cookie_t tegra_dma_tx_submit(struct dma_async_tx_descriptor *tx);
-static int tegra_dma_runtime_suspend(struct device *dev);
-static int tegra_dma_runtime_resume(struct device *dev);
/* Get DMA desc from free list, if not there then allocate it. */
static struct tegra_dma_desc *tegra_dma_desc_get(struct tegra_dma_channel *tdc)
@@ -1575,7 +1573,7 @@ static int tegra_dma_remove(struct platform_device *pdev)
return 0;
}
-static int tegra_dma_runtime_suspend(struct device *dev)
+static int __maybe_unused tegra_dma_runtime_suspend(struct device *dev)
{
struct tegra_dma *tdma = dev_get_drvdata(dev);
@@ -1584,7 +1582,7 @@ static int tegra_dma_runtime_suspend(struct device *dev)
return 0;
}
-static int tegra_dma_runtime_resume(struct device *dev)
+static int __maybe_unused tegra_dma_runtime_resume(struct device *dev)
{
struct tegra_dma *tdma = dev_get_drvdata(dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-20 7:13 ` YueHaibing
0 siblings, 0 replies; 7+ messages in thread
From: YueHaibing @ 2020-03-20 7:13 UTC (permalink / raw)
To: ldewangan-DDmLM1+adcrQT0dZR+AlfA,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w,
vkoul-DgEjT+Ai2ygdnm+yROfE0A,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
swarren-3lzwWm7+Weoh9ZMKESR00Q
Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
digetx-Re5JQEeQqe8AvxtiuMwx3w, YueHaibing
When CONFIG_PM is disabled, gcc warning this:
drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
Make it as __maybe_unused to fix the warnings,
also remove unneeded function declarations.
Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
drivers/dma/tegra20-apb-dma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 4e295d121be6..b33000976f66 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -263,8 +263,6 @@ static inline struct device *tdc2dev(struct tegra_dma_channel *tdc)
}
static dma_cookie_t tegra_dma_tx_submit(struct dma_async_tx_descriptor *tx);
-static int tegra_dma_runtime_suspend(struct device *dev);
-static int tegra_dma_runtime_resume(struct device *dev);
/* Get DMA desc from free list, if not there then allocate it. */
static struct tegra_dma_desc *tegra_dma_desc_get(struct tegra_dma_channel *tdc)
@@ -1575,7 +1573,7 @@ static int tegra_dma_remove(struct platform_device *pdev)
return 0;
}
-static int tegra_dma_runtime_suspend(struct device *dev)
+static int __maybe_unused tegra_dma_runtime_suspend(struct device *dev)
{
struct tegra_dma *tdma = dev_get_drvdata(dev);
@@ -1584,7 +1582,7 @@ static int tegra_dma_runtime_suspend(struct device *dev)
return 0;
}
-static int tegra_dma_runtime_resume(struct device *dev)
+static int __maybe_unused tegra_dma_runtime_resume(struct device *dev)
{
struct tegra_dma *tdma = dev_get_drvdata(dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
2020-03-20 7:13 ` YueHaibing
(?)
@ 2020-03-20 14:25 ` Dmitry Osipenko
-1 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-03-20 14:25 UTC (permalink / raw)
To: YueHaibing, ldewangan, jonathanh, dan.j.williams, vkoul,
thierry.reding, swarren
Cc: dmaengine, linux-tegra, linux-kernel
20.03.2020 10:13, YueHaibing пишет:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
>
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
...
Looks good, thank you:
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-20 15:11 ` Thierry Reding
0 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2020-03-20 15:11 UTC (permalink / raw)
To: YueHaibing
Cc: ldewangan, jonathanh, dan.j.williams, vkoul, swarren, dmaengine,
linux-tegra, linux-kernel, digetx
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Fri, Mar 20, 2020 at 03:13:37PM +0800, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
>
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-20 15:11 ` Thierry Reding
0 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2020-03-20 15:11 UTC (permalink / raw)
To: YueHaibing
Cc: ldewangan-DDmLM1+adcrQT0dZR+AlfA,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w,
vkoul-DgEjT+Ai2ygdnm+yROfE0A, swarren-3lzwWm7+Weoh9ZMKESR00Q,
dmaengine-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
digetx-Re5JQEeQqe8AvxtiuMwx3w
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Fri, Mar 20, 2020 at 03:13:37PM +0800, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
>
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/dma/tegra20-apb-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-23 6:30 ` Vinod Koul
0 siblings, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2020-03-23 6:30 UTC (permalink / raw)
To: YueHaibing
Cc: ldewangan, jonathanh, dan.j.williams, thierry.reding, swarren,
dmaengine, linux-tegra, linux-kernel, digetx
On 20-03-20, 15:13, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-23 6:30 ` Vinod Koul
0 siblings, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2020-03-23 6:30 UTC (permalink / raw)
To: YueHaibing
Cc: ldewangan-DDmLM1+adcrQT0dZR+AlfA,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
swarren-3lzwWm7+Weoh9ZMKESR00Q, dmaengine-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
digetx-Re5JQEeQqe8AvxtiuMwx3w
On 20-03-20, 15:13, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-23 6:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
2020-03-20 7:13 ` YueHaibing
2020-03-20 14:25 ` Dmitry Osipenko
2020-03-20 15:11 ` Thierry Reding
2020-03-20 15:11 ` Thierry Reding
2020-03-23 6:30 ` Vinod Koul
2020-03-23 6:30 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.