All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order
@ 2021-06-23 14:59 ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-06-23 14:59 UTC (permalink / raw)
  To: Magnus Damm, Niklas Söderlund
  Cc: linux-renesas-soc, linux-arm-kernel, Geert Uytterhoeven

The thermal node was inserted at the wrong place, breaking sort order
(sort by unit address, but group nodes of the same type).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Probably it was my fault, not Niklas' ;-)

To be queued in renesas-devel for v5.15.

 arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 26 +++++++++++------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index a7dfade1801a87db..3676b2bd3d646cdb 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -327,6 +327,19 @@ sysc: system-controller@e6180000 {
 			#power-domain-cells = <1>;
 		};
 
+		tsc: thermal@e6190000 {
+			compatible = "renesas,r8a779a0-thermal";
+			reg = <0 0xe6190000 0 0x200>,
+			      <0 0xe6198000 0 0x200>,
+			      <0 0xe61a0000 0 0x200>,
+			      <0 0xe61a8000 0 0x200>,
+			      <0 0xe61b0000 0 0x200>;
+			clocks = <&cpg CPG_MOD 919>;
+			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+			resets = <&cpg 919>;
+			#thermal-sensor-cells = <1>;
+		};
+
 		tmu0: timer@e61e0000 {
 			compatible = "renesas,tmu-r8a779a0", "renesas,tmu";
 			reg = <0 0xe61e0000 0 0x30>;
@@ -392,19 +405,6 @@ tmu4: timer@ffc00000 {
 			status = "disabled";
 		};
 
-		tsc: thermal@e6190000 {
-			compatible = "renesas,r8a779a0-thermal";
-			reg = <0 0xe6190000 0 0x200>,
-			      <0 0xe6198000 0 0x200>,
-			      <0 0xe61a0000 0 0x200>,
-			      <0 0xe61a8000 0 0x200>,
-			      <0 0xe61b0000 0 0x200>;
-			clocks = <&cpg CPG_MOD 919>;
-			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
-			resets = <&cpg 919>;
-			#thermal-sensor-cells = <1>;
-		};
-
 		i2c0: i2c@e6500000 {
 			compatible = "renesas,i2c-r8a779a0",
 				     "renesas,rcar-gen3-i2c";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order
@ 2021-06-23 14:59 ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-06-23 14:59 UTC (permalink / raw)
  To: Magnus Damm, Niklas Söderlund
  Cc: linux-renesas-soc, linux-arm-kernel, Geert Uytterhoeven

The thermal node was inserted at the wrong place, breaking sort order
(sort by unit address, but group nodes of the same type).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Probably it was my fault, not Niklas' ;-)

To be queued in renesas-devel for v5.15.

 arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 26 +++++++++++------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index a7dfade1801a87db..3676b2bd3d646cdb 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -327,6 +327,19 @@ sysc: system-controller@e6180000 {
 			#power-domain-cells = <1>;
 		};
 
+		tsc: thermal@e6190000 {
+			compatible = "renesas,r8a779a0-thermal";
+			reg = <0 0xe6190000 0 0x200>,
+			      <0 0xe6198000 0 0x200>,
+			      <0 0xe61a0000 0 0x200>,
+			      <0 0xe61a8000 0 0x200>,
+			      <0 0xe61b0000 0 0x200>;
+			clocks = <&cpg CPG_MOD 919>;
+			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+			resets = <&cpg 919>;
+			#thermal-sensor-cells = <1>;
+		};
+
 		tmu0: timer@e61e0000 {
 			compatible = "renesas,tmu-r8a779a0", "renesas,tmu";
 			reg = <0 0xe61e0000 0 0x30>;
@@ -392,19 +405,6 @@ tmu4: timer@ffc00000 {
 			status = "disabled";
 		};
 
-		tsc: thermal@e6190000 {
-			compatible = "renesas,r8a779a0-thermal";
-			reg = <0 0xe6190000 0 0x200>,
-			      <0 0xe6198000 0 0x200>,
-			      <0 0xe61a0000 0 0x200>,
-			      <0 0xe61a8000 0 0x200>,
-			      <0 0xe61b0000 0 0x200>;
-			clocks = <&cpg CPG_MOD 919>;
-			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
-			resets = <&cpg 919>;
-			#thermal-sensor-cells = <1>;
-		};
-
 		i2c0: i2c@e6500000 {
 			compatible = "renesas,i2c-r8a779a0",
 				     "renesas,rcar-gen3-i2c";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order
  2021-06-23 14:59 ` Geert Uytterhoeven
@ 2021-06-23 18:13   ` Niklas Söderlund
  -1 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2021-06-23 18:13 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc, linux-arm-kernel

Hello,

On 2021-06-23 16:59:25 +0200, Geert Uytterhoeven wrote:
> The thermal node was inserted at the wrong place, breaking sort order
> (sort by unit address, but group nodes of the same type).
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Probably it was my fault, not Niklas' ;-)

Most likely my fault, happy order is restored.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
> To be queued in renesas-devel for v5.15.
> 
>  arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 26 +++++++++++------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> index a7dfade1801a87db..3676b2bd3d646cdb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -327,6 +327,19 @@ sysc: system-controller@e6180000 {
>  			#power-domain-cells = <1>;
>  		};
>  
> +		tsc: thermal@e6190000 {
> +			compatible = "renesas,r8a779a0-thermal";
> +			reg = <0 0xe6190000 0 0x200>,
> +			      <0 0xe6198000 0 0x200>,
> +			      <0 0xe61a0000 0 0x200>,
> +			      <0 0xe61a8000 0 0x200>,
> +			      <0 0xe61b0000 0 0x200>;
> +			clocks = <&cpg CPG_MOD 919>;
> +			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> +			resets = <&cpg 919>;
> +			#thermal-sensor-cells = <1>;
> +		};
> +
>  		tmu0: timer@e61e0000 {
>  			compatible = "renesas,tmu-r8a779a0", "renesas,tmu";
>  			reg = <0 0xe61e0000 0 0x30>;
> @@ -392,19 +405,6 @@ tmu4: timer@ffc00000 {
>  			status = "disabled";
>  		};
>  
> -		tsc: thermal@e6190000 {
> -			compatible = "renesas,r8a779a0-thermal";
> -			reg = <0 0xe6190000 0 0x200>,
> -			      <0 0xe6198000 0 0x200>,
> -			      <0 0xe61a0000 0 0x200>,
> -			      <0 0xe61a8000 0 0x200>,
> -			      <0 0xe61b0000 0 0x200>;
> -			clocks = <&cpg CPG_MOD 919>;
> -			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> -			resets = <&cpg 919>;
> -			#thermal-sensor-cells = <1>;
> -		};
> -
>  		i2c0: i2c@e6500000 {
>  			compatible = "renesas,i2c-r8a779a0",
>  				     "renesas,rcar-gen3-i2c";
> -- 
> 2.25.1
> 

-- 
Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order
@ 2021-06-23 18:13   ` Niklas Söderlund
  0 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2021-06-23 18:13 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc, linux-arm-kernel

Hello,

On 2021-06-23 16:59:25 +0200, Geert Uytterhoeven wrote:
> The thermal node was inserted at the wrong place, breaking sort order
> (sort by unit address, but group nodes of the same type).
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Probably it was my fault, not Niklas' ;-)

Most likely my fault, happy order is restored.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
> To be queued in renesas-devel for v5.15.
> 
>  arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 26 +++++++++++------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> index a7dfade1801a87db..3676b2bd3d646cdb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -327,6 +327,19 @@ sysc: system-controller@e6180000 {
>  			#power-domain-cells = <1>;
>  		};
>  
> +		tsc: thermal@e6190000 {
> +			compatible = "renesas,r8a779a0-thermal";
> +			reg = <0 0xe6190000 0 0x200>,
> +			      <0 0xe6198000 0 0x200>,
> +			      <0 0xe61a0000 0 0x200>,
> +			      <0 0xe61a8000 0 0x200>,
> +			      <0 0xe61b0000 0 0x200>;
> +			clocks = <&cpg CPG_MOD 919>;
> +			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> +			resets = <&cpg 919>;
> +			#thermal-sensor-cells = <1>;
> +		};
> +
>  		tmu0: timer@e61e0000 {
>  			compatible = "renesas,tmu-r8a779a0", "renesas,tmu";
>  			reg = <0 0xe61e0000 0 0x30>;
> @@ -392,19 +405,6 @@ tmu4: timer@ffc00000 {
>  			status = "disabled";
>  		};
>  
> -		tsc: thermal@e6190000 {
> -			compatible = "renesas,r8a779a0-thermal";
> -			reg = <0 0xe6190000 0 0x200>,
> -			      <0 0xe6198000 0 0x200>,
> -			      <0 0xe61a0000 0 0x200>,
> -			      <0 0xe61a8000 0 0x200>,
> -			      <0 0xe61b0000 0 0x200>;
> -			clocks = <&cpg CPG_MOD 919>;
> -			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> -			resets = <&cpg 919>;
> -			#thermal-sensor-cells = <1>;
> -		};
> -
>  		i2c0: i2c@e6500000 {
>  			compatible = "renesas,i2c-r8a779a0",
>  				     "renesas,rcar-gen3-i2c";
> -- 
> 2.25.1
> 

-- 
Regards,
Niklas Söderlund

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-23 18:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 14:59 [PATCH] arm64: dts: renesas: r8a779a0: Restore sort order Geert Uytterhoeven
2021-06-23 14:59 ` Geert Uytterhoeven
2021-06-23 18:13 ` Niklas Söderlund
2021-06-23 18:13   ` Niklas Söderlund

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.