[PATCH v3 0/4] Fix malformed SPDX-License-Identifier

[PATCH v3 0/4] Fix malformed SPDX-License-Identifier

[Wentao Cai]

Fix SPDX-License-Identifier in drivers/staging/most/dim2/

Wentao Cai (4):
  Staging: most: dim2: Fix SPDX-License-Identifier in errors.h
  Staging: most: dim2: Fix SPDX-License-Identifier in hal.h
  Staging: most: dim2: Fix SPDX-License-Identifier in sysfs.h
  Staging: most: dim2: Fix SPDX-License-Identifier in reg.h

 drivers/staging/most/dim2/errors.h | 2 +-
 drivers/staging/most/dim2/hal.h    | 2 +-
 drivers/staging/most/dim2/reg.h    | 2 +-
 drivers/staging/most/dim2/sysfs.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.11.0

[PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[Wentao Cai]

Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/dim2/errors.h b/drivers/staging/most/dim2/errors.h
index 3487510fbd2f..cbbdaaf5c52d 100644
--- a/drivers/staging/most/dim2/errors.h
+++ b/drivers/staging/most/dim2/errors.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * errors.h - Definitions of errors for DIM2 HAL API
  * (MediaLB, Device Interface Macro IP, OS62420)
-- 
2.11.0

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[etsai042]

[-- Attachment #1.1: Type: text/plain, Size: 56 bytes --]

Sorry to mess up patch version, I'll revise it.

Wentao

[-- Attachment #1.2: Type: text/html, Size: 104 bytes --]

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[Greg KH]

On Thu, Mar 07, 2019 at 07:10:10PM -0800, Wentao Cai wrote:
> Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/most/dim2/errors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/dim2/errors.h b/drivers/staging/most/dim2/errors.h
> index 3487510fbd2f..cbbdaaf5c52d 100644
> --- a/drivers/staging/most/dim2/errors.h
> +++ b/drivers/staging/most/dim2/errors.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0+ */

You just changed the license of the file, not good at all :(

Don't do this unless you _really_ like talking to lawyers...

thanks,

greg k-h

Re: [PATCH v3 0/4] Fix malformed SPDX-License-Identifier

[Greg KH]

On Thu, Mar 07, 2019 at 07:10:09PM -0800, Wentao Cai wrote:
> Fix SPDX-License-Identifier in drivers/staging/most/dim2/
> 
> Wentao Cai (4):
>   Staging: most: dim2: Fix SPDX-License-Identifier in errors.h
>   Staging: most: dim2: Fix SPDX-License-Identifier in hal.h
>   Staging: most: dim2: Fix SPDX-License-Identifier in sysfs.h
>   Staging: most: dim2: Fix SPDX-License-Identifier in reg.h

Usually it is easier to put the filename at the beginning of the line,
not at the end, so this would look like:

Staging: most: dim2: errors.h:Fix SPDX-License-Identifier
Staging: most: dim2: hal.h: Fix SPDX-License-Identifier
Staging: most: dim2: sysfs.h: Fix SPDX-License-Identifier
Staging: most: dim2: reg.h: Fix SPDX-License-Identifier

But, note, your text here is not correct, I'll say more about that in
your first patch...

> 
>  drivers/staging/most/dim2/errors.h | 2 +-
>  drivers/staging/most/dim2/hal.h    | 2 +-
>  drivers/staging/most/dim2/reg.h    | 2 +-
>  drivers/staging/most/dim2/sysfs.h  | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Please use git send-email to properly "thread" your patches the next
time you resend this series.

thanks,

greg k-h

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[Greg KH]

On Thu, Mar 07, 2019 at 07:10:10PM -0800, Wentao Cai wrote:
> Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

You are not "fixing" the identifier so much as using the "correct"
comment characters.  The identifier text itself is correct and nothing
needs to be "fixed" in it.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[Julia Lawall]

On Thu, 7 Mar 2019, etsai042@gmail.com wrote:

> Sorry to mess up patch version, I'll revise it.

It's nice to quote what you are responding to, so the reader has some
context beyond the subject line.  Just to remember for next time.

julia

> Wentao
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/8d797e93-e9be-4122-b9a7-
> 5baa4d41ccf2%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[etsai042]

[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]



On Thursday, March 7, 2019 at 11:04:04 PM UTC-8, gregkh wrote:
>
>
> > You just changed the license of the file, not good at all :( 
>
> > Don't do this unless you _really_ like talking to lawyers... 
>
> > thanks, 
>
> > greg k-h 
>

Sorry, I'll revise it in next version.

Wentao 

[-- Attachment #1.2: Type: text/html, Size: 527 bytes --]

Re: [Outreachy kernel] Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

[etsai042]

[-- Attachment #1.1: Type: text/plain, Size: 280 bytes --]


On Thursday, March 7, 2019 at 11:29:02 PM UTC-8, Julia Lawall wrote:

> It's nice to quote what you are responding to, so the reader has some 
> context beyond the subject line.  Just to remember for next time. 
> 
> julia 

Thanks Julia! I'll be more careful next time!

Wentao

[-- Attachment #1.2: Type: text/html, Size: 673 bytes --]