All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-23  4:36 ` Green Wan
  0 siblings, 0 replies; 10+ messages in thread
From: Green Wan @ 2021-03-23  4:36 UTC (permalink / raw)
  To: u-boot

Hi Neil,

pcie_dw_common.* is a good starting point. I'd like to spend time on this.
Please add me into the loop. Thanks.

-
Green

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-23  4:36 ` Green Wan
  0 siblings, 0 replies; 10+ messages in thread
From: Green Wan @ 2021-03-23  4:36 UTC (permalink / raw)
  To: U-Boot Mailing List, Neil Armstrong, cc: Lokesh Vutla,
	Sekhar Nori, shawn.lin, u-boot-amlogic

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

Hi Neil,

pcie_dw_common.* is a good starting point. I'd like to spend time on this.
Please add me into the loop. Thanks.

-
Green

[-- Attachment #2: Type: text/html, Size: 173 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
  2021-03-23  4:36 ` Green Wan
@ 2021-03-23  8:14   ` Neil Armstrong
  -1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-23  8:14 UTC (permalink / raw)
  To: u-boot

Hi Green,


On 23/03/2021 05:36, Green Wan wrote:
> Hi Neil,
> 
> pcie_dw_common.* is a good starting point. I'd like to spend time on this. Please add me into the loop. Thanks.

Sure, I'll CC you on the next revision, in the meantime don't hesitate to comment and/or post the changes
needed for sifive.

Neil

> 
> -
> Green

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-23  8:14   ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-23  8:14 UTC (permalink / raw)
  To: Green Wan, U-Boot Mailing List, cc: Lokesh Vutla, Sekhar Nori,
	shawn.lin, u-boot-amlogic

Hi Green,


On 23/03/2021 05:36, Green Wan wrote:
> Hi Neil,
> 
> pcie_dw_common.* is a good starting point. I'd like to spend time on this. Please add me into the loop. Thanks.

Sure, I'll CC you on the next revision, in the meantime don't hesitate to comment and/or post the changes
needed for sifive.

Neil

> 
> -
> Green


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
  2021-03-22  9:27   ` Shawn Lin
@ 2021-03-22  9:30     ` Neil Armstrong
  -1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-22  9:30 UTC (permalink / raw)
  To: u-boot

On 22/03/2021 10:27, Shawn Lin wrote:
> Hi Neil,
> 
> On 2021/3/22 17:18, Neil Armstrong wrote:
>> With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the
>> Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.
>>
>> This introduce a "common" DW PCIe helpers file with common code merged from the
>> dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.
> 
> That's a good idea.
> 
> BTW, pcie_dw_mvebu.c and? pcie_imx.c also should need a migration.

Exact, same for the recently submitted pci_sifive, they should probably wait for a second round

Neil

> 
>>
>> The following changes will switch the dw_ti and dw_rockchip, and introduce a new
>> driver to support the Amlogic AXG & G12 SoCs using these new common helpers.
>>
>> The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing
>> on hardware to validate nothing has been broken.
>>
>> Neil Armstrong (4):
>> ?? pci: add common Designware PCIe functions
>> ?? pci: pcie_dw_ti: migrate to common Designware PCIe functions
>> ?? pci: pcie_dw_rockchip: migrate to common Designware PCIe functions
>> ?? pci: add Amlogic Meson Designware PCIe controller
>>
>> ? drivers/pci/Kconfig??????????? |? 15 +-
>> ? drivers/pci/Makefile?????????? |?? 2 +
>> ? drivers/pci/pcie_dw_common.c?? | 352 ++++++++++++++++++++++++
>> ? drivers/pci/pcie_dw_common.h?? | 153 +++++++++++
>> ? drivers/pci/pcie_dw_meson.c??? | 459 ++++++++++++++++++++++++++++++++
>> ? drivers/pci/pcie_dw_rockchip.c | 472 ++-------------------------------
>> ? drivers/pci/pcie_dw_ti.c?????? | 444 +++----------------------------
>> ? 7 files changed, 1046 insertions(+), 851 deletions(-)
>> ? create mode 100644 drivers/pci/pcie_dw_common.c
>> ? create mode 100644 drivers/pci/pcie_dw_common.h
>> ? create mode 100644 drivers/pci/pcie_dw_meson.c
>>
> 
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-22  9:30     ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-22  9:30 UTC (permalink / raw)
  To: Shawn Lin, lokeshvutla, nsekhar; +Cc: u-boot, u-boot-amlogic

On 22/03/2021 10:27, Shawn Lin wrote:
> Hi Neil,
> 
> On 2021/3/22 17:18, Neil Armstrong wrote:
>> With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the
>> Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.
>>
>> This introduce a "common" DW PCIe helpers file with common code merged from the
>> dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.
> 
> That's a good idea.
> 
> BTW, pcie_dw_mvebu.c and  pcie_imx.c also should need a migration.

Exact, same for the recently submitted pci_sifive, they should probably wait for a second round

Neil

> 
>>
>> The following changes will switch the dw_ti and dw_rockchip, and introduce a new
>> driver to support the Amlogic AXG & G12 SoCs using these new common helpers.
>>
>> The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing
>> on hardware to validate nothing has been broken.
>>
>> Neil Armstrong (4):
>>    pci: add common Designware PCIe functions
>>    pci: pcie_dw_ti: migrate to common Designware PCIe functions
>>    pci: pcie_dw_rockchip: migrate to common Designware PCIe functions
>>    pci: add Amlogic Meson Designware PCIe controller
>>
>>   drivers/pci/Kconfig            |  15 +-
>>   drivers/pci/Makefile           |   2 +
>>   drivers/pci/pcie_dw_common.c   | 352 ++++++++++++++++++++++++
>>   drivers/pci/pcie_dw_common.h   | 153 +++++++++++
>>   drivers/pci/pcie_dw_meson.c    | 459 ++++++++++++++++++++++++++++++++
>>   drivers/pci/pcie_dw_rockchip.c | 472 ++-------------------------------
>>   drivers/pci/pcie_dw_ti.c       | 444 +++----------------------------
>>   7 files changed, 1046 insertions(+), 851 deletions(-)
>>   create mode 100644 drivers/pci/pcie_dw_common.c
>>   create mode 100644 drivers/pci/pcie_dw_common.h
>>   create mode 100644 drivers/pci/pcie_dw_meson.c
>>
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
  2021-03-22  9:18 ` Neil Armstrong
@ 2021-03-22  9:27   ` Shawn Lin
  -1 siblings, 0 replies; 10+ messages in thread
From: Shawn Lin @ 2021-03-22  9:27 UTC (permalink / raw)
  To: u-boot

Hi Neil,

On 2021/3/22 17:18, Neil Armstrong wrote:
> With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the
> Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.
> 
> This introduce a "common" DW PCIe helpers file with common code merged from the
> dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.

That's a good idea.

BTW, pcie_dw_mvebu.c and  pcie_imx.c also should need a migration.

> 
> The following changes will switch the dw_ti and dw_rockchip, and introduce a new
> driver to support the Amlogic AXG & G12 SoCs using these new common helpers.
> 
> The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing
> on hardware to validate nothing has been broken.
> 
> Neil Armstrong (4):
>    pci: add common Designware PCIe functions
>    pci: pcie_dw_ti: migrate to common Designware PCIe functions
>    pci: pcie_dw_rockchip: migrate to common Designware PCIe functions
>    pci: add Amlogic Meson Designware PCIe controller
> 
>   drivers/pci/Kconfig            |  15 +-
>   drivers/pci/Makefile           |   2 +
>   drivers/pci/pcie_dw_common.c   | 352 ++++++++++++++++++++++++
>   drivers/pci/pcie_dw_common.h   | 153 +++++++++++
>   drivers/pci/pcie_dw_meson.c    | 459 ++++++++++++++++++++++++++++++++
>   drivers/pci/pcie_dw_rockchip.c | 472 ++-------------------------------
>   drivers/pci/pcie_dw_ti.c       | 444 +++----------------------------
>   7 files changed, 1046 insertions(+), 851 deletions(-)
>   create mode 100644 drivers/pci/pcie_dw_common.c
>   create mode 100644 drivers/pci/pcie_dw_common.h
>   create mode 100644 drivers/pci/pcie_dw_meson.c
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-22  9:27   ` Shawn Lin
  0 siblings, 0 replies; 10+ messages in thread
From: Shawn Lin @ 2021-03-22  9:27 UTC (permalink / raw)
  To: Neil Armstrong, lokeshvutla, nsekhar; +Cc: shawn.lin, u-boot, u-boot-amlogic

Hi Neil,

On 2021/3/22 17:18, Neil Armstrong wrote:
> With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the
> Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.
> 
> This introduce a "common" DW PCIe helpers file with common code merged from the
> dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.

That's a good idea.

BTW, pcie_dw_mvebu.c and  pcie_imx.c also should need a migration.

> 
> The following changes will switch the dw_ti and dw_rockchip, and introduce a new
> driver to support the Amlogic AXG & G12 SoCs using these new common helpers.
> 
> The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing
> on hardware to validate nothing has been broken.
> 
> Neil Armstrong (4):
>    pci: add common Designware PCIe functions
>    pci: pcie_dw_ti: migrate to common Designware PCIe functions
>    pci: pcie_dw_rockchip: migrate to common Designware PCIe functions
>    pci: add Amlogic Meson Designware PCIe controller
> 
>   drivers/pci/Kconfig            |  15 +-
>   drivers/pci/Makefile           |   2 +
>   drivers/pci/pcie_dw_common.c   | 352 ++++++++++++++++++++++++
>   drivers/pci/pcie_dw_common.h   | 153 +++++++++++
>   drivers/pci/pcie_dw_meson.c    | 459 ++++++++++++++++++++++++++++++++
>   drivers/pci/pcie_dw_rockchip.c | 472 ++-------------------------------
>   drivers/pci/pcie_dw_ti.c       | 444 +++----------------------------
>   7 files changed, 1046 insertions(+), 851 deletions(-)
>   create mode 100644 drivers/pci/pcie_dw_common.c
>   create mode 100644 drivers/pci/pcie_dw_common.h
>   create mode 100644 drivers/pci/pcie_dw_meson.c
> 



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-22  9:18 ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-22  9:18 UTC (permalink / raw)
  To: u-boot

With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the
Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.

This introduce a "common" DW PCIe helpers file with common code merged from the
dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.

The following changes will switch the dw_ti and dw_rockchip, and introduce a new
driver to support the Amlogic AXG & G12 SoCs using these new common helpers.

The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing
on hardware to validate nothing has been broken.

Neil Armstrong (4):
  pci: add common Designware PCIe functions
  pci: pcie_dw_ti: migrate to common Designware PCIe functions
  pci: pcie_dw_rockchip: migrate to common Designware PCIe functions
  pci: add Amlogic Meson Designware PCIe controller

 drivers/pci/Kconfig            |  15 +-
 drivers/pci/Makefile           |   2 +
 drivers/pci/pcie_dw_common.c   | 352 ++++++++++++++++++++++++
 drivers/pci/pcie_dw_common.h   | 153 +++++++++++
 drivers/pci/pcie_dw_meson.c    | 459 ++++++++++++++++++++++++++++++++
 drivers/pci/pcie_dw_rockchip.c | 472 ++-------------------------------
 drivers/pci/pcie_dw_ti.c       | 444 +++----------------------------
 7 files changed, 1046 insertions(+), 851 deletions(-)
 create mode 100644 drivers/pci/pcie_dw_common.c
 create mode 100644 drivers/pci/pcie_dw_common.h
 create mode 100644 drivers/pci/pcie_dw_meson.c

-- 
2.25.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller
@ 2021-03-22  9:18 ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-22  9:18 UTC (permalink / raw)
  To: lokeshvutla, nsekhar, shawn.lin; +Cc: u-boot, u-boot-amlogic, Neil Armstrong

With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the
Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.

This introduce a "common" DW PCIe helpers file with common code merged from the
dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.

The following changes will switch the dw_ti and dw_rockchip, and introduce a new
driver to support the Amlogic AXG & G12 SoCs using these new common helpers.

The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing
on hardware to validate nothing has been broken.

Neil Armstrong (4):
  pci: add common Designware PCIe functions
  pci: pcie_dw_ti: migrate to common Designware PCIe functions
  pci: pcie_dw_rockchip: migrate to common Designware PCIe functions
  pci: add Amlogic Meson Designware PCIe controller

 drivers/pci/Kconfig            |  15 +-
 drivers/pci/Makefile           |   2 +
 drivers/pci/pcie_dw_common.c   | 352 ++++++++++++++++++++++++
 drivers/pci/pcie_dw_common.h   | 153 +++++++++++
 drivers/pci/pcie_dw_meson.c    | 459 ++++++++++++++++++++++++++++++++
 drivers/pci/pcie_dw_rockchip.c | 472 ++-------------------------------
 drivers/pci/pcie_dw_ti.c       | 444 +++----------------------------
 7 files changed, 1046 insertions(+), 851 deletions(-)
 create mode 100644 drivers/pci/pcie_dw_common.c
 create mode 100644 drivers/pci/pcie_dw_common.h
 create mode 100644 drivers/pci/pcie_dw_meson.c

-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-03-23  8:14 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23  4:36 [PATCH RFT 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller Green Wan
2021-03-23  4:36 ` Green Wan
2021-03-23  8:14 ` Neil Armstrong
2021-03-23  8:14   ` Neil Armstrong
  -- strict thread matches above, loose matches on Subject: below --
2021-03-22  9:18 Neil Armstrong
2021-03-22  9:18 ` Neil Armstrong
2021-03-22  9:27 ` Shawn Lin
2021-03-22  9:27   ` Shawn Lin
2021-03-22  9:30   ` Neil Armstrong
2021-03-22  9:30     ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.