From: Usama Arif <usama.arif@bytedance.com>
To: David Woodhouse <dwmw2@infradead.org>,
"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"kim.phillips@amd.com" <kim.phillips@amd.com>,
"brgerst@gmail.com" <brgerst@gmail.com>
Cc: "piotrgorski@cachyos.org" <piotrgorski@cachyos.org>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"paulmck@kernel.org" <paulmck@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>,
"mimoja@mimoja.de" <mimoja@mimoja.de>,
"hewenliang4@huawei.com" <hewenliang4@huawei.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"seanjc@google.com" <seanjc@google.com>,
"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
"fam.zheng@bytedance.com" <fam.zheng@bytedance.com>,
"punit.agrawal@bytedance.com" <punit.agrawal@bytedance.com>,
"simon.evans@bytedance.com" <simon.evans@bytedance.com>,
"liangma@liangbit.com" <liangma@liangbit.com>
Subject: Re: [External] Re: [PATCH v11 09/12] x86/smpboot: Remove initial_stack on 64-bit
Date: Fri, 24 Feb 2023 19:17:27 +0000 [thread overview]
Message-ID: <8dcac250-474a-6102-1a60-b8ad84eb0a4b@bytedance.com> (raw)
In-Reply-To: <2c3abf634824f2b7207a3ac94985863472d67608.camel@infradead.org>
On 24/02/2023 18:28, David Woodhouse wrote:
> On Fri, 2023-02-24 at 18:24 +0000, Michael Kelley (LINUX) wrote:
>> I'm getting a compile error on the new reference to PTREGS_SIZE:
>
> Is it just that <asm/asm-offsets.h> is included conditionally, and not
> in your build? What if you include it directly from <asm/processor.h>
This is fixed in the v2 patch that Brian sent.
diff --git a/arch/x86/include/asm/processor.h
b/arch/x86/include/asm/processor.h
index 9c4a5c4d46c1..bdde7316e75b 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -650,8 +650,8 @@ static inline void spin_lock_prefetch(const void *x)
#else
extern unsigned long __end_init_task[];
-#define INIT_THREAD { \
- .sp = (unsigned long)&__end_init_task - PTREGS_SIZE, \
+#define INIT_THREAD {
\
+ .sp = (unsigned long)&__end_init_task - sizeof(struct
pt_regs), \
}
extern unsigned long KSTK_ESP(struct task_struct *task);
next prev parent reply other threads:[~2023-02-24 19:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 19:11 [PATCH v11 00/12] Parallel CPU bringup for x86_64 Usama Arif
2023-02-23 19:11 ` [PATCH v11 01/12] x86/apic/x2apic: Allow CPU cluster_mask to be populated in parallel Usama Arif
2023-02-23 19:11 ` [PATCH v11 02/12] cpu/hotplug: Move idle_thread_get() to <linux/smpboot.h> Usama Arif
2023-02-23 19:11 ` [PATCH v11 03/12] cpu/hotplug: Add dynamic parallel bringup states before CPUHP_BRINGUP_CPU Usama Arif
2023-02-23 19:11 ` [PATCH v11 04/12] x86/smpboot: Reference count on smpboot_setup_warm_reset_vector() Usama Arif
2023-02-23 19:11 ` [PATCH v11 05/12] x86/smpboot: Split up native_cpu_up into separate phases and document them Usama Arif
2023-02-23 19:11 ` [PATCH v11 06/12] x86/smpboot: Support parallel startup of secondary CPUs Usama Arif
2023-02-23 19:11 ` [PATCH v11 07/12] x86/smpboot: Send INIT/SIPI/SIPI to secondary CPUs in parallel Usama Arif
2023-02-24 18:46 ` Michael Kelley (LINUX)
2023-02-23 19:11 ` [PATCH v11 08/12] x86/smpboot: Serialize topology updates for secondary bringup Usama Arif
2023-02-23 19:11 ` [PATCH v11 09/12] x86/smpboot: Remove initial_stack on 64-bit Usama Arif
2023-02-24 18:24 ` Michael Kelley (LINUX)
2023-02-24 18:28 ` David Woodhouse
2023-02-24 19:17 ` Usama Arif [this message]
2023-02-23 19:11 ` [PATCH v11 10/12] x86/smpboot: Remove early_gdt_descr " Usama Arif
2023-02-23 19:11 ` [PATCH v11 11/12] x86/smpboot: Remove initial_gs Usama Arif
2023-02-23 19:11 ` [PATCH v11 12/12] x86/smpboot: Simplify boot CPU setup Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dcac250-474a-6102-1a60-b8ad84eb0a4b@bytedance.com \
--to=usama.arif@bytedance.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=fam.zheng@bytedance.com \
--cc=hewenliang4@huawei.com \
--cc=hpa@zytor.com \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=liangma@liangbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mimoja@mimoja.de \
--cc=mingo@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=piotrgorski@cachyos.org \
--cc=pmenzel@molgen.mpg.de \
--cc=punit.agrawal@bytedance.com \
--cc=rcu@vger.kernel.org \
--cc=seanjc@google.com \
--cc=simon.evans@bytedance.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.