All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Kukjin Kim <kgene@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros
Date: Thu, 1 Sep 2016 12:29:50 +0200	[thread overview]
Message-ID: <8dda7bb7-fb99-3e13-be03-e21e3b18e501@osg.samsung.com> (raw)
In-Reply-To: <1472721715-2833-2-git-send-email-k.kozlowski@samsung.com>

Hello Krzysztof,

On 09/01/2016 11:21 AM, Krzysztof Kozlowski wrote:
> Update examples in Samsung pinctrl dt-bindings with new macros coming
> from header file.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  .../bindings/pinctrl/samsung-pinctrl.txt           | 42 +++++++++++-----------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> index 6db16b90873a..828ef7fdd437 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> @@ -238,53 +238,53 @@ Example 1: A pin-controller node with pin groups.
>  
>  		uart0_data: uart0-data {
>  			samsung,pins = "gpa0-0", "gpa0-1";
> -			samsung,pin-function = <2>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> +			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>  		};

I wonder if besides updating the examples, the DT binding shouldn't also
mention include/dt-bindings/pinctrl/samsung.h and list the macros for each
possible pin configuration.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros
Date: Thu, 1 Sep 2016 12:29:50 +0200	[thread overview]
Message-ID: <8dda7bb7-fb99-3e13-be03-e21e3b18e501@osg.samsung.com> (raw)
In-Reply-To: <1472721715-2833-2-git-send-email-k.kozlowski@samsung.com>

Hello Krzysztof,

On 09/01/2016 11:21 AM, Krzysztof Kozlowski wrote:
> Update examples in Samsung pinctrl dt-bindings with new macros coming
> from header file.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  .../bindings/pinctrl/samsung-pinctrl.txt           | 42 +++++++++++-----------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> index 6db16b90873a..828ef7fdd437 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> @@ -238,53 +238,53 @@ Example 1: A pin-controller node with pin groups.
>  
>  		uart0_data: uart0-data {
>  			samsung,pins = "gpa0-0", "gpa0-1";
> -			samsung,pin-function = <2>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> +			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>  		};

I wonder if besides updating the examples, the DT binding shouldn't also
mention include/dt-bindings/pinctrl/samsung.h and list the macros for each
possible pin configuration.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2016-09-01 10:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  9:21 [PATCH 0/6] pinctrl: s3c/samsung: Add header with values used for configuration Krzysztof Kozlowski
2016-09-01  9:21 ` Krzysztof Kozlowski
2016-09-01  9:21 ` Krzysztof Kozlowski
2016-09-01  9:21 ` [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01 10:29   ` Javier Martinez Canillas [this message]
2016-09-01 10:29     ` Javier Martinez Canillas
2016-09-01 10:31     ` Krzysztof Kozlowski
2016-09-01 10:31       ` Krzysztof Kozlowski
2016-09-01  9:21 ` [PATCH 2/6] pinctrl: dt-bindings: samsung: Add macros for S3C64xx pin configuration Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01  9:21 ` [PATCH 3/6] ARM: dts: s3c64xx: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01  9:21 ` [PATCH 4/6] ARM: dts: s5pv210: Use " Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01  9:21 ` [PATCH 5/6] ARM: dts: s3c2416: " Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01 10:59   ` Bartlomiej Zolnierkiewicz
2016-09-01 10:59     ` Bartlomiej Zolnierkiewicz
2016-09-01 11:12     ` Krzysztof Kozlowski
2016-09-01 11:12       ` Krzysztof Kozlowski
2016-09-01 11:12       ` Krzysztof Kozlowski
2016-09-01 11:17       ` Arnd Bergmann
2016-09-01 11:17         ` Arnd Bergmann
2016-09-01 11:17         ` Arnd Bergmann
2016-09-01  9:21 ` [PATCH 6/6] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2016-09-01  9:21   ` Krzysztof Kozlowski
2016-09-01 10:53 ` [PATCH 0/6] pinctrl: s3c/samsung: Add header with values used for configuration Javier Martinez Canillas
2016-09-01 10:53   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dda7bb7-fb99-3e13-be03-e21e3b18e501@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.