All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Alexander Stein <alexander.stein@mailbox.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Assign a fixed index to mmc devices
Date: Fri, 29 Jan 2021 09:07:45 +0100	[thread overview]
Message-ID: <8de4d82e-b9a5-f809-ea67-5527f9fdde5f@baylibre.com> (raw)
In-Reply-To: <20210127230852.66686-1-alexander.stein@mailbox.org>

Hi,

On 28/01/2021 00:08, Alexander Stein wrote:
> Recently introduced async probe on mmc devices can shuffle block IDs.
> Pin them to fixed values to ease booting in environments where UUIDs
> are not practical. Use newly introduced aliases for mmcblk devices from [1].
> [1]
> https://patchwork.kernel.org/patch/11747669/

I understand the goal, and this should be done for _all_ boards, not only the Odroid-N2.

Neil

> 
> Commit message taken from commit 0011c6d18277 ("arm64: dts: rockchip: Assign a fixed index to mmc devices on rk3399 boards.")
> 
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> I was wondering which order I should use. Depending in your booting
> medium (SD card or eMMC) you 'want' one or the other as mmc0.
> In the end I ordered them according to the names.
> 
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 050862cd0996..2faa4da917c1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -13,6 +13,8 @@ / {
>  	aliases {
>  		serial0 = &uart_AO;
>  		ethernet0 = &ethmac;
> +		mmc0 = &sd_emmc_b;
> +		mmc1 = &sd_emmc_c;
>  	};
>  
>  	dioo2133: audio-amplifier-0 {
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Alexander Stein <alexander.stein@mailbox.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Assign a fixed index to mmc devices
Date: Fri, 29 Jan 2021 09:07:45 +0100	[thread overview]
Message-ID: <8de4d82e-b9a5-f809-ea67-5527f9fdde5f@baylibre.com> (raw)
In-Reply-To: <20210127230852.66686-1-alexander.stein@mailbox.org>

Hi,

On 28/01/2021 00:08, Alexander Stein wrote:
> Recently introduced async probe on mmc devices can shuffle block IDs.
> Pin them to fixed values to ease booting in environments where UUIDs
> are not practical. Use newly introduced aliases for mmcblk devices from [1].
> [1]
> https://patchwork.kernel.org/patch/11747669/

I understand the goal, and this should be done for _all_ boards, not only the Odroid-N2.

Neil

> 
> Commit message taken from commit 0011c6d18277 ("arm64: dts: rockchip: Assign a fixed index to mmc devices on rk3399 boards.")
> 
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> I was wondering which order I should use. Depending in your booting
> medium (SD card or eMMC) you 'want' one or the other as mmc0.
> In the end I ordered them according to the names.
> 
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 050862cd0996..2faa4da917c1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -13,6 +13,8 @@ / {
>  	aliases {
>  		serial0 = &uart_AO;
>  		ethernet0 = &ethmac;
> +		mmc0 = &sd_emmc_b;
> +		mmc1 = &sd_emmc_c;
>  	};
>  
>  	dioo2133: audio-amplifier-0 {
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2021-01-29  8:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 23:08 [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Assign a fixed index to mmc devices Alexander Stein
2021-01-27 23:08 ` Alexander Stein
2021-01-27 23:08 ` Alexander Stein
2021-01-29  8:07 ` Neil Armstrong [this message]
2021-01-29  8:07   ` Neil Armstrong
2021-01-29 20:51   ` Alexander Stein
2021-01-29 20:51     ` Alexander Stein
2021-01-29 20:51     ` Alexander Stein
2021-02-02  0:50     ` Kevin Hilman
2021-02-02  0:50       ` Kevin Hilman
2021-02-02  0:50       ` Kevin Hilman
2021-02-02 17:03 ` [PATCH v2 1/1] arm64: dts: amlogic: " Alexander Stein
2021-02-02 17:03   ` Alexander Stein
2021-02-02 17:03   ` Alexander Stein
2021-02-03 19:20   ` Kevin Hilman
2021-02-03 19:20     ` Kevin Hilman
2021-02-03 19:20     ` Kevin Hilman
2021-02-03 19:28 ` [PATCH v3 " Alexander Stein
2021-02-03 19:28   ` Alexander Stein
2021-02-03 19:28   ` Alexander Stein
2021-02-18 18:09   ` Alexander Stein
2021-02-18 18:09     ` Alexander Stein
2021-02-18 18:09     ` Alexander Stein
2021-03-08 17:43     ` Kevin Hilman
2021-03-08 17:43       ` Kevin Hilman
2021-03-08 17:43       ` Kevin Hilman
2021-10-02  6:56       ` Alexander Stein
2021-10-02  6:56         ` Alexander Stein
2021-10-02  6:56         ` Alexander Stein
2021-10-02  8:49         ` Neil Armstrong
2021-10-02  8:49           ` Neil Armstrong
2021-10-02  8:49           ` Neil Armstrong
2021-10-02  8:54           ` Alexander Stein
2021-10-02  8:54             ` Alexander Stein
2021-10-02  8:54             ` Alexander Stein
2021-03-08 17:39   ` Kevin Hilman
2021-03-08 17:39     ` Kevin Hilman
2021-03-08 17:39     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8de4d82e-b9a5-f809-ea67-5527f9fdde5f@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=alexander.stein@mailbox.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.