[PATCH][V2] sdkext: use simpler kernel module for devtool test

[PATCH][V2] sdkext: use simpler kernel module for devtool test

[Mark Asselstine]

The current devtool test for the building of an out-of-tree kernel
module uses something which requires several "high order" kconfigs to
be set. This results in the test failing, not for expected reasons,
but rather because it depends on specific kernel configuration.

You will get error messages such as

  ERROR: "video_ioctl2"
  [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.ko]
  undefined!
  ERROR: "video_unregister_device"
  [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.ko]
  undefined!

Using a simpler hello-world kernel module example will only require
that CONFIG_MODULE is enabled, thus avoiding a false positive.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---

**V2**
 - also updated the CROPS manual test json file
   (I have no idea how to run this so untested but this is a straight
    substition)
 - continue to use github until we can move the sample to somewhere
   like git.yoctoproject.org

 meta/lib/oeqa/manual/crops.json       | 12 ++++++------
 meta/lib/oeqa/sdkext/cases/devtool.py |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/meta/lib/oeqa/manual/crops.json b/meta/lib/oeqa/manual/crops.json
index 1cf3c8f30c..071d35b661 100644
--- a/meta/lib/oeqa/manual/crops.json
+++ b/meta/lib/oeqa/manual/crops.json
@@ -234,16 +234,16 @@
                     "expected_results": "this should output the directory of the devtool script and it should be within the sdk workdir you are working in.   \n\n"
                 },
                 "5": {
-                    "action": "devtool add v4l2loopback-driver  https://github.com/umlaeute/v4l2loopback.git   \n\n",
-                    "expected_results": "This should automatically create the recipe v4l2loopback-driver.bb under <crops-esdk-workdir-workspace>/recipes/v4l2loopback-driver/v4l2loopback-driver.bb "
+                    "action": "devtool add kernel-module-hello-world  https://github.com/masselstine/kernel-module-hello-world.git   \n\n",
+                    "expected_results": "This should automatically create the recipe kernel-module-hello-world.bb under <crops-esdk-workdir-workspace>/recipes/kernel-module-hello-world/kernel-module-hello-world.bb "
                 },
                 "6": {
-                    "action": "devtool build v4l2loopback-driver   \n\n",
+                    "action": "devtool build kernel-module-hello-world   \n\n",
                     "expected_results": "This should compile an image   \n\n"
                 },
                 "7": {
-                    "action": "devtool reset v4l2loopback-driver   ",
-                    "expected_results": "This cleans sysroot of the v4l2loopback-driver recipe, but it leaves the source tree intact. meaning it does not erase."
+                    "action": "devtool reset kernel-module-hello-world   ",
+                    "expected_results": "This cleans sysroot of the kernel-module-hello-world recipe, but it leaves the source tree intact. meaning it does not erase."
                 }
             },
             "summary": "sdkext_devtool_kernelmodule"
@@ -291,4 +291,4 @@
             "summary": "sdkext_recipes_for_nodejs"
         }
     }
-]
\ No newline at end of file
+]
diff --git a/meta/lib/oeqa/sdkext/cases/devtool.py b/meta/lib/oeqa/sdkext/cases/devtool.py
index 5a02add764..fad98fbb36 100644
--- a/meta/lib/oeqa/sdkext/cases/devtool.py
+++ b/meta/lib/oeqa/sdkext/cases/devtool.py
@@ -73,8 +73,8 @@ class DevtoolTest(OESDKExtTestCase):
             self._run('devtool reset %s' % recipe)
 
     def test_devtool_kernelmodule(self):
-        docfile = 'https://github.com/umlaeute/v4l2loopback.git'
-        recipe = 'v4l2loopback-driver'
+        docfile = 'https://github.com/masselstine/kernel-module-hello-world.git'
+        recipe = 'kernel-module-hello-world'
         self._run('devtool add %s %s' % (recipe, docfile) )
         try:
             self._run('devtool build %s' % recipe)
-- 
2.21.0

Re: [PATCH][V2] sdkext: use simpler kernel module for devtool test

[Mark Asselstine]

On Thursday, August 22, 2019 11:56:16 A.M. EDT Mark Asselstine wrote:
> The current devtool test for the building of an out-of-tree kernel
> module uses something which requires several "high order" kconfigs to
> be set. This results in the test failing, not for expected reasons,
> but rather because it depends on specific kernel configuration.
> 
> You will get error messages such as
> 
>   ERROR: "video_ioctl2"
>  
> [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.k
> o] undefined!
>   ERROR: "video_unregister_device"
>  
> [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.k
> o] undefined!
> 
> Using a simpler hello-world kernel module example will only require
> that CONFIG_MODULE is enabled, thus avoiding a false positive.
> 
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> ---
> 
> **V2**
>  - also updated the CROPS manual test json file
>    (I have no idea how to run this so untested but this is a straight
>     substition)
>  - continue to use github until we can move the sample to somewhere
>    like git.yoctoproject.org

Richard, are you thinking we need to figure out the git.yoctoproject.org repo 
before we can move ahead with merging this?

MarkA

> 
>  meta/lib/oeqa/manual/crops.json       | 12 ++++++------
>  meta/lib/oeqa/sdkext/cases/devtool.py |  4 ++--
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/meta/lib/oeqa/manual/crops.json
> b/meta/lib/oeqa/manual/crops.json index 1cf3c8f30c..071d35b661 100644
> --- a/meta/lib/oeqa/manual/crops.json
> +++ b/meta/lib/oeqa/manual/crops.json
> @@ -234,16 +234,16 @@
>                      "expected_results": "this should output the directory
> of the devtool script and it should be within the sdk workdir you are
> working in.   \n\n" },
>                  "5": {
> -                    "action": "devtool add v4l2loopback-driver 
> https://github.com/umlaeute/v4l2loopback.git   \n\n", -                   
> "expected_results": "This should automatically create the recipe
> v4l2loopback-driver.bb under
> <crops-esdk-workdir-workspace>/recipes/v4l2loopback-driver/v4l2loopback-dri
> ver.bb " +                    "action": "devtool add
> kernel-module-hello-world 
> https://github.com/masselstine/kernel-module-hello-world.git   \n\n", +    
>                "expected_results": "This should automatically create the
> recipe kernel-module-hello-world.bb under
> <crops-esdk-workdir-workspace>/recipes/kernel-module-hello-world/kernel-mod
> ule-hello-world.bb " },
>                  "6": {
> -                    "action": "devtool build v4l2loopback-driver   \n\n",
> +                    "action": "devtool build kernel-module-hello-world  
> \n\n", "expected_results": "This should compile an image   \n\n" },
>                  "7": {
> -                    "action": "devtool reset v4l2loopback-driver   ",
> -                    "expected_results": "This cleans sysroot of the
> v4l2loopback-driver recipe, but it leaves the source tree intact. meaning
> it does not erase." +                    "action": "devtool reset
> kernel-module-hello-world   ", +                    "expected_results":
> "This cleans sysroot of the kernel-module-hello-world recipe, but it leaves
> the source tree intact. meaning it does not erase." }
>              },
>              "summary": "sdkext_devtool_kernelmodule"
> @@ -291,4 +291,4 @@
>              "summary": "sdkext_recipes_for_nodejs"
>          }
>      }
> -]
> \ No newline at end of file
> +]
> diff --git a/meta/lib/oeqa/sdkext/cases/devtool.py
> b/meta/lib/oeqa/sdkext/cases/devtool.py index 5a02add764..fad98fbb36 100644
> --- a/meta/lib/oeqa/sdkext/cases/devtool.py
> +++ b/meta/lib/oeqa/sdkext/cases/devtool.py
> @@ -73,8 +73,8 @@ class DevtoolTest(OESDKExtTestCase):
>              self._run('devtool reset %s' % recipe)
> 
>      def test_devtool_kernelmodule(self):
> -        docfile = 'https://github.com/umlaeute/v4l2loopback.git'
> -        recipe = 'v4l2loopback-driver'
> +        docfile =
> 'https://github.com/masselstine/kernel-module-hello-world.git' +       
> recipe = 'kernel-module-hello-world'
>          self._run('devtool add %s %s' % (recipe, docfile) )
>          try:
>              self._run('devtool build %s' % recipe)

Re: [PATCH][V2] sdkext: use simpler kernel module for devtool test

[richard.purdie]

On Thu, 2019-09-05 at 13:54 -0400, Mark Asselstine wrote:
> On Thursday, August 22, 2019 11:56:16 A.M. EDT Mark Asselstine wrote:
> > The current devtool test for the building of an out-of-tree kernel
> > module uses something which requires several "high order" kconfigs
> > to
> > be set. This results in the test failing, not for expected reasons,
> > but rather because it depends on specific kernel configuration.
> > 
> > You will get error messages such as
> > 
> >   ERROR: "video_ioctl2"
> >  
> > [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
> > driver/v4l2loopback.k
> > o] undefined!
> >   ERROR: "video_unregister_device"
> >  
> > [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
> > driver/v4l2loopback.k
> > o] undefined!
> > 
> > Using a simpler hello-world kernel module example will only require
> > that CONFIG_MODULE is enabled, thus avoiding a false positive.
> > 
> > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > ---
> > 
> > **V2**
> >  - also updated the CROPS manual test json file
> >    (I have no idea how to run this so untested but this is a
> > straight
> >     substition)
> >  - continue to use github until we can move the sample to somewhere
> >    like git.yoctoproject.org
> 
> Richard, are you thinking we need to figure out the
> git.yoctoproject.org repo 
> before we can move ahead with merging this?

I would like to fix that, yes. I could ask Michael for help but I do
have access to sort it myself too.

I'm also trying to sort out a few other issues before -next can merge.

Since I'm failing to get to it,

Michael,

Could you clone:

https://github.com/masselstine/kernel-module-hello-world.git 

onto git.yp.org as a new repo and give write access to it for Mark,
myself, Bruce and Ross please?

Cheers,

Richard

Re: [PATCH][V2] sdkext: use simpler kernel module for devtool test

[Michael Halstead]

On 9/5/19 2:27 PM, richard.purdie@linuxfoundation.org wrote:
> On Thu, 2019-09-05 at 13:54 -0400, Mark Asselstine wrote:
>> On Thursday, August 22, 2019 11:56:16 A.M. EDT Mark Asselstine wrote:
>>> The current devtool test for the building of an out-of-tree kernel
>>> module uses something which requires several "high order" kconfigs
>>> to
>>> be set. This results in the test failing, not for expected reasons,
>>> but rather because it depends on specific kernel configuration.
>>>
>>> You will get error messages such as
>>>
>>>   ERROR: "video_ioctl2"
>>>  
>>> [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
>>> driver/v4l2loopback.k
>>> o] undefined!
>>>   ERROR: "video_unregister_device"
>>>  
>>> [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
>>> driver/v4l2loopback.k
>>> o] undefined!
>>>
>>> Using a simpler hello-world kernel module example will only require
>>> that CONFIG_MODULE is enabled, thus avoiding a false positive.
>>>
>>> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
>>> ---
>>>
>>> **V2**
>>>  - also updated the CROPS manual test json file
>>>    (I have no idea how to run this so untested but this is a
>>> straight
>>>     substition)
>>>  - continue to use github until we can move the sample to somewhere
>>>    like git.yoctoproject.org
>> Richard, are you thinking we need to figure out the
>> git.yoctoproject.org repo 
>> before we can move ahead with merging this?
> I would like to fix that, yes. I could ask Michael for help but I do
> have access to sort it myself too.
>
> I'm also trying to sort out a few other issues before -next can merge.
>
> Since I'm failing to get to it,
>
> Michael,
>
> Could you clone:
>
> https://github.com/masselstine/kernel-module-hello-world.git 
>
> onto git.yp.org as a new repo and give write access to it for Mark,
> myself, Bruce and Ross please?

This repo is ready at
git@push.yoctoproject.org:kernel-module-hello-world for the four of you.

It is available read-only for anyone at,

git://git.yoctoproject.org/kernel-module-hello-world

and

https://git.yoctoproject.org/git/pokykernel-module-hello-world

>
> Cheers,
>
> Richard
>
>
>
-- 
Michael Halstead
Linux Foundation / SysAdmin

Re: [PATCH][V2] sdkext: use simpler kernel module for devtool test

[richard.purdie]

On Thu, 2019-09-05 at 17:10 -0700, Michael Halstead wrote:
> On 9/5/19 2:27 PM, richard.purdie@linuxfoundation.org wrote:
> > On Thu, 2019-09-05 at 13:54 -0400, Mark Asselstine wrote:
> > > Richard, are you thinking we need to figure out the
> > > git.yoctoproject.org repo 
> > > before we can move ahead with merging this?
> > I would like to fix that, yes. I could ask Michael for help but I
> > do
> > have access to sort it myself too.
> > 
> > I'm also trying to sort out a few other issues before -next can
> > merge.
> > 
> > Since I'm failing to get to it,
> > 
> > Michael,
> > 
> > Could you clone:
> > 
> > https://github.com/masselstine/kernel-module-hello-world.git 
> > 
> > onto git.yp.org as a new repo and give write access to it for Mark,
> > myself, Bruce and Ross please?
> 
> This repo is ready at
> git@push.yoctoproject.org:kernel-module-hello-world for the four of
> you.
> 
> It is available read-only for anyone at,
> 
> git://git.yoctoproject.org/kernel-module-hello-world
> 
> and
> 
> https://git.yoctoproject.org/git/pokykernel-module-hello-world

Thanks Michael.

Mark: I tweaked your patch and its now merged (avoiding the typo
above!)

Cheers,

Richard

Re: [PATCH][V2] sdkext: use simpler kernel module for devtool test

[Mark Asselstine]

On Friday, September 6, 2019 6:56:26 A.M. EDT 
richard.purdie@linuxfoundation.org wrote:
> On Thu, 2019-09-05 at 17:10 -0700, Michael Halstead wrote:
> > On 9/5/19 2:27 PM, richard.purdie@linuxfoundation.org wrote:
> > > On Thu, 2019-09-05 at 13:54 -0400, Mark Asselstine wrote:
> > > > Richard, are you thinking we need to figure out the
> > > > git.yoctoproject.org repo
> > > > before we can move ahead with merging this?
> > > 
> > > I would like to fix that, yes. I could ask Michael for help but I
> > > do
> > > have access to sort it myself too.
> > > 
> > > I'm also trying to sort out a few other issues before -next can
> > > merge.
> > > 
> > > Since I'm failing to get to it,
> > > 
> > > Michael,
> > > 
> > > Could you clone:
> > > 
> > > https://github.com/masselstine/kernel-module-hello-world.git
> > > 
> > > onto git.yp.org as a new repo and give write access to it for Mark,
> > > myself, Bruce and Ross please?
> > 
> > This repo is ready at
> > git@push.yoctoproject.org:kernel-module-hello-world for the four of
> > you.
> > 
> > It is available read-only for anyone at,
> > 
> > git://git.yoctoproject.org/kernel-module-hello-world
> > 
> > and
> > 
> > https://git.yoctoproject.org/git/pokykernel-module-hello-world
> 
> Thanks Michael.
> 
> Mark: I tweaked your patch and its now merged (avoiding the typo
> above!)

Great, thanks Michael and RP for following through on this.

MarkA

> 
> Cheers,
> 
> Richard