From: Robin Murphy <robin.murphy@arm.com> To: Zhen Lei <thunder.leizhen@huawei.com>, Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, iommu <iommu@lists.linux-foundation.org>, linux-kernel <linux-kernel@vger.kernel.org> Cc: LinuxArm <linuxarm@huawei.com>, Hanjun Guo <guohanjun@huawei.com>, Libin <huawei.libin@huawei.com> Subject: Re: [PATCH v4 1/5] iommu/arm-smmu-v3: fix the implementation of flush_iotlb_all hook Date: Thu, 9 Aug 2018 11:25:01 +0100 [thread overview] Message-ID: <8e00e0c2-c3d1-96ed-569a-b03170fb23a4@arm.com> (raw) In-Reply-To: <1533558424-16748-2-git-send-email-thunder.leizhen@huawei.com> On 06/08/18 13:27, Zhen Lei wrote: > .flush_iotlb_all can not just wait for previous tlbi operations to be > completed, but should also invalid all TLBs of the related domain. I think it was like that because the only caller in practice was iommu_group_create_direct_mappings(), and at that point any relevant invalidations would have already been issued anyway. Once flush_iotlb_all actually does what it's supposed to we'll get a bit of unavoidable over-invalidation on that path, but it's no big deal. Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > drivers/iommu/arm-smmu-v3.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 4810f61..2f1304b 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -1770,6 +1770,14 @@ static int arm_smmu_map(struct iommu_domain *domain, unsigned long iova, > return ops->unmap(ops, iova, size); > } > > +static void arm_smmu_flush_iotlb_all(struct iommu_domain *domain) > +{ > + struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); > + > + if (smmu_domain->smmu) > + arm_smmu_tlb_inv_context(smmu_domain); > +} > + > static void arm_smmu_iotlb_sync(struct iommu_domain *domain) > { > struct arm_smmu_device *smmu = to_smmu_domain(domain)->smmu; > @@ -1998,7 +2006,7 @@ static void arm_smmu_put_resv_regions(struct device *dev, > .map = arm_smmu_map, > .unmap = arm_smmu_unmap, > .map_sg = default_iommu_map_sg, > - .flush_iotlb_all = arm_smmu_iotlb_sync, > + .flush_iotlb_all = arm_smmu_flush_iotlb_all, > .iotlb_sync = arm_smmu_iotlb_sync, > .iova_to_phys = arm_smmu_iova_to_phys, > .add_device = arm_smmu_add_device, > -- > 1.8.3 > >
WARNING: multiple messages have this Message-ID (diff)
From: robin.murphy@arm.com (Robin Murphy) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/5] iommu/arm-smmu-v3: fix the implementation of flush_iotlb_all hook Date: Thu, 9 Aug 2018 11:25:01 +0100 [thread overview] Message-ID: <8e00e0c2-c3d1-96ed-569a-b03170fb23a4@arm.com> (raw) In-Reply-To: <1533558424-16748-2-git-send-email-thunder.leizhen@huawei.com> On 06/08/18 13:27, Zhen Lei wrote: > .flush_iotlb_all can not just wait for previous tlbi operations to be > completed, but should also invalid all TLBs of the related domain. I think it was like that because the only caller in practice was iommu_group_create_direct_mappings(), and at that point any relevant invalidations would have already been issued anyway. Once flush_iotlb_all actually does what it's supposed to we'll get a bit of unavoidable over-invalidation on that path, but it's no big deal. Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > drivers/iommu/arm-smmu-v3.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 4810f61..2f1304b 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -1770,6 +1770,14 @@ static int arm_smmu_map(struct iommu_domain *domain, unsigned long iova, > return ops->unmap(ops, iova, size); > } > > +static void arm_smmu_flush_iotlb_all(struct iommu_domain *domain) > +{ > + struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); > + > + if (smmu_domain->smmu) > + arm_smmu_tlb_inv_context(smmu_domain); > +} > + > static void arm_smmu_iotlb_sync(struct iommu_domain *domain) > { > struct arm_smmu_device *smmu = to_smmu_domain(domain)->smmu; > @@ -1998,7 +2006,7 @@ static void arm_smmu_put_resv_regions(struct device *dev, > .map = arm_smmu_map, > .unmap = arm_smmu_unmap, > .map_sg = default_iommu_map_sg, > - .flush_iotlb_all = arm_smmu_iotlb_sync, > + .flush_iotlb_all = arm_smmu_flush_iotlb_all, > .iotlb_sync = arm_smmu_iotlb_sync, > .iova_to_phys = arm_smmu_iova_to_phys, > .add_device = arm_smmu_add_device, > -- > 1.8.3 > >
next prev parent reply other threads:[~2018-08-09 10:25 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-06 12:26 [PATCH v4 0/5] add non-strict mode support for arm-smmu-v3 Zhen Lei 2018-08-06 12:26 ` Zhen Lei 2018-08-06 12:27 ` [PATCH v4 1/5] iommu/arm-smmu-v3: fix the implementation of flush_iotlb_all hook Zhen Lei 2018-08-06 12:27 ` Zhen Lei 2018-08-09 10:25 ` Robin Murphy [this message] 2018-08-09 10:25 ` Robin Murphy 2018-08-06 12:27 ` [PATCH v4 2/5] iommu/dma: add support for non-strict mode Zhen Lei 2018-08-06 12:27 ` Zhen Lei 2018-08-09 10:46 ` Robin Murphy 2018-08-09 10:46 ` Robin Murphy 2018-08-09 11:01 ` Leizhen (ThunderTown) 2018-08-09 11:01 ` Leizhen (ThunderTown) 2018-08-09 11:01 ` Leizhen (ThunderTown) 2018-08-06 12:27 ` [PATCH v4 3/5] iommu/io-pgtable-arm: " Zhen Lei 2018-08-06 12:27 ` Zhen Lei 2018-08-09 10:54 ` Robin Murphy 2018-08-09 10:54 ` Robin Murphy 2018-08-09 11:20 ` Leizhen (ThunderTown) 2018-08-09 11:20 ` Leizhen (ThunderTown) 2018-08-09 11:20 ` Leizhen (ThunderTown) 2018-08-06 12:27 ` [PATCH v4 4/5] iommu/arm-smmu-v3: " Zhen Lei 2018-08-06 12:27 ` Zhen Lei 2018-08-09 11:06 ` Robin Murphy 2018-08-09 11:06 ` Robin Murphy 2018-08-14 1:49 ` Leizhen (ThunderTown) 2018-08-14 1:49 ` Leizhen (ThunderTown) 2018-08-06 12:27 ` [PATCH v4 5/5] iommu/arm-smmu-v3: add bootup option "arm_iommu" Zhen Lei 2018-08-06 12:27 ` Zhen Lei 2018-08-09 11:08 ` Robin Murphy 2018-08-09 11:08 ` Robin Murphy 2018-08-13 7:50 ` Leizhen (ThunderTown) 2018-08-13 7:50 ` Leizhen (ThunderTown)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8e00e0c2-c3d1-96ed-569a-b03170fb23a4@arm.com \ --to=robin.murphy@arm.com \ --cc=guohanjun@huawei.com \ --cc=huawei.libin@huawei.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=thunder.leizhen@huawei.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.