All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dillon.minfei@gmail.com, thierry.reding@gmail.com,
	sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch,
	robh+dt@kernel.org, linus.walleij@linaro.org,
	alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com
Cc: dianders@chromium.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver
Date: Wed, 21 Jul 2021 19:42:42 +0200	[thread overview]
Message-ID: <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> (raw)
In-Reply-To: <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com>



Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com:
> From: Dillon Min <dillon.minfei@gmail.com>
> 
> This driver combine tiny/ili9341.c mipi_dbi_interface driver
> with mipi_dpi_interface driver, can support ili9341 with serial
> mode or parallel rgb interface mode by register configuration.
> 
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> ---

> +static const struct of_device_id ili9341_of_match[] = {
> +	{
> +		.compatible = "st,sf-tc240t-9370-t",
> +		.data = &ili9341_stm32f429_disco_data,
> +	},
> +	{
> +		/* porting from tiny/ili9341.c
> +		 * for original mipi dbi compitable
> +		 */
> +		.compatible = "adafruit,yx240qv29",

I don't understand this, now there will be 2 drivers that support the
same display?

AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan
to remove the tiny/ driver? If so I couldn't see this mentioned anywhere.

Noralf.

> +		.data = NULL,
> +	},
> +};
> +MODULE_DEVICE_TABLE(of, ili9341_of_match);

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dillon.minfei@gmail.com, thierry.reding@gmail.com,
	sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch,
	robh+dt@kernel.org, linus.walleij@linaro.org,
	alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com
Cc: dianders@chromium.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver
Date: Wed, 21 Jul 2021 19:42:42 +0200	[thread overview]
Message-ID: <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> (raw)
In-Reply-To: <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com>



Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com:
> From: Dillon Min <dillon.minfei@gmail.com>
> 
> This driver combine tiny/ili9341.c mipi_dbi_interface driver
> with mipi_dpi_interface driver, can support ili9341 with serial
> mode or parallel rgb interface mode by register configuration.
> 
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> ---

> +static const struct of_device_id ili9341_of_match[] = {
> +	{
> +		.compatible = "st,sf-tc240t-9370-t",
> +		.data = &ili9341_stm32f429_disco_data,
> +	},
> +	{
> +		/* porting from tiny/ili9341.c
> +		 * for original mipi dbi compitable
> +		 */
> +		.compatible = "adafruit,yx240qv29",

I don't understand this, now there will be 2 drivers that support the
same display?

AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan
to remove the tiny/ driver? If so I couldn't see this mentioned anywhere.

Noralf.

> +		.data = NULL,
> +	},
> +};
> +MODULE_DEVICE_TABLE(of, ili9341_of_match);

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dillon.minfei@gmail.com, thierry.reding@gmail.com,
	sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch,
	robh+dt@kernel.org, linus.walleij@linaro.org,
	alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, dianders@chromium.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver
Date: Wed, 21 Jul 2021 19:42:42 +0200	[thread overview]
Message-ID: <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> (raw)
In-Reply-To: <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com>



Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com:
> From: Dillon Min <dillon.minfei@gmail.com>
> 
> This driver combine tiny/ili9341.c mipi_dbi_interface driver
> with mipi_dpi_interface driver, can support ili9341 with serial
> mode or parallel rgb interface mode by register configuration.
> 
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> ---

> +static const struct of_device_id ili9341_of_match[] = {
> +	{
> +		.compatible = "st,sf-tc240t-9370-t",
> +		.data = &ili9341_stm32f429_disco_data,
> +	},
> +	{
> +		/* porting from tiny/ili9341.c
> +		 * for original mipi dbi compitable
> +		 */
> +		.compatible = "adafruit,yx240qv29",

I don't understand this, now there will be 2 drivers that support the
same display?

AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan
to remove the tiny/ driver? If so I couldn't see this mentioned anywhere.

Noralf.

> +		.data = NULL,
> +	},
> +};
> +MODULE_DEVICE_TABLE(of, ili9341_of_match);

  parent reply	other threads:[~2021-07-21 17:42 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  7:41 [PATCH v2 0/3] Add ilitek ili9341 panel driver dillon.minfei
2021-07-21  7:41 ` dillon.minfei
2021-07-21  7:41 ` dillon.minfei
2021-07-21  7:41 ` [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings dillon.minfei
2021-07-21  7:41   ` dillon.minfei
2021-07-21  7:41   ` dillon.minfei
2021-07-21 14:00   ` Linus Walleij
2021-07-21 14:00     ` Linus Walleij
2021-07-21 14:00     ` Linus Walleij
2021-07-21 14:17     ` Sam Ravnborg
2021-07-21 14:17       ` Sam Ravnborg
2021-07-21 14:22       ` Linus Walleij
2021-07-21 14:22         ` Linus Walleij
2021-07-21 14:22         ` Linus Walleij
2021-07-21  7:41 ` [PATCH v2 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding dillon.minfei
2021-07-21  7:41   ` dillon.minfei
2021-07-21  7:41   ` dillon.minfei
2021-07-21 14:53   ` Dillon Min
2021-07-21 14:53     ` Dillon Min
2021-07-21 14:53     ` Dillon Min
2021-07-21  7:41 ` [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver dillon.minfei
2021-07-21  7:41   ` dillon.minfei
2021-07-21  7:41   ` dillon.minfei
2021-07-21 14:02   ` Linus Walleij
2021-07-21 14:02     ` Linus Walleij
2021-07-21 14:02     ` Linus Walleij
2021-07-21 15:00     ` Dillon Min
2021-07-21 15:00       ` Dillon Min
2021-07-21 15:00       ` Dillon Min
2021-07-21 15:47   ` Jagan Teki
2021-07-21 15:47     ` Jagan Teki
2021-07-21 15:47     ` Jagan Teki
2021-07-21 23:08     ` Dillon Min
2021-07-21 23:08       ` Dillon Min
2021-07-21 23:08       ` Dillon Min
2021-07-22  7:58       ` Jagan Teki
2021-07-22  7:58         ` Jagan Teki
2021-07-22  7:58         ` Jagan Teki
2021-07-21 16:56   ` Sam Ravnborg
2021-07-21 16:56     ` Sam Ravnborg
2021-07-21 23:28     ` Dillon Min
2021-07-21 23:28       ` Dillon Min
2021-07-21 23:28       ` Dillon Min
2021-07-21 17:42   ` Noralf Trønnes [this message]
2021-07-21 17:42     ` Noralf Trønnes
2021-07-21 17:42     ` Noralf Trønnes
2021-07-22  2:07     ` Dillon Min
2021-07-22  2:07       ` Dillon Min
2021-07-22  2:07       ` Dillon Min
2021-07-22  7:03       ` Noralf Trønnes
2021-07-22  7:03         ` Noralf Trønnes
2021-07-22  7:03         ` Noralf Trønnes
2021-07-22  7:10         ` Dillon Min
2021-07-22  7:10           ` Dillon Min
2021-07-22  7:10           ` Dillon Min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=airlied@linux.ie \
    --cc=alexandre.torgue@foss.st.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dillon.minfei@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.