* [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave
@ 2016-05-10 1:28 Taku Izumi
2016-05-10 2:06 ` David Miller
2016-05-10 13:13 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Taku Izumi @ 2016-05-10 1:28 UTC (permalink / raw)
To: netdev, davem; +Cc: isimatu.yasuaki, Taku Izumi
commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().
This spin_lock_irqsave() is obviously unnecessary.
This patch eliminates unnecessary spin_lock_irqsave() in
fjes_change_mtu()
Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
---
drivers/net/fjes/fjes_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index f4e6926..86c331b 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -819,7 +819,6 @@ static int fjes_change_mtu(struct net_device *netdev, int new_mtu)
netdev->mtu = new_mtu;
if (running) {
- spin_lock_irqsave(&hw->rx_status_lock, flags);
for (epidx = 0; epidx < hw->max_epid; epidx++) {
if (epidx == hw->my_epid)
continue;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave
2016-05-10 1:28 [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave Taku Izumi
@ 2016-05-10 2:06 ` David Miller
2016-05-10 13:13 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-10 2:06 UTC (permalink / raw)
To: izumi.taku; +Cc: netdev, isimatu.yasuaki
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
Date: Tue, 10 May 2016 10:28:49 +0900
> commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().
> This spin_lock_irqsave() is obviously unnecessary.
>
> This patch eliminates unnecessary spin_lock_irqsave() in
> fjes_change_mtu()
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave
2016-05-10 1:28 [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave Taku Izumi
2016-05-10 2:06 ` David Miller
@ 2016-05-10 13:13 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-05-10 13:13 UTC (permalink / raw)
To: Taku Izumi, netdev, davem; +Cc: isimatu.yasuaki
Hello.
On 5/10/2016 4:28 AM, Taku Izumi wrote:
> commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().
scripts/checkpatch.pl now enforces a certain commit citing style, yours
doesn't match it.
> This spin_lock_irqsave() is obviously unnecessary.
>
> This patch eliminates unnecessary spin_lock_irqsave() in
> fjes_change_mtu()
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
[...]
The "Fixes:" tag would also be in order...
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-10 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 1:28 [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave Taku Izumi
2016-05-10 2:06 ` David Miller
2016-05-10 13:13 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.