* [PATCH net-next 0/2] net: stmmac: selftests: Two fixes
@ 2019-05-29 8:30 Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 1/2] net: stmmac: selftests: Fix sparse warning Jose Abreu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jose Abreu @ 2019-05-29 8:30 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: Jose Abreu, Joao Pinto, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue
Two fixes reported by kbuild.
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Jose Abreu (2):
net: stmmac: selftests: Fix sparse warning
net: stmmac: selftests: Use kfree_skb() instead of kfree()
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 1/2] net: stmmac: selftests: Fix sparse warning
2019-05-29 8:30 [PATCH net-next 0/2] net: stmmac: selftests: Two fixes Jose Abreu
@ 2019-05-29 8:30 ` Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 2/2] net: stmmac: selftests: Use kfree_skb() instead of kfree() Jose Abreu
2019-05-30 19:34 ` [PATCH net-next 0/2] net: stmmac: selftests: Two fixes David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jose Abreu @ 2019-05-29 8:30 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: Jose Abreu, Joao Pinto, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue
Variable shall be __be16. Fix it.
Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
index 33dc37c7e1c1..9d9bad5d31bf 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
@@ -114,7 +114,7 @@ static struct sk_buff *stmmac_test_get_udp_skb(struct stmmac_priv *priv,
}
if (attr->vlan) {
- u16 *tag, *proto;
+ __be16 *tag, *proto;
if (!attr->remove_sa) {
tag = (void *)ehdr + ETH_HLEN;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] net: stmmac: selftests: Use kfree_skb() instead of kfree()
2019-05-29 8:30 [PATCH net-next 0/2] net: stmmac: selftests: Two fixes Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 1/2] net: stmmac: selftests: Fix sparse warning Jose Abreu
@ 2019-05-29 8:30 ` Jose Abreu
2019-05-30 19:34 ` [PATCH net-next 0/2] net: stmmac: selftests: Two fixes David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jose Abreu @ 2019-05-29 8:30 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: Jose Abreu, Joao Pinto, David S . Miller, Giuseppe Cavallaro,
Alexandre Torgue
kfree_skb() shall be used instead of kfree(). Fix it.
Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
index 9d9bad5d31bf..a97b1ea76438 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
@@ -617,7 +617,7 @@ static int stmmac_test_flowctrl_validate(struct sk_buff *skb,
tpriv->ok = true;
complete(&tpriv->comp);
out:
- kfree(skb);
+ kfree_skb(skb);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 0/2] net: stmmac: selftests: Two fixes
2019-05-29 8:30 [PATCH net-next 0/2] net: stmmac: selftests: Two fixes Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 1/2] net: stmmac: selftests: Fix sparse warning Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 2/2] net: stmmac: selftests: Use kfree_skb() instead of kfree() Jose Abreu
@ 2019-05-30 19:34 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-05-30 19:34 UTC (permalink / raw)
To: Jose.Abreu
Cc: linux-kernel, netdev, Joao.Pinto, peppe.cavallaro, alexandre.torgue
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Wed, 29 May 2019 10:30:24 +0200
> Two fixes reported by kbuild.
Series applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-30 19:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 8:30 [PATCH net-next 0/2] net: stmmac: selftests: Two fixes Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 1/2] net: stmmac: selftests: Fix sparse warning Jose Abreu
2019-05-29 8:30 ` [PATCH net-next 2/2] net: stmmac: selftests: Use kfree_skb() instead of kfree() Jose Abreu
2019-05-30 19:34 ` [PATCH net-next 0/2] net: stmmac: selftests: Two fixes David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.