All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Jeremy Cline <jeremy@jcline.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	patches@opensource.cirrus.com,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 3/8] iio: accel: bmc150: Move check for second ACPI device into a separate function
Date: Sat, 22 May 2021 20:57:28 +0200	[thread overview]
Message-ID: <8e4e58a1-49ab-0a45-057d-838e4e934a98@redhat.com> (raw)
In-Reply-To: <CAHp75VfL0U90qcG4D1eOEP0f8sOMiNsrHwXVe4YjR1ypQFBLwQ@mail.gmail.com>

Hi,

On 5/22/21 8:09 PM, Andy Shevchenko wrote:
> On Fri, May 21, 2021 at 11:23 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Move the check for a second ACPI device for BOSC0200 ACPI fwnodes into
>> a new bmc150_acpi_dual_accel_probe() helper function.
>>
>> This is a preparation patch for adding support for a new "DUAL250E" ACPI
>> Hardware-ID (HID) used on some devices.
> 
> ...
> 
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id bmc150_acpi_dual_accel_ids[] = {
>> +       {"BOSC0200"},
> 
>> +       { },
> 
> I guess it is a good chance to drop a comma.

Ack, will drop for v2.

Regards,

Hans


> 
>> +};
> 
> ...
> 
>> +       if (!IS_ERR(second_dev))
>> +               bmc150_set_second_device(client, second_dev);
> 
> I would comment on the pattern here, but I have noticed that this code
> is changed in the further patches anyway.
> 


WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	patches@opensource.cirrus.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jeremy Cline <jeremy@jcline.org>, Mark Brown <broonie@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 3/8] iio: accel: bmc150: Move check for second ACPI device into a separate function
Date: Sat, 22 May 2021 20:57:28 +0200	[thread overview]
Message-ID: <8e4e58a1-49ab-0a45-057d-838e4e934a98@redhat.com> (raw)
In-Reply-To: <CAHp75VfL0U90qcG4D1eOEP0f8sOMiNsrHwXVe4YjR1ypQFBLwQ@mail.gmail.com>

Hi,

On 5/22/21 8:09 PM, Andy Shevchenko wrote:
> On Fri, May 21, 2021 at 11:23 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Move the check for a second ACPI device for BOSC0200 ACPI fwnodes into
>> a new bmc150_acpi_dual_accel_probe() helper function.
>>
>> This is a preparation patch for adding support for a new "DUAL250E" ACPI
>> Hardware-ID (HID) used on some devices.
> 
> ...
> 
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id bmc150_acpi_dual_accel_ids[] = {
>> +       {"BOSC0200"},
> 
>> +       { },
> 
> I guess it is a good chance to drop a comma.

Ack, will drop for v2.

Regards,

Hans


> 
>> +};
> 
> ...
> 
>> +       if (!IS_ERR(second_dev))
>> +               bmc150_set_second_device(client, second_dev);
> 
> I would comment on the pattern here, but I have noticed that this code
> is changed in the further patches anyway.
> 


  reply	other threads:[~2021-05-22 18:57 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 17:14 [PATCH 0/8] iio: accel: bmc150: Add support for yoga's with dual accelerometers with an ACPI HID of DUAL250E Hans de Goede
2021-05-21 17:14 ` Hans de Goede
2021-05-21 17:14 ` [PATCH 1/8] iio: accel: bmc150: Fix dereferencing the wrong pointer in bmc150_get/set_second_device Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-21 17:14 ` [PATCH 2/8] iio: accel: bmc150: Don't make the remove function of the second accelerometer unregister itself Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-22 18:06   ` Andy Shevchenko
2021-05-22 18:06     ` Andy Shevchenko
2021-05-22 18:10     ` Hans de Goede
2021-05-22 18:10       ` Hans de Goede
2021-05-21 17:14 ` [PATCH 3/8] iio: accel: bmc150: Move check for second ACPI device into a separate function Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-22 17:37   ` Jonathan Cameron
2021-05-22 17:37     ` Jonathan Cameron
2021-05-22 17:39     ` Hans de Goede
2021-05-22 17:39       ` Hans de Goede
2021-05-22 18:09   ` Andy Shevchenko
2021-05-22 18:09     ` Andy Shevchenko
2021-05-22 18:57     ` Hans de Goede [this message]
2021-05-22 18:57       ` Hans de Goede
2021-05-21 17:14 ` [PATCH 4/8] iio: accel: bmc150: Add support for dual-accelerometers with a DUAL250E HID Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-22 17:43   ` Jonathan Cameron
2021-05-22 17:43     ` Jonathan Cameron
2021-05-22 17:44     ` Hans de Goede
2021-05-22 17:44       ` Hans de Goede
2021-05-22 17:56       ` Jonathan Cameron
2021-05-22 17:56         ` Jonathan Cameron
2021-05-22 18:11   ` Andy Shevchenko
2021-05-22 18:11     ` Andy Shevchenko
2021-05-22 18:59     ` Hans de Goede
2021-05-22 18:59       ` Hans de Goede
2021-05-21 17:14 ` [PATCH 5/8] iio: accel: bmc150: Move struct bmc150_accel_data definition to bmc150-accel.h Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-21 17:14 ` [PATCH 6/8] iio: accel: bmc150: Remove bmc150_set/get_second_device() accessor functions Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-21 17:14 ` [PATCH 7/8] iio: accel: bmc150: Add support for DUAL250E ACPI DSM for setting the hinge angle Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-22 17:53   ` Jonathan Cameron
2021-05-22 17:53     ` Jonathan Cameron
2021-05-22 18:21   ` Andy Shevchenko
2021-05-22 18:21     ` Andy Shevchenko
2021-05-22 19:02     ` Hans de Goede
2021-05-22 19:02       ` Hans de Goede
2021-05-21 17:14 ` [PATCH 8/8] iio: accel: bmc150: Set label based on accel-location for ACPI DUAL250E fwnodes Hans de Goede
2021-05-21 17:14   ` Hans de Goede
2021-05-22 18:34   ` Andy Shevchenko
2021-05-22 18:34     ` Andy Shevchenko
2021-05-22 19:04     ` Hans de Goede
2021-05-22 19:04       ` Hans de Goede
2021-05-22 18:01 ` [PATCH 0/8] iio: accel: bmc150: Add support for yoga's with dual accelerometers with an ACPI HID of DUAL250E Jonathan Cameron
2021-05-22 18:01   ` Jonathan Cameron
2021-05-22 18:03   ` Andy Shevchenko
2021-05-22 18:03     ` Andy Shevchenko
2021-05-22 18:49     ` Jonathan Cameron
2021-05-22 18:49       ` Jonathan Cameron
2021-05-23 11:05   ` Hans de Goede
2021-05-23 11:05     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e4e58a1-49ab-0a45-057d-838e4e934a98@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=jeremy@jcline.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.