All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] workqueue: Add back __printf format validation
@ 2021-06-03  3:11 Joe Perches
  2021-06-04 14:55 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2021-06-03  3:11 UTC (permalink / raw)
  To: Tejun Heo; +Cc: Lai Jiangshan, Bart Van Assche, LKML

commit 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for
workqueues") indirectly removed the printf validation for alloc_workqueue.

Add it back.

Signed-off-by: Joe Perches <joe@perches.com>
---

compiled x86-64 defconfig only, but there _might_ be some new
warning for a fmt/arg mismatch somewhere.  Hope not...

 include/linux/workqueue.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index d15a7730ee18b..7c177267a81f3 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -404,6 +404,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
  * RETURNS:
  * Pointer to the allocated workqueue on success, %NULL on failure.
  */
+__printf(1, 4)
 struct workqueue_struct *alloc_workqueue(const char *fmt,
 					 unsigned int flags,
 					 int max_active, ...);



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] workqueue: Add back __printf format validation
  2021-06-03  3:11 [PATCH] workqueue: Add back __printf format validation Joe Perches
@ 2021-06-04 14:55 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2021-06-04 14:55 UTC (permalink / raw)
  To: Joe Perches; +Cc: Lai Jiangshan, Bart Van Assche, LKML

On Wed, Jun 02, 2021 at 08:11:48PM -0700, Joe Perches wrote:
> commit 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for
> workqueues") indirectly removed the printf validation for alloc_workqueue.
> 
> Add it back.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied to wq/for-5.14.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-04 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03  3:11 [PATCH] workqueue: Add back __printf format validation Joe Perches
2021-06-04 14:55 ` Tejun Heo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.