* [PATCH] KVM: kvm_stat: do not show halt_wait_ns
@ 2021-10-06 12:17 Christian Borntraeger
2021-10-06 13:15 ` Stefan Raspl
2021-10-15 9:07 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Christian Borntraeger @ 2021-10-06 12:17 UTC (permalink / raw)
To: Paolo Bonzini
Cc: KVM, Christian Borntraeger, linux-s390, Jing Zhang, Stefan Raspl
Similar to commit 111d0bda8eeb ("tools/kvm_stat: Exempt time-based
counters"), we should not show timer values in kvm_stat. Remove the new
halt_wait_ns.
Fixes: 87bcc5fa092f ("KVM: stats: Add halt_wait_ns stats for all architectures")
Cc: Jing Zhang <jingzhangos@google.com>
Cc: Stefan Raspl <raspl@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
tools/kvm/kvm_stat/kvm_stat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index b0bf56c5f120..5a5bd74f55bd 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -742,7 +742,7 @@ class DebugfsProvider(Provider):
The fields are all available KVM debugfs files
"""
- exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns']
+ exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns', 'halt_wait_ns']
fields = [field for field in self.walkdir(PATH_DEBUGFS_KVM)[2]
if field not in exempt_list]
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: kvm_stat: do not show halt_wait_ns
2021-10-06 12:17 [PATCH] KVM: kvm_stat: do not show halt_wait_ns Christian Borntraeger
@ 2021-10-06 13:15 ` Stefan Raspl
2021-10-15 9:07 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Raspl @ 2021-10-06 13:15 UTC (permalink / raw)
To: Christian Borntraeger, Paolo Bonzini
Cc: KVM, linux-s390, Jing Zhang, Stefan Raspl
On 10/6/21 14:17, Christian Borntraeger wrote:
> Similar to commit 111d0bda8eeb ("tools/kvm_stat: Exempt time-based
> counters"), we should not show timer values in kvm_stat. Remove the new
> halt_wait_ns.
>
> Fixes: 87bcc5fa092f ("KVM: stats: Add halt_wait_ns stats for all architectures")
> Cc: Jing Zhang <jingzhangos@google.com>
> Cc: Stefan Raspl <raspl@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Stefan Raspl <raspl@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: kvm_stat: do not show halt_wait_ns
2021-10-06 12:17 [PATCH] KVM: kvm_stat: do not show halt_wait_ns Christian Borntraeger
2021-10-06 13:15 ` Stefan Raspl
@ 2021-10-15 9:07 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-15 9:07 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: KVM, linux-s390, Jing Zhang, Stefan Raspl
On 06/10/21 14:17, Christian Borntraeger wrote:
> Similar to commit 111d0bda8eeb ("tools/kvm_stat: Exempt time-based
> counters"), we should not show timer values in kvm_stat. Remove the new
> halt_wait_ns.
>
> Fixes: 87bcc5fa092f ("KVM: stats: Add halt_wait_ns stats for all architectures")
> Cc: Jing Zhang <jingzhangos@google.com>
> Cc: Stefan Raspl <raspl@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> tools/kvm/kvm_stat/kvm_stat | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index b0bf56c5f120..5a5bd74f55bd 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -742,7 +742,7 @@ class DebugfsProvider(Provider):
> The fields are all available KVM debugfs files
>
> """
> - exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns']
> + exempt_list = ['halt_poll_fail_ns', 'halt_poll_success_ns', 'halt_wait_ns']
> fields = [field for field in self.walkdir(PATH_DEBUGFS_KVM)[2]
> if field not in exempt_list]
>
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-15 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 12:17 [PATCH] KVM: kvm_stat: do not show halt_wait_ns Christian Borntraeger
2021-10-06 13:15 ` Stefan Raspl
2021-10-15 9:07 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.