From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate()
Date: Mon, 25 Nov 2019 13:00:26 +0100 [thread overview]
Message-ID: <8e67b160-02db-4b09-4748-405f740bd159@redhat.com> (raw)
In-Reply-To: <20191122160511.8377-3-kwolf@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1840 bytes --]
On 22.11.19 17:05, Kevin Wolf wrote:
> This adds a no_fallback parameter to bdrv_co_truncate(), bdrv_truncate()
> and blk_truncate() in preparation for a fix that potentially needs to
> zero-write the new area. no_fallback will use BDRV_REQ_NO_FALLBACK for
> this operation and lets the truncate fail if an efficient zero write
> isn't possible.
>
> Only qmp_block_resize() passes true for this parameter because it is a
> blocking monitor command, so we don't want to add more potentially slow
> I/O operations to it than we already have.
>
> All other users will accept even a slow fallback to avoid failure.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/block/block.h | 5 +++--
> include/sysemu/block-backend.h | 2 +-
> block/block-backend.c | 4 ++--
> block/commit.c | 4 ++--
> block/crypto.c | 4 ++--
> block/io.c | 16 ++++++++++++----
> block/mirror.c | 2 +-
> block/parallels.c | 6 +++---
> block/qcow.c | 4 ++--
> block/qcow2-refcount.c | 2 +-
> block/qcow2.c | 19 +++++++++++--------
> block/qed.c | 2 +-
> block/raw-format.c | 2 +-
> block/vdi.c | 2 +-
> block/vhdx-log.c | 2 +-
> block/vhdx.c | 6 +++---
> block/vmdk.c | 10 ++++++----
> block/vpc.c | 2 +-
> blockdev.c | 2 +-
> qemu-img.c | 2 +-
> qemu-io-cmds.c | 2 +-
> tests/test-block-iothread.c | 6 +++---
> 22 files changed, 60 insertions(+), 46 deletions(-)
With the typo pointed out by Eric fixed:
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-25 12:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 16:05 [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 1/8] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate() Kevin Wolf
2019-11-22 16:48 ` Eric Blake
2019-11-25 12:00 ` Max Reitz [this message]
2019-11-25 15:06 ` Alberto Garcia
2019-11-25 16:05 ` Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported Kevin Wolf
2019-11-22 18:03 ` Eric Blake
2019-11-25 12:02 ` Max Reitz
2019-11-25 14:53 ` Alberto Garcia
2019-11-22 16:05 ` [PATCH v3 4/8] block: truncate: Don't make backing file data visible Kevin Wolf
2019-11-22 18:06 ` Eric Blake
2019-11-25 12:08 ` Max Reitz
2019-11-22 16:05 ` [PATCH v3 5/8] iotests: Add qemu_io_log() Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 6/8] iotests: Fix timeout in run_job() Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 7/8] iotests: Support job-complete " Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 8/8] iotests: Test committing to short backing file Kevin Wolf
2019-11-22 18:09 ` Eric Blake
2019-11-25 9:56 ` Vladimir Sementsov-Ogievskiy
2019-11-25 12:19 ` Max Reitz
2019-11-22 16:17 ` [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays Peter Maydell
2019-11-22 16:41 ` Eric Blake
2019-11-25 12:21 ` Max Reitz
2019-11-25 12:24 ` Max Reitz
2019-12-10 17:46 ` Kevin Wolf
2019-12-11 7:09 ` Max Reitz
2019-12-19 9:24 ` Vladimir Sementsov-Ogievskiy
2019-12-19 10:13 ` Kevin Wolf
2019-12-19 10:20 ` Vladimir Sementsov-Ogievskiy
2020-02-05 13:43 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e67b160-02db-4b09-4748-405f740bd159@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.