From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays
Date: Mon, 25 Nov 2019 13:24:51 +0100 [thread overview]
Message-ID: <67c2abd7-26a3-eef6-0fc7-d8901d031248@redhat.com> (raw)
In-Reply-To: <20191122160511.8377-1-kwolf@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1019 bytes --]
On 22.11.19 17:05, Kevin Wolf wrote:
> See patch 4 for the description of the bug fixed.
>
> v3:
> - Don't allow blocking the monitor for a zero write in block_resize
> (even though we can already blockfor other reasons there). This is
> mainly responsible for the increased complexity compared to v2.
> Personally, I think this is not an improvement over v2, but if this is
> what it takes to fix a corruption issue in 4.2... [Max]
I don’t find it so bad because the added complexity is:
(1) A mainly mechanical change of code to add another parameter to
{blk,bdrv}(_co)?_truncate(),
(2) qcow2 providing BDRV_REQ_NO_FALLBACK, and
(3) passing BDRV_REQ_NO_FALLBACK in bdrv_co_truncate() if the new
parameter is true.
(1) sees the most LoC changed, but it isn’t a complex change. (2) and
(3) are both basically one-line changes each.
OTOH, as I’ve said on IRC, I believe you have a sufficient number of
R-bs on v2 to take it without mine, so the choice is yours.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-25 12:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 16:05 [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 1/8] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate() Kevin Wolf
2019-11-22 16:48 ` Eric Blake
2019-11-25 12:00 ` Max Reitz
2019-11-25 15:06 ` Alberto Garcia
2019-11-25 16:05 ` Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported Kevin Wolf
2019-11-22 18:03 ` Eric Blake
2019-11-25 12:02 ` Max Reitz
2019-11-25 14:53 ` Alberto Garcia
2019-11-22 16:05 ` [PATCH v3 4/8] block: truncate: Don't make backing file data visible Kevin Wolf
2019-11-22 18:06 ` Eric Blake
2019-11-25 12:08 ` Max Reitz
2019-11-22 16:05 ` [PATCH v3 5/8] iotests: Add qemu_io_log() Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 6/8] iotests: Fix timeout in run_job() Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 7/8] iotests: Support job-complete " Kevin Wolf
2019-11-22 16:05 ` [PATCH v3 8/8] iotests: Test committing to short backing file Kevin Wolf
2019-11-22 18:09 ` Eric Blake
2019-11-25 9:56 ` Vladimir Sementsov-Ogievskiy
2019-11-25 12:19 ` Max Reitz
2019-11-22 16:17 ` [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays Peter Maydell
2019-11-22 16:41 ` Eric Blake
2019-11-25 12:21 ` Max Reitz
2019-11-25 12:24 ` Max Reitz [this message]
2019-12-10 17:46 ` Kevin Wolf
2019-12-11 7:09 ` Max Reitz
2019-12-19 9:24 ` Vladimir Sementsov-Ogievskiy
2019-12-19 10:13 ` Kevin Wolf
2019-12-19 10:20 ` Vladimir Sementsov-Ogievskiy
2020-02-05 13:43 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67c2abd7-26a3-eef6-0fc7-d8901d031248@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.