From: Markuss Broks <markuss.broks@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>, Ard Biesheuvel <ardb@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, Helge Deller <deller@gmx.de>, "Paul E. McKenney" <paulmck@kernel.org>, Borislav Petkov <bp@suse.de>, Andrew Morton <akpm@linux-foundation.org>, Kees Cook <keescook@chromium.org>, Randy Dunlap <rdunlap@infradead.org>, Damien Le Moal <damien.lemoal@opensource.wdc.com>, Thomas Zimmermann <tzimmermann@suse.de>, Javier Martinez Canillas <javierm@redhat.com>, Michal Suchanek <msuchanek@suse.de>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Wei Ming Chen <jj251510319013@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Tony Lindgren <tony@atomide.com>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, linux-efi <linux-efi@vger.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Linux Fbdev development list <linux-fbdev@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem Date: Thu, 28 Jul 2022 17:57:58 +0300 [thread overview] Message-ID: <8e694cb6-c3dc-74e3-6804-fc532f108523@gmail.com> (raw) In-Reply-To: <CAK8P3a2fZ9O6vSEyxY1KW71pG_Oyvwxp3zTbW2GuaSD6aj+Qfw@mail.gmail.com> Hi Arnd, On 7/28/22 17:48, Arnd Bergmann wrote: > On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks <markuss.broks@gmail.com> wrote: >> >> Add early console support for generic linear framebuffer devices. >> This driver supports probing from cmdline early parameters >> or from the device-tree using information in simple-framebuffer node. >> The EFI functionality should be retained in whole. >> The driver was disabled on ARM because of a bug in early_ioremap >> implementation on ARM. >> >> Signed-off-by: Markuss Broks <markuss.broks@gmail.com> >> --- >> .../admin-guide/kernel-parameters.txt | 12 +- >> MAINTAINERS | 5 + >> drivers/firmware/efi/Kconfig | 6 +- >> drivers/firmware/efi/Makefile | 1 - >> drivers/firmware/efi/earlycon.c | 246 -------------- >> drivers/video/fbdev/Kconfig | 11 + >> drivers/video/fbdev/Makefile | 1 + >> drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++ > > It looks like this is not actually related to fbdev, and since drivers are > moving from fbdev/simplefb towards drm/simpledrm, maybe it would be > better to put this into either drivers/gpu/drm/tiny/ or possibly > drivers/video/console to let this be used without enabling fbdev? Ideally this shouldn't depend on anything, because it isn't utilizing any of fbdev code and won't be utilizing any of drm/console code. I agree that either of those would be a better place for it, but which one do you think would suit more for this driver? > > Arnd - Markuss
WARNING: multiple messages have this Message-ID (diff)
From: Markuss Broks <markuss.broks@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>, linux-efi <linux-efi@vger.kernel.org>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, Tony Lindgren <tony@atomide.com>, dri-devel <dri-devel@lists.freedesktop.org>, Wei Ming Chen <jj251510319013@gmail.com>, phone-devel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>, Ard Biesheuvel <ardb@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Damien Le Moal <damien.lemoal@opensource.wdc.com>, Javier Martinez Canillas <javierm@redhat.com>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Borislav Petkov <bp@suse.de>, Kees Cook <keescook@chromium.org>, "Paul E. McKenney" <paulmck@kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, ~postmarketos/upstreaming@lists.sr.ht, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Michal Suchanek <msuchanek@suse.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Randy Dunlap <rdunlap@infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Andrew Morton <akpm@linux-foundation.org>, Helge Deller <deller@gmx.de> Subject: Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem Date: Thu, 28 Jul 2022 17:57:58 +0300 [thread overview] Message-ID: <8e694cb6-c3dc-74e3-6804-fc532f108523@gmail.com> (raw) In-Reply-To: <CAK8P3a2fZ9O6vSEyxY1KW71pG_Oyvwxp3zTbW2GuaSD6aj+Qfw@mail.gmail.com> Hi Arnd, On 7/28/22 17:48, Arnd Bergmann wrote: > On Thu, Jul 28, 2022 at 4:28 PM Markuss Broks <markuss.broks@gmail.com> wrote: >> >> Add early console support for generic linear framebuffer devices. >> This driver supports probing from cmdline early parameters >> or from the device-tree using information in simple-framebuffer node. >> The EFI functionality should be retained in whole. >> The driver was disabled on ARM because of a bug in early_ioremap >> implementation on ARM. >> >> Signed-off-by: Markuss Broks <markuss.broks@gmail.com> >> --- >> .../admin-guide/kernel-parameters.txt | 12 +- >> MAINTAINERS | 5 + >> drivers/firmware/efi/Kconfig | 6 +- >> drivers/firmware/efi/Makefile | 1 - >> drivers/firmware/efi/earlycon.c | 246 -------------- >> drivers/video/fbdev/Kconfig | 11 + >> drivers/video/fbdev/Makefile | 1 + >> drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++ > > It looks like this is not actually related to fbdev, and since drivers are > moving from fbdev/simplefb towards drm/simpledrm, maybe it would be > better to put this into either drivers/gpu/drm/tiny/ or possibly > drivers/video/console to let this be used without enabling fbdev? Ideally this shouldn't depend on anything, because it isn't utilizing any of fbdev code and won't be utilizing any of drm/console code. I agree that either of those would be a better place for it, but which one do you think would suit more for this driver? > > Arnd - Markuss
next prev parent reply other threads:[~2022-07-28 14:58 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-28 14:28 [PATCH 0/2] Add generic framebuffer support to EFI earlycon driver Markuss Broks 2022-07-28 14:28 ` Markuss Broks 2022-07-28 14:28 ` [PATCH 1/2] drivers: serial: earlycon: Pass device-tree node Markuss Broks 2022-07-28 14:28 ` Markuss Broks 2022-07-28 14:38 ` Greg Kroah-Hartman 2022-07-28 14:38 ` Greg Kroah-Hartman 2022-07-28 21:04 ` Andy Shevchenko 2022-07-28 21:04 ` Andy Shevchenko 2022-07-29 7:57 ` Greg Kroah-Hartman 2022-07-29 7:57 ` Greg Kroah-Hartman 2022-07-29 10:47 ` Andy Shevchenko 2022-07-29 10:47 ` Andy Shevchenko 2022-07-28 14:28 ` [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem Markuss Broks 2022-07-28 14:28 ` Markuss Broks 2022-07-28 14:39 ` Greg Kroah-Hartman 2022-07-28 14:39 ` Greg Kroah-Hartman 2022-07-28 14:52 ` Markuss Broks 2022-07-28 14:52 ` Markuss Broks 2022-07-28 15:01 ` Greg Kroah-Hartman 2022-07-28 15:01 ` Greg Kroah-Hartman 2022-08-06 16:26 ` Markuss Broks 2022-08-06 16:26 ` Markuss Broks 2022-08-07 6:53 ` Greg Kroah-Hartman 2022-08-07 6:53 ` Greg Kroah-Hartman 2022-09-06 19:39 ` Daniel Vetter 2022-09-06 19:39 ` Daniel Vetter 2022-07-28 21:06 ` Andy Shevchenko 2022-07-28 21:06 ` Andy Shevchenko 2022-07-28 14:48 ` Arnd Bergmann 2022-07-28 14:48 ` Arnd Bergmann 2022-07-28 14:57 ` Markuss Broks [this message] 2022-07-28 14:57 ` Markuss Broks 2022-07-28 15:16 ` Arnd Bergmann 2022-07-28 15:16 ` Arnd Bergmann 2022-07-28 18:13 ` Thomas Zimmermann 2022-07-28 18:13 ` Thomas Zimmermann 2022-07-28 21:19 ` Andy Shevchenko 2022-07-28 21:19 ` Andy Shevchenko 2022-07-30 11:54 ` Markuss Broks 2022-07-30 11:54 ` Markuss Broks 2022-07-30 10:25 ` Andy Shevchenko 2022-07-30 10:25 ` Andy Shevchenko 2022-07-28 21:20 ` kernel test robot 2022-07-28 21:20 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8e694cb6-c3dc-74e3-6804-fc532f108523@gmail.com \ --to=markuss.broks@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=ardb@kernel.org \ --cc=arnd@arndb.de \ --cc=b.zolnierkie@samsung.com \ --cc=bp@suse.de \ --cc=corbet@lwn.net \ --cc=damien.lemoal@opensource.wdc.com \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=javierm@redhat.com \ --cc=jirislaby@kernel.org \ --cc=jj251510319013@gmail.com \ --cc=keescook@chromium.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=msuchanek@suse.de \ --cc=paulmck@kernel.org \ --cc=phone-devel@vger.kernel.org \ --cc=rdunlap@infradead.org \ --cc=robh@kernel.org \ --cc=tony@atomide.com \ --cc=tzimmermann@suse.de \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.