All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM
@ 2022-05-01 16:43 Marek Vasut
  2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Marek Vasut @ 2022-05-01 16:43 UTC (permalink / raw)
  To: u-boot; +Cc: Marek Vasut, Patrick Delaunay, Patrice Chotard, Ramon Fried

The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM
may be extended with other MAC options connected to FMC2 bus, like the
DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of
1468 Bytes instead of 1536 Bytes, which always avoids overflowing the
packet buffers of such limited MACs, which leads to e.g. TFTP timeouts.
This also avoids receiving a short packet fragment at the end of each
TFTP block, which led to reduced performance.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Ramon Fried <rfried.dev@gmail.com>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 -
 configs/stm32mp15_dhcor_basic_defconfig | 1 -
 2 files changed, 2 deletions(-)

diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
index ec955eae200..0ff015cae49 100644
--- a/configs/stm32mp15_dhcom_basic_defconfig
+++ b/configs/stm32mp15_dhcom_basic_defconfig
@@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
index 387e068155e..83614b9fc8e 100644
--- a/configs/stm32mp15_dhcor_basic_defconfig
+++ b/configs/stm32mp15_dhcor_basic_defconfig
@@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM
  2022-05-01 16:43 [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM Marek Vasut
@ 2022-05-01 16:43 ` Marek Vasut
  2022-05-01 18:13   ` Ramon Fried
                     ` (2 more replies)
  2022-05-01 18:12 ` [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE " Ramon Fried
  2022-05-02  8:25 ` Patrick DELAUNAY
  2 siblings, 3 replies; 8+ messages in thread
From: Marek Vasut @ 2022-05-01 16:43 UTC (permalink / raw)
  To: u-boot; +Cc: Marek Vasut, Patrick Delaunay, Patrice Chotard, Ramon Fried

Long TFTP transfers lead to a wall of # characters on UART, which in
the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to
print progress in fewer # characters.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Ramon Fried <rfried.dev@gmail.com>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 +
 configs/stm32mp15_dhcor_basic_defconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
index 0ff015cae49..7f7aecf2510 100644
--- a/configs/stm32mp15_dhcom_basic_defconfig
+++ b/configs/stm32mp15_dhcom_basic_defconfig
@@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
index 83614b9fc8e..35e43a9a2fc 100644
--- a/configs/stm32mp15_dhcor_basic_defconfig
+++ b/configs/stm32mp15_dhcor_basic_defconfig
@@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM
  2022-05-01 16:43 [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM Marek Vasut
  2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
@ 2022-05-01 18:12 ` Ramon Fried
  2022-05-02  8:25 ` Patrick DELAUNAY
  2 siblings, 0 replies; 8+ messages in thread
From: Ramon Fried @ 2022-05-01 18:12 UTC (permalink / raw)
  To: Marek Vasut; +Cc: U-Boot Mailing List, Patrick Delaunay, Patrice Chotard

On Sun, May 1, 2022 at 7:43 PM Marek Vasut <marex@denx.de> wrote:
>
> The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM
> may be extended with other MAC options connected to FMC2 bus, like the
> DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of
> 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the
> packet buffers of such limited MACs, which leads to e.g. TFTP timeouts.
> This also avoids receiving a short packet fragment at the end of each
> TFTP block, which led to reduced performance.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> ---
>  configs/stm32mp15_dhcom_basic_defconfig | 1 -
>  configs/stm32mp15_dhcor_basic_defconfig | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index ec955eae200..0ff015cae49 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_SPL_ENV_IS_NOWHERE=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_IP_DEFRAG=y
> -CONFIG_TFTP_BLOCKSIZE=1536
>  CONFIG_STM32_ADC=y
>  CONFIG_SPL_BLOCK_CACHE=y
>  CONFIG_DFU_MMC=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 387e068155e..83614b9fc8e 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_SPL_ENV_IS_NOWHERE=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_IP_DEFRAG=y
> -CONFIG_TFTP_BLOCKSIZE=1536
>  CONFIG_STM32_ADC=y
>  CONFIG_SPL_BLOCK_CACHE=y
>  CONFIG_DFU_MMC=y
> --
> 2.35.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM
  2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
@ 2022-05-01 18:13   ` Ramon Fried
  2022-05-02  8:32   ` Patrick DELAUNAY
  2022-05-10  7:52   ` Patrice CHOTARD
  2 siblings, 0 replies; 8+ messages in thread
From: Ramon Fried @ 2022-05-01 18:13 UTC (permalink / raw)
  To: Marek Vasut; +Cc: U-Boot Mailing List, Patrick Delaunay, Patrice Chotard

On Sun, May 1, 2022 at 7:43 PM Marek Vasut <marex@denx.de> wrote:
>
> Long TFTP transfers lead to a wall of # characters on UART, which in
> the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to
> print progress in fewer # characters.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> ---
>  configs/stm32mp15_dhcom_basic_defconfig | 1 +
>  configs/stm32mp15_dhcor_basic_defconfig | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index 0ff015cae49..7f7aecf2510 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_SPL_ENV_IS_NOWHERE=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_IP_DEFRAG=y
> +CONFIG_TFTP_TSIZE=y
>  CONFIG_STM32_ADC=y
>  CONFIG_SPL_BLOCK_CACHE=y
>  CONFIG_DFU_MMC=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 83614b9fc8e..35e43a9a2fc 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_SPL_ENV_IS_NOWHERE=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_IP_DEFRAG=y
> +CONFIG_TFTP_TSIZE=y
>  CONFIG_STM32_ADC=y
>  CONFIG_SPL_BLOCK_CACHE=y
>  CONFIG_DFU_MMC=y
> --
> 2.35.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM
  2022-05-01 16:43 [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM Marek Vasut
  2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
  2022-05-01 18:12 ` [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE " Ramon Fried
@ 2022-05-02  8:25 ` Patrick DELAUNAY
  2022-05-10  7:52   ` Patrice CHOTARD
  2 siblings, 1 reply; 8+ messages in thread
From: Patrick DELAUNAY @ 2022-05-02  8:25 UTC (permalink / raw)
  To: Marek Vasut, u-boot; +Cc: Patrice Chotard, Ramon Fried

Hi Marek,

On 5/1/22 18:43, Marek Vasut wrote:
> The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM
> may be extended with other MAC options connected to FMC2 bus, like the
> DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of
> 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the
> packet buffers of such limited MACs, which leads to e.g. TFTP timeouts.
> This also avoids receiving a short packet fragment at the end of each
> TFTP block, which led to reduced performance.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> ---
>   configs/stm32mp15_dhcom_basic_defconfig | 1 -
>   configs/stm32mp15_dhcor_basic_defconfig | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index ec955eae200..0ff015cae49 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_ENV_IS_NOWHERE=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
> -CONFIG_TFTP_BLOCKSIZE=1536
>   CONFIG_STM32_ADC=y
>   CONFIG_SPL_BLOCK_CACHE=y
>   CONFIG_DFU_MMC=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 387e068155e..83614b9fc8e 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_ENV_IS_NOWHERE=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
> -CONFIG_TFTP_BLOCKSIZE=1536
>   CONFIG_STM32_ADC=y
>   CONFIG_SPL_BLOCK_CACHE=y
>   CONFIG_DFU_MMC=y



Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM
  2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
  2022-05-01 18:13   ` Ramon Fried
@ 2022-05-02  8:32   ` Patrick DELAUNAY
  2022-05-10  7:52   ` Patrice CHOTARD
  2 siblings, 0 replies; 8+ messages in thread
From: Patrick DELAUNAY @ 2022-05-02  8:32 UTC (permalink / raw)
  To: Marek Vasut, u-boot; +Cc: Patrice Chotard, Ramon Fried

Hi,

On 5/1/22 18:43, Marek Vasut wrote:
> Long TFTP transfers lead to a wall of # characters on UART, which in
> the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to
> print progress in fewer # characters.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> ---
>   configs/stm32mp15_dhcom_basic_defconfig | 1 +
>   configs/stm32mp15_dhcor_basic_defconfig | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index 0ff015cae49..7f7aecf2510 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_ENV_IS_NOWHERE=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
> +CONFIG_TFTP_TSIZE=y
>   CONFIG_STM32_ADC=y
>   CONFIG_SPL_BLOCK_CACHE=y
>   CONFIG_DFU_MMC=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 83614b9fc8e..35e43a9a2fc 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_ENV_IS_NOWHERE=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
> +CONFIG_TFTP_TSIZE=y
>   CONFIG_STM32_ADC=y
>   CONFIG_SPL_BLOCK_CACHE=y
>   CONFIG_DFU_MMC=y


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick




^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM
  2022-05-02  8:25 ` Patrick DELAUNAY
@ 2022-05-10  7:52   ` Patrice CHOTARD
  0 siblings, 0 replies; 8+ messages in thread
From: Patrice CHOTARD @ 2022-05-10  7:52 UTC (permalink / raw)
  To: Patrick DELAUNAY, Marek Vasut, u-boot; +Cc: Ramon Fried



On 5/2/22 10:25, Patrick DELAUNAY wrote:
> Hi Marek,
> 
> On 5/1/22 18:43, Marek Vasut wrote:
>> The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM
>> may be extended with other MAC options connected to FMC2 bus, like the
>> DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of
>> 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the
>> packet buffers of such limited MACs, which leads to e.g. TFTP timeouts.
>> This also avoids receiving a short packet fragment at the end of each
>> TFTP block, which led to reduced performance.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Ramon Fried <rfried.dev@gmail.com>
>> ---
>>   configs/stm32mp15_dhcom_basic_defconfig | 1 -
>>   configs/stm32mp15_dhcor_basic_defconfig | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
>> index ec955eae200..0ff015cae49 100644
>> --- a/configs/stm32mp15_dhcom_basic_defconfig
>> +++ b/configs/stm32mp15_dhcom_basic_defconfig
>> @@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>   CONFIG_SPL_ENV_IS_NOWHERE=y
>>   CONFIG_NET_RANDOM_ETHADDR=y
>>   CONFIG_IP_DEFRAG=y
>> -CONFIG_TFTP_BLOCKSIZE=1536
>>   CONFIG_STM32_ADC=y
>>   CONFIG_SPL_BLOCK_CACHE=y
>>   CONFIG_DFU_MMC=y
>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
>> index 387e068155e..83614b9fc8e 100644
>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>> @@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>   CONFIG_SPL_ENV_IS_NOWHERE=y
>>   CONFIG_NET_RANDOM_ETHADDR=y
>>   CONFIG_IP_DEFRAG=y
>> -CONFIG_TFTP_BLOCKSIZE=1536
>>   CONFIG_STM32_ADC=y
>>   CONFIG_SPL_BLOCK_CACHE=y
>>   CONFIG_DFU_MMC=y
> 
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
Applied to u-boot-stm32

Thanks
Patrice

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM
  2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
  2022-05-01 18:13   ` Ramon Fried
  2022-05-02  8:32   ` Patrick DELAUNAY
@ 2022-05-10  7:52   ` Patrice CHOTARD
  2 siblings, 0 replies; 8+ messages in thread
From: Patrice CHOTARD @ 2022-05-10  7:52 UTC (permalink / raw)
  To: Marek Vasut, u-boot; +Cc: Patrick Delaunay, Ramon Fried



On 5/1/22 18:43, Marek Vasut wrote:
> Long TFTP transfers lead to a wall of # characters on UART, which in
> the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to
> print progress in fewer # characters.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> ---
>  configs/stm32mp15_dhcom_basic_defconfig | 1 +
>  configs/stm32mp15_dhcor_basic_defconfig | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index 0ff015cae49..7f7aecf2510 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_SPL_ENV_IS_NOWHERE=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_IP_DEFRAG=y
> +CONFIG_TFTP_TSIZE=y
>  CONFIG_STM32_ADC=y
>  CONFIG_SPL_BLOCK_CACHE=y
>  CONFIG_DFU_MMC=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 83614b9fc8e..35e43a9a2fc 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_SPL_ENV_IS_NOWHERE=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_IP_DEFRAG=y
> +CONFIG_TFTP_TSIZE=y
>  CONFIG_STM32_ADC=y
>  CONFIG_SPL_BLOCK_CACHE=y
>  CONFIG_DFU_MMC=y
Applied to u-boot-stm32

Thanks
Patrice

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-10  7:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-01 16:43 [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM Marek Vasut
2022-05-01 16:43 ` [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE " Marek Vasut
2022-05-01 18:13   ` Ramon Fried
2022-05-02  8:32   ` Patrick DELAUNAY
2022-05-10  7:52   ` Patrice CHOTARD
2022-05-01 18:12 ` [PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE " Ramon Fried
2022-05-02  8:25 ` Patrick DELAUNAY
2022-05-10  7:52   ` Patrice CHOTARD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.