From: Lu Baolu <baolu.lu@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Cc: baolu.lu@linux.intel.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
rafael@kernel.org, Diana Craciun <diana.craciun@oss.nxp.com>,
Cornelia Huck <cohuck@redhat.com>,
Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Stuart Yoder <stuyoder@gmail.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jonathan Hunter <jonathanh@nvidia.com>,
Li Yang <leoyang.li@nxp.com>, Dmitry Osipenko <digetx@gmail.com>,
iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 01/14] iommu: Add dma ownership management interfaces
Date: Thu, 6 Jan 2022 11:47:50 +0800 [thread overview]
Message-ID: <8e83da6c-7ae4-b855-ccf0-148d2babfcce@linux.intel.com> (raw)
In-Reply-To: <20220104164100.GA101735@bhelgaas>
On 1/5/22 12:41 AM, Bjorn Helgaas wrote:
>>> Devices under kernel drivers control must call iommu_device_use_dma_api()
>>> before driver probes. The driver binding process must be aborted if it
>>> returns failure.
> "Devices" don't call functions. Drivers do, or in this case, it looks
> like the bus DMA code (platform, amba, fsl, pci, etc).
>
> These functions are EXPORT_SYMBOL_GPL(), but it looks like all the
> callers are built-in, so maybe the export is unnecessary?
Yes. If all callers are built-in, we can remove this export.
>
> You use "iommu"/"IOMMU" and "dma"/"DMA" interchangeably above. Would
> be easier to read if you picked one.
>
I should cleanup all these. I also realized that I forgot to
cleanup some typos you pointed out in v4:
https://lore.kernel.org/linux-iommu/20211229211626.GA1701512@bhelgaas/
Sorry about it. I will take care of all these in the next version.
Best regards,
baolu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Cc: Stuart Yoder <stuyoder@gmail.com>,
rafael@kernel.org, David Airlie <airlied@linux.ie>,
linux-pci@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Dmitry Osipenko <digetx@gmail.com>, Will Deacon <will@kernel.org>,
Ashok Raj <ashok.raj@intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
iommu@lists.linux-foundation.org,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Daniel Vetter <daniel@ffwll.ch>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v5 01/14] iommu: Add dma ownership management interfaces
Date: Thu, 6 Jan 2022 11:47:50 +0800 [thread overview]
Message-ID: <8e83da6c-7ae4-b855-ccf0-148d2babfcce@linux.intel.com> (raw)
In-Reply-To: <20220104164100.GA101735@bhelgaas>
On 1/5/22 12:41 AM, Bjorn Helgaas wrote:
>>> Devices under kernel drivers control must call iommu_device_use_dma_api()
>>> before driver probes. The driver binding process must be aborted if it
>>> returns failure.
> "Devices" don't call functions. Drivers do, or in this case, it looks
> like the bus DMA code (platform, amba, fsl, pci, etc).
>
> These functions are EXPORT_SYMBOL_GPL(), but it looks like all the
> callers are built-in, so maybe the export is unnecessary?
Yes. If all callers are built-in, we can remove this export.
>
> You use "iommu"/"IOMMU" and "dma"/"DMA" interchangeably above. Would
> be easier to read if you picked one.
>
I should cleanup all these. I also realized that I forgot to
cleanup some typos you pointed out in v4:
https://lore.kernel.org/linux-iommu/20211229211626.GA1701512@bhelgaas/
Sorry about it. I will take care of all these in the next version.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-01-06 3:48 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 1:56 [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 01/14] iommu: Add dma ownership management interfaces Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 10:08 ` Christoph Hellwig
2022-01-04 10:08 ` Christoph Hellwig
2022-01-04 16:41 ` Bjorn Helgaas
2022-01-04 16:41 ` Bjorn Helgaas
2022-01-04 19:23 ` Jason Gunthorpe
2022-01-04 19:23 ` Jason Gunthorpe via iommu
2022-01-06 3:18 ` Lu Baolu
2022-01-06 3:18 ` Lu Baolu
2022-01-06 3:54 ` Lu Baolu
2022-01-06 3:54 ` Lu Baolu
2022-01-06 15:46 ` Jason Gunthorpe
2022-01-06 15:46 ` Jason Gunthorpe via iommu
2022-01-07 1:50 ` Lu Baolu
2022-01-07 1:50 ` Lu Baolu
2022-01-06 3:43 ` Lu Baolu
2022-01-06 3:43 ` Lu Baolu
2022-01-06 3:47 ` Lu Baolu [this message]
2022-01-06 3:47 ` Lu Baolu
2022-01-06 3:51 ` Lu Baolu
2022-01-06 3:51 ` Lu Baolu
2022-01-05 6:57 ` Lu Baolu
2022-01-05 6:57 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 02/14] driver core: Add dma_cleanup callback in bus_type Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 10:08 ` Christoph Hellwig
2022-01-04 10:08 ` Christoph Hellwig
2022-01-04 12:39 ` Jason Gunthorpe
2022-01-04 12:39 ` Jason Gunthorpe via iommu
2022-01-04 13:04 ` Greg Kroah-Hartman
2022-01-04 13:04 ` Greg Kroah-Hartman
2022-02-08 5:55 ` Lu Baolu
2022-02-08 5:55 ` Lu Baolu
2022-02-08 11:35 ` Greg Kroah-Hartman
2022-02-08 11:35 ` Greg Kroah-Hartman
2022-02-14 10:01 ` Greg Kroah-Hartman
2022-02-14 10:01 ` Greg Kroah-Hartman
2022-02-14 10:02 ` Greg Kroah-Hartman
2022-02-14 10:02 ` Greg Kroah-Hartman
2022-01-04 1:56 ` [PATCH v5 03/14] amba: Stop sharing platform_dma_configure() Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 04/14] driver core: platform: Add driver dma ownership management Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-02-14 9:59 ` Greg Kroah-Hartman
2022-02-14 9:59 ` Greg Kroah-Hartman
2022-02-14 13:18 ` Jason Gunthorpe
2022-02-14 13:18 ` Jason Gunthorpe via iommu
2022-02-14 13:37 ` Greg Kroah-Hartman
2022-02-14 13:37 ` Greg Kroah-Hartman
2022-02-14 13:43 ` Jason Gunthorpe
2022-02-14 13:43 ` Jason Gunthorpe via iommu
2022-01-04 1:56 ` [PATCH v5 05/14] amba: " Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 06/14] bus: fsl-mc: " Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 07/14] PCI: " Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-02-14 10:03 ` Greg Kroah-Hartman
2022-02-14 10:03 ` Greg Kroah-Hartman
2022-02-14 12:38 ` Jason Gunthorpe
2022-02-14 12:38 ` Jason Gunthorpe via iommu
2022-02-14 12:51 ` Greg Kroah-Hartman
2022-02-14 12:51 ` Greg Kroah-Hartman
2022-02-14 13:11 ` Jason Gunthorpe
2022-02-14 13:11 ` Jason Gunthorpe via iommu
2022-02-14 13:39 ` Greg Kroah-Hartman
2022-02-14 13:39 ` Greg Kroah-Hartman
2022-02-14 13:43 ` Jason Gunthorpe
2022-02-14 13:43 ` Jason Gunthorpe via iommu
2022-02-15 3:06 ` Lu Baolu
2022-02-15 3:06 ` Lu Baolu
2022-02-23 18:00 ` Bjorn Helgaas
2022-02-23 18:00 ` Bjorn Helgaas
2022-02-23 18:07 ` Jason Gunthorpe
2022-02-23 18:07 ` Jason Gunthorpe via iommu
2022-01-04 1:56 ` [PATCH v5 08/14] PCI: pci_stub: Suppress kernel DMA ownership auto-claiming Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 09/14] PCI: portdrv: " Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 17:06 ` Bjorn Helgaas
2022-01-04 17:06 ` Bjorn Helgaas
2022-01-04 19:26 ` Jason Gunthorpe
2022-01-04 19:26 ` Jason Gunthorpe via iommu
2022-01-04 19:51 ` Bjorn Helgaas
2022-01-04 19:51 ` Bjorn Helgaas
2022-01-05 0:35 ` Jason Gunthorpe
2022-01-05 0:35 ` Jason Gunthorpe via iommu
2022-01-06 4:12 ` Lu Baolu
2022-01-06 4:12 ` Lu Baolu
2022-01-06 18:32 ` Bjorn Helgaas
2022-01-06 18:32 ` Bjorn Helgaas
2022-01-07 1:53 ` Lu Baolu
2022-01-07 1:53 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 10/14] vfio: Set DMA ownership for VFIO devices Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 11/14] vfio: Remove use of vfio_group_viable() Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 12/14] vfio: Delete the unbound_list Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 13/14] vfio: Remove iommu group notifier Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 14/14] iommu: Remove iommu group changes notifier Lu Baolu
2022-01-04 1:56 ` Lu Baolu
2022-01-04 12:48 ` [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() Jason Gunthorpe
2022-01-04 12:48 ` Jason Gunthorpe via iommu
2022-01-05 6:52 ` Lu Baolu
2022-01-05 6:52 ` Lu Baolu
2022-02-18 1:07 ` Lu Baolu
2022-02-18 1:07 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e83da6c-7ae4-b855-ccf0-148d2babfcce@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=digetx@gmail.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kch@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stuyoder@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.