From: Benjamin Gaignard <benjamin.gaignard@collabora.com> To: Hans Verkuil <hverkuil-cisco@xs4all.nl>, mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk Subject: Re: [RFC v2 0/8] Move HEVC stateless controls out of staging Date: Fri, 18 Feb 2022 11:54:27 +0100 [thread overview] Message-ID: <8ea4b561-2d46-3d40-73a1-2fe4d92c095d@collabora.com> (raw) In-Reply-To: <d33e96db-8cd0-08a5-7e73-742187ea6de5@xs4all.nl> Le 18/02/2022 à 10:59, Hans Verkuil a écrit : > Hi Benjamin, > > On 15/02/2022 12:00, Benjamin Gaignard wrote: >> This series aims to make HEVC uapi stable and usable for hardware >> decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) >> and 2 out of the tree drivers (rkvdec and RPI). >> >> The 3 first patches are from Hans to implement v4l2 dynamic control >> feature which is need by patch 7 for V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET >> definition. >> >> Patch 4 move the existing uapi to stable, including definitions renaming >> and CID number change to fit with v4l2 naming. >> >> Patches 5 and 7 add fields needed for rkvdec and RPI decoders. >> >> Patches 6 is cleaning up the uapi of useless field. >> Patches 8 change one field description and name to define offset by >> bytes rather than by bits > I have some housekeeping questions: > > I have several older HEVC-related patches from you, which of those are still > valid? > > "[v4,0/9] Additional features for Hantro HEVC": > https://patchwork.linuxtv.org/project/linux-media/cover/20210625141143.577998-1-benjamin.gaignard@collabora.com/ > > "media: hevc: fix pictures lists type": > https://patchwork.linuxtv.org/project/linux-media/patch/20210823082949.237716-1-benjamin.gaignard@collabora.com/ > > "media: hantro: Trace hevc hw cycles performance register": > https://patchwork.linuxtv.org/project/linux-media/patch/20210823135606.633052-1-benjamin.gaignard@collabora.com/ > > "media: hantro: Add support of compressed reference buffers" > https://patchwork.linuxtv.org/project/linux-media/patch/20210823162916.824336-1-benjamin.gaignard@collabora.com/ > > Before moving the HEVC API out of staging I would prefer to have any remaining > issues fixed. So one series that adds any remaining fixes (i.e. from the older patches > mentioned above), and a second series on top that moves it out of staging. Hi Hans, They are all related to Hantro diver and, after post-proc patches, the internal driver design has change so they won't apply anymore. You can discard them. HEVC UAPI migration isn't not impacted by these patches. My plan is a finish the HEVC UAPI first, send patches to add features (compression, 10bits, scaling) to Hantro driver and finally move it out of staging too. If possible I would like to not make HEVC UAPI topic depends of Hantro features. Does that makes sense for you ? Regards, Benjamin > > That way I can mark the older patches as Superseded, and we have a > fresh series that we can discuss. > > Regards, > > Hans > >> Benjamin >> >> Benjamin Gaignard (5): >> media: uapi: Move HEVC stateless controls out of staging >> media: uapi: Add fields needed for RKVDEC driver >> media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params >> media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control >> media: uapi: Change data_bit_offset definition >> >> Hans Verkuil (3): >> videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY >> v4l2-ctrls: add support for dynamically allocated arrays. >> vivid: add dynamic array test control >> >> .../userspace-api/media/drivers/hantro.rst | 5 - >> .../media/v4l/ext-ctrls-codec.rst | 58 ++-- >> .../media/v4l/vidioc-queryctrl.rst | 8 + >> .../media/test-drivers/vivid/vivid-ctrls.c | 15 ++ >> drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++++++-- >> drivers/media/v4l2-core/v4l2-ctrls-core.c | 182 ++++++++++--- >> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 32 +-- >> drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- >> drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- >> drivers/staging/media/hantro/hantro_drv.c | 27 +- >> drivers/staging/media/hantro/hantro_hevc.c | 8 +- >> drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- >> .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- >> .../staging/media/sunxi/cedrus/cedrus_h265.c | 13 +- >> include/linux/hantro-media.h | 17 ++ >> include/media/hevc-ctrls.h | 250 ------------------ >> include/media/v4l2-ctrls.h | 48 +++- >> include/uapi/linux/v4l2-controls.h | 224 ++++++++++++++++ >> include/uapi/linux/videodev2.h | 8 + >> 19 files changed, 640 insertions(+), 408 deletions(-) >> create mode 100644 include/linux/hantro-media.h >> delete mode 100644 include/media/hevc-ctrls.h >>
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@collabora.com> To: Hans Verkuil <hverkuil-cisco@xs4all.nl>, mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk Subject: Re: [RFC v2 0/8] Move HEVC stateless controls out of staging Date: Fri, 18 Feb 2022 11:54:27 +0100 [thread overview] Message-ID: <8ea4b561-2d46-3d40-73a1-2fe4d92c095d@collabora.com> (raw) In-Reply-To: <d33e96db-8cd0-08a5-7e73-742187ea6de5@xs4all.nl> Le 18/02/2022 à 10:59, Hans Verkuil a écrit : > Hi Benjamin, > > On 15/02/2022 12:00, Benjamin Gaignard wrote: >> This series aims to make HEVC uapi stable and usable for hardware >> decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) >> and 2 out of the tree drivers (rkvdec and RPI). >> >> The 3 first patches are from Hans to implement v4l2 dynamic control >> feature which is need by patch 7 for V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET >> definition. >> >> Patch 4 move the existing uapi to stable, including definitions renaming >> and CID number change to fit with v4l2 naming. >> >> Patches 5 and 7 add fields needed for rkvdec and RPI decoders. >> >> Patches 6 is cleaning up the uapi of useless field. >> Patches 8 change one field description and name to define offset by >> bytes rather than by bits > I have some housekeeping questions: > > I have several older HEVC-related patches from you, which of those are still > valid? > > "[v4,0/9] Additional features for Hantro HEVC": > https://patchwork.linuxtv.org/project/linux-media/cover/20210625141143.577998-1-benjamin.gaignard@collabora.com/ > > "media: hevc: fix pictures lists type": > https://patchwork.linuxtv.org/project/linux-media/patch/20210823082949.237716-1-benjamin.gaignard@collabora.com/ > > "media: hantro: Trace hevc hw cycles performance register": > https://patchwork.linuxtv.org/project/linux-media/patch/20210823135606.633052-1-benjamin.gaignard@collabora.com/ > > "media: hantro: Add support of compressed reference buffers" > https://patchwork.linuxtv.org/project/linux-media/patch/20210823162916.824336-1-benjamin.gaignard@collabora.com/ > > Before moving the HEVC API out of staging I would prefer to have any remaining > issues fixed. So one series that adds any remaining fixes (i.e. from the older patches > mentioned above), and a second series on top that moves it out of staging. Hi Hans, They are all related to Hantro diver and, after post-proc patches, the internal driver design has change so they won't apply anymore. You can discard them. HEVC UAPI migration isn't not impacted by these patches. My plan is a finish the HEVC UAPI first, send patches to add features (compression, 10bits, scaling) to Hantro driver and finally move it out of staging too. If possible I would like to not make HEVC UAPI topic depends of Hantro features. Does that makes sense for you ? Regards, Benjamin > > That way I can mark the older patches as Superseded, and we have a > fresh series that we can discuss. > > Regards, > > Hans > >> Benjamin >> >> Benjamin Gaignard (5): >> media: uapi: Move HEVC stateless controls out of staging >> media: uapi: Add fields needed for RKVDEC driver >> media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params >> media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control >> media: uapi: Change data_bit_offset definition >> >> Hans Verkuil (3): >> videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY >> v4l2-ctrls: add support for dynamically allocated arrays. >> vivid: add dynamic array test control >> >> .../userspace-api/media/drivers/hantro.rst | 5 - >> .../media/v4l/ext-ctrls-codec.rst | 58 ++-- >> .../media/v4l/vidioc-queryctrl.rst | 8 + >> .../media/test-drivers/vivid/vivid-ctrls.c | 15 ++ >> drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++++++-- >> drivers/media/v4l2-core/v4l2-ctrls-core.c | 182 ++++++++++--- >> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 32 +-- >> drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- >> drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- >> drivers/staging/media/hantro/hantro_drv.c | 27 +- >> drivers/staging/media/hantro/hantro_hevc.c | 8 +- >> drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- >> .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- >> .../staging/media/sunxi/cedrus/cedrus_h265.c | 13 +- >> include/linux/hantro-media.h | 17 ++ >> include/media/hevc-ctrls.h | 250 ------------------ >> include/media/v4l2-ctrls.h | 48 +++- >> include/uapi/linux/v4l2-controls.h | 224 ++++++++++++++++ >> include/uapi/linux/videodev2.h | 8 + >> 19 files changed, 640 insertions(+), 408 deletions(-) >> create mode 100644 include/linux/hantro-media.h >> delete mode 100644 include/media/hevc-ctrls.h >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-18 10:54 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-15 11:00 [RFC v2 0/8] Move HEVC stateless controls out of staging Benjamin Gaignard 2022-02-15 11:00 ` Benjamin Gaignard 2022-02-15 11:00 ` [RFC v2 1/8] videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY Benjamin Gaignard 2022-02-15 11:00 ` Benjamin Gaignard 2022-02-15 11:00 ` [RFC v2 2/8] v4l2-ctrls: add support for dynamically allocated arrays Benjamin Gaignard 2022-02-15 11:00 ` Benjamin Gaignard 2022-02-15 11:00 ` [RFC v2 3/8] vivid: add dynamic array test control Benjamin Gaignard 2022-02-15 11:00 ` Benjamin Gaignard 2022-02-15 11:00 ` [RFC v2 4/8] media: uapi: Move HEVC stateless controls out of staging Benjamin Gaignard 2022-02-15 11:00 ` Benjamin Gaignard 2022-02-15 18:02 ` Sebastian Fricke 2022-02-15 18:02 ` Sebastian Fricke 2022-02-18 11:50 ` Hans Verkuil 2022-02-18 11:50 ` Hans Verkuil 2022-02-15 11:01 ` [RFC v2 5/8] media: uapi: Add fields needed for RKVDEC driver Benjamin Gaignard 2022-02-15 11:01 ` Benjamin Gaignard 2022-02-18 11:32 ` Hans Verkuil 2022-02-18 11:32 ` Hans Verkuil 2022-02-18 12:19 ` Benjamin Gaignard 2022-02-18 12:19 ` Benjamin Gaignard 2022-02-18 12:22 ` Hans Verkuil 2022-02-18 12:22 ` Hans Verkuil 2022-02-18 12:30 ` Benjamin Gaignard 2022-02-18 12:30 ` Benjamin Gaignard 2022-02-18 12:32 ` Hans Verkuil 2022-02-18 12:32 ` Hans Verkuil 2022-02-15 11:01 ` [RFC v2 6/8] media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params Benjamin Gaignard 2022-02-15 11:01 ` Benjamin Gaignard 2022-02-15 14:17 ` John Cox 2022-02-15 14:17 ` John Cox 2022-02-15 14:35 ` Benjamin Gaignard 2022-02-15 14:35 ` Benjamin Gaignard 2022-02-15 14:50 ` John Cox 2022-02-15 14:50 ` John Cox 2022-02-15 14:57 ` Benjamin Gaignard 2022-02-15 14:57 ` Benjamin Gaignard 2022-02-15 15:28 ` Nicolas Dufresne 2022-02-15 15:28 ` Nicolas Dufresne 2022-02-15 16:00 ` John Cox 2022-02-15 16:00 ` John Cox 2022-02-15 16:11 ` Jernej Škrabec 2022-02-15 16:11 ` Jernej Škrabec 2022-02-15 16:31 ` John Cox 2022-02-15 16:31 ` John Cox 2022-02-15 20:27 ` Jernej Škrabec 2022-02-15 20:27 ` Jernej Škrabec 2022-02-16 10:38 ` John Cox 2022-02-16 10:38 ` John Cox 2022-02-15 11:01 ` [RFC v2 7/8] media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control Benjamin Gaignard 2022-02-15 11:01 ` Benjamin Gaignard 2022-02-16 10:54 ` John Cox 2022-02-16 10:54 ` John Cox 2022-02-16 17:19 ` Benjamin Gaignard 2022-02-16 17:19 ` Benjamin Gaignard 2022-02-16 17:35 ` John Cox 2022-02-16 17:35 ` John Cox 2022-02-15 11:01 ` [RFC v2 8/8] media: uapi: Change data_bit_offset definition Benjamin Gaignard 2022-02-15 11:01 ` Benjamin Gaignard 2022-02-15 13:01 ` [RFC v2 0/8] Move HEVC stateless controls out of staging Sebastian Fricke 2022-02-15 13:01 ` Sebastian Fricke 2022-02-15 13:24 ` Benjamin Gaignard 2022-02-15 13:24 ` Benjamin Gaignard 2022-02-15 16:14 ` Jernej Škrabec 2022-02-15 16:14 ` Jernej Škrabec 2022-02-18 9:59 ` Hans Verkuil 2022-02-18 9:59 ` Hans Verkuil 2022-02-18 10:54 ` Benjamin Gaignard [this message] 2022-02-18 10:54 ` Benjamin Gaignard 2022-02-18 11:05 ` Hans Verkuil 2022-02-18 11:05 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8ea4b561-2d46-3d40-73a1-2fe4d92c095d@collabora.com \ --to=benjamin.gaignard@collabora.com \ --cc=ezequiel@vanguardiasur.com.ar \ --cc=gregkh@linuxfoundation.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=jc@kynesim.co.uk \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=kernel@collabora.com \ --cc=knaerzche@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=linux-sunxi@lists.linux.dev \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=nicolas@ndufresne.ca \ --cc=p.zabel@pengutronix.de \ --cc=paul.kocialkowski@bootlin.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.