From: David Hildenbrand <david@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, philmd@redhat.com, peterx@redhat.com
Subject: Re: [PATCH] remote/memory: Replace share parameter with ram_flags
Date: Thu, 8 Jul 2021 09:26:17 +0200 [thread overview]
Message-ID: <8ea4cb21-e69e-2846-1300-88a9cebf7758@redhat.com> (raw)
In-Reply-To: <20210708071216.87862-1-yang.zhong@intel.com>
On 08.07.21 09:12, Yang Zhong wrote:
> The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> in the hw/remote/memory.c.
Yes, seems like that call was added just after I crafted my patches:
Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
qemu_ram_alloc_from_fd()")
Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks!
>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> ---
> hw/remote/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/remote/memory.c b/hw/remote/memory.c
> index 472ed2a272..6e21ab1a45 100644
> --- a/hw/remote/memory.c
> +++ b/hw/remote/memory.c
> @@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
> subregion = g_new(MemoryRegion, 1);
> memory_region_init_ram_from_fd(subregion, NULL,
> name, sysmem_info->sizes[region],
> - true, msg->fds[region],
> + RAM_SHARED, msg->fds[region],
> sysmem_info->offsets[region],
> errp);
>
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-07-08 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 7:12 [PATCH] remote/memory: Replace share parameter with ram_flags Yang Zhong
2021-07-08 7:26 ` David Hildenbrand [this message]
2021-07-08 7:34 ` Yang Zhong
2021-07-08 18:48 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea4cb21-e69e-2846-1300-88a9cebf7758@redhat.com \
--to=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.