[PATCH] remote/memory: Replace share parameter with ram_flags

[PATCH] remote/memory: Replace share parameter with ram_flags

[Yang Zhong]

The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
in the hw/remote/memory.c.

Signed-off-by: Yang Zhong <yang.zhong@intel.com>
---
 hw/remote/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/remote/memory.c b/hw/remote/memory.c
index 472ed2a272..6e21ab1a45 100644
--- a/hw/remote/memory.c
+++ b/hw/remote/memory.c
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
         subregion = g_new(MemoryRegion, 1);
         memory_region_init_ram_from_fd(subregion, NULL,
                                        name, sysmem_info->sizes[region],
-                                       true, msg->fds[region],
+                                       RAM_SHARED, msg->fds[region],
                                        sysmem_info->offsets[region],
                                        errp);
 
-- 
2.29.2.334.gfaefdd61ec

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

[David Hildenbrand]

On 08.07.21 09:12, Yang Zhong wrote:
> The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> in the hw/remote/memory.c.

Yes, seems like that call was added just after I crafted my patches:

Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to 
qemu_ram_alloc_from_fd()")
Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!

> 
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> ---
>   hw/remote/memory.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/remote/memory.c b/hw/remote/memory.c
> index 472ed2a272..6e21ab1a45 100644
> --- a/hw/remote/memory.c
> +++ b/hw/remote/memory.c
> @@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
>           subregion = g_new(MemoryRegion, 1);
>           memory_region_init_ram_from_fd(subregion, NULL,
>                                          name, sysmem_info->sizes[region],
> -                                       true, msg->fds[region],
> +                                       RAM_SHARED, msg->fds[region],
>                                          sysmem_info->offsets[region],
>                                          errp);
>   
> 


-- 
Thanks,

David / dhildenb

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

[Yang Zhong]

On Thu, Jul 08, 2021 at 09:26:17AM +0200, David Hildenbrand wrote:
> On 08.07.21 09:12, Yang Zhong wrote:
> >The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> >in the hw/remote/memory.c.
> 
> Yes, seems like that call was added just after I crafted my patches:
> 
> Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
> qemu_ram_alloc_from_fd()")
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
 
  Thanks David, if there is not any other comments, i will send the new
  version according to your commit info. thanks!

  Yang

 
> Thanks!
> 
> >
> >Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> >---
> >  hw/remote/memory.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/hw/remote/memory.c b/hw/remote/memory.c
> >index 472ed2a272..6e21ab1a45 100644
> >--- a/hw/remote/memory.c
> >+++ b/hw/remote/memory.c
> >@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
> >          subregion = g_new(MemoryRegion, 1);
> >          memory_region_init_ram_from_fd(subregion, NULL,
> >                                         name, sysmem_info->sizes[region],
> >-                                       true, msg->fds[region],
> >+                                       RAM_SHARED, msg->fds[region],
> >                                         sysmem_info->offsets[region],
> >                                         errp);
> >
> 
> 
> -- 
> Thanks,
> 
> David / dhildenb

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

[Peter Xu]

On Thu, Jul 08, 2021 at 03:12:16PM +0800, Yang Zhong wrote:
> The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> in the hw/remote/memory.c.
> 
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu