All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02  8:53 ` Keqian Zhu
  0 siblings, 0 replies; 9+ messages in thread
From: Keqian Zhu @ 2021-02-02  8:53 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, iommu
  Cc: Will Deacon, Alex Williamson, Marc Zyngier, wanghaibin.wang, jiangkunkun

Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
---
 include/linux/iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 77e561ed57fd..e8f2efae212b 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -68,7 +68,7 @@ struct iommu_domain_geometry {
  *				  devices
  *	IOMMU_DOMAIN_IDENTITY	- DMA addresses are system physical addresses
  *	IOMMU_DOMAIN_UNMANAGED	- DMA mappings managed by IOMMU-API user, used
- *				  for VMs
+ *				  for VMs or userspace driver frameworks
  *	IOMMU_DOMAIN_DMA	- Internally used for DMA-API implementations.
  *				  This flag allows IOMMU drivers to implement
  *				  certain optimizations for these domains
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02  8:53 ` Keqian Zhu
  0 siblings, 0 replies; 9+ messages in thread
From: Keqian Zhu @ 2021-02-02  8:53 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang

Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
---
 include/linux/iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 77e561ed57fd..e8f2efae212b 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -68,7 +68,7 @@ struct iommu_domain_geometry {
  *				  devices
  *	IOMMU_DOMAIN_IDENTITY	- DMA addresses are system physical addresses
  *	IOMMU_DOMAIN_UNMANAGED	- DMA mappings managed by IOMMU-API user, used
- *				  for VMs
+ *				  for VMs or userspace driver frameworks
  *	IOMMU_DOMAIN_DMA	- Internally used for DMA-API implementations.
  *				  This flag allows IOMMU drivers to implement
  *				  certain optimizations for these domains
-- 
2.19.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02  8:53 ` Keqian Zhu
  0 siblings, 0 replies; 9+ messages in thread
From: Keqian Zhu @ 2021-02-02  8:53 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang

Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
---
 include/linux/iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 77e561ed57fd..e8f2efae212b 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -68,7 +68,7 @@ struct iommu_domain_geometry {
  *				  devices
  *	IOMMU_DOMAIN_IDENTITY	- DMA addresses are system physical addresses
  *	IOMMU_DOMAIN_UNMANAGED	- DMA mappings managed by IOMMU-API user, used
- *				  for VMs
+ *				  for VMs or userspace driver frameworks
  *	IOMMU_DOMAIN_DMA	- Internally used for DMA-API implementations.
  *				  This flag allows IOMMU drivers to implement
  *				  certain optimizations for these domains
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
  2021-02-02  8:53 ` Keqian Zhu
  (?)
@ 2021-02-02 12:58   ` Robin Murphy
  -1 siblings, 0 replies; 9+ messages in thread
From: Robin Murphy @ 2021-02-02 12:58 UTC (permalink / raw)
  To: Keqian Zhu, linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang

On 2021-02-02 08:53, Keqian Zhu wrote:
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> ---
>   include/linux/iommu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 77e561ed57fd..e8f2efae212b 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -68,7 +68,7 @@ struct iommu_domain_geometry {
>    *				  devices
>    *	IOMMU_DOMAIN_IDENTITY	- DMA addresses are system physical addresses
>    *	IOMMU_DOMAIN_UNMANAGED	- DMA mappings managed by IOMMU-API user, used
> - *				  for VMs
> + *				  for VMs or userspace driver frameworks

Given that "VMs" effectively has to mean VFIO, doesn't it effectively 
already imply other uses of VFIO anyway? Unmanaged domains are also used 
in other subsystems/drivers inside the kernel and we're not naming 
those, so I don't see that it's particularly helpful to specifically 
call out one more VFIO use-case.

Perhaps the current wording could be generalised a little more, but we 
certainly don't want to start trying to maintain an exhaustive list of 
users here...

Robin.

>    *	IOMMU_DOMAIN_DMA	- Internally used for DMA-API implementations.
>    *				  This flag allows IOMMU drivers to implement
>    *				  certain optimizations for these domains
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02 12:58   ` Robin Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Robin Murphy @ 2021-02-02 12:58 UTC (permalink / raw)
  To: Keqian Zhu, linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang

On 2021-02-02 08:53, Keqian Zhu wrote:
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> ---
>   include/linux/iommu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 77e561ed57fd..e8f2efae212b 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -68,7 +68,7 @@ struct iommu_domain_geometry {
>    *				  devices
>    *	IOMMU_DOMAIN_IDENTITY	- DMA addresses are system physical addresses
>    *	IOMMU_DOMAIN_UNMANAGED	- DMA mappings managed by IOMMU-API user, used
> - *				  for VMs
> + *				  for VMs or userspace driver frameworks

Given that "VMs" effectively has to mean VFIO, doesn't it effectively 
already imply other uses of VFIO anyway? Unmanaged domains are also used 
in other subsystems/drivers inside the kernel and we're not naming 
those, so I don't see that it's particularly helpful to specifically 
call out one more VFIO use-case.

Perhaps the current wording could be generalised a little more, but we 
certainly don't want to start trying to maintain an exhaustive list of 
users here...

Robin.

>    *	IOMMU_DOMAIN_DMA	- Internally used for DMA-API implementations.
>    *				  This flag allows IOMMU drivers to implement
>    *				  certain optimizations for these domains
> 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02 12:58   ` Robin Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Robin Murphy @ 2021-02-02 12:58 UTC (permalink / raw)
  To: Keqian Zhu, linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang

On 2021-02-02 08:53, Keqian Zhu wrote:
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> ---
>   include/linux/iommu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 77e561ed57fd..e8f2efae212b 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -68,7 +68,7 @@ struct iommu_domain_geometry {
>    *				  devices
>    *	IOMMU_DOMAIN_IDENTITY	- DMA addresses are system physical addresses
>    *	IOMMU_DOMAIN_UNMANAGED	- DMA mappings managed by IOMMU-API user, used
> - *				  for VMs
> + *				  for VMs or userspace driver frameworks

Given that "VMs" effectively has to mean VFIO, doesn't it effectively 
already imply other uses of VFIO anyway? Unmanaged domains are also used 
in other subsystems/drivers inside the kernel and we're not naming 
those, so I don't see that it's particularly helpful to specifically 
call out one more VFIO use-case.

Perhaps the current wording could be generalised a little more, but we 
certainly don't want to start trying to maintain an exhaustive list of 
users here...

Robin.

>    *	IOMMU_DOMAIN_DMA	- Internally used for DMA-API implementations.
>    *				  This flag allows IOMMU drivers to implement
>    *				  certain optimizations for these domains
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
  2021-02-02 12:58   ` Robin Murphy
  (?)
@ 2021-02-02 13:14     ` Keqian Zhu
  -1 siblings, 0 replies; 9+ messages in thread
From: Keqian Zhu @ 2021-02-02 13:14 UTC (permalink / raw)
  To: Robin Murphy, linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang



On 2021/2/2 20:58, Robin Murphy wrote:
> On 2021-02-02 08:53, Keqian Zhu wrote:
>> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
>> ---
>>   include/linux/iommu.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 77e561ed57fd..e8f2efae212b 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -68,7 +68,7 @@ struct iommu_domain_geometry {
>>    *                  devices
>>    *    IOMMU_DOMAIN_IDENTITY    - DMA addresses are system physical addresses
>>    *    IOMMU_DOMAIN_UNMANAGED    - DMA mappings managed by IOMMU-API user, used
>> - *                  for VMs
>> + *                  for VMs or userspace driver frameworks
> 
> Given that "VMs" effectively has to mean VFIO, doesn't it effectively already imply other uses of VFIO anyway? Unmanaged domains are also used in other subsystems/drivers inside the kernel and we're not naming those, so I don't see that it's particularly helpful to specifically call out one more VFIO use-case.
> 
> Perhaps the current wording could be generalised a little more, but we certainly don't want to start trying to maintain an exhaustive list of users here...
Yep, a more generalised description is better. After I have a look at all the use cases...

Thanks,
Keqian

> 
> Robin.
> 
>>    *    IOMMU_DOMAIN_DMA    - Internally used for DMA-API implementations.
>>    *                  This flag allows IOMMU drivers to implement
>>    *                  certain optimizations for these domains
>>
> .
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02 13:14     ` Keqian Zhu
  0 siblings, 0 replies; 9+ messages in thread
From: Keqian Zhu @ 2021-02-02 13:14 UTC (permalink / raw)
  To: Robin Murphy, linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang



On 2021/2/2 20:58, Robin Murphy wrote:
> On 2021-02-02 08:53, Keqian Zhu wrote:
>> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
>> ---
>>   include/linux/iommu.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 77e561ed57fd..e8f2efae212b 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -68,7 +68,7 @@ struct iommu_domain_geometry {
>>    *                  devices
>>    *    IOMMU_DOMAIN_IDENTITY    - DMA addresses are system physical addresses
>>    *    IOMMU_DOMAIN_UNMANAGED    - DMA mappings managed by IOMMU-API user, used
>> - *                  for VMs
>> + *                  for VMs or userspace driver frameworks
> 
> Given that "VMs" effectively has to mean VFIO, doesn't it effectively already imply other uses of VFIO anyway? Unmanaged domains are also used in other subsystems/drivers inside the kernel and we're not naming those, so I don't see that it's particularly helpful to specifically call out one more VFIO use-case.
> 
> Perhaps the current wording could be generalised a little more, but we certainly don't want to start trying to maintain an exhaustive list of users here...
Yep, a more generalised description is better. After I have a look at all the use cases...

Thanks,
Keqian

> 
> Robin.
> 
>>    *    IOMMU_DOMAIN_DMA    - Internally used for DMA-API implementations.
>>    *                  This flag allows IOMMU drivers to implement
>>    *                  certain optimizations for these domains
>>
> .
> 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED
@ 2021-02-02 13:14     ` Keqian Zhu
  0 siblings, 0 replies; 9+ messages in thread
From: Keqian Zhu @ 2021-02-02 13:14 UTC (permalink / raw)
  To: Robin Murphy, linux-kernel, linux-arm-kernel, iommu
  Cc: Marc Zyngier, Alex Williamson, jiangkunkun, Will Deacon, wanghaibin.wang



On 2021/2/2 20:58, Robin Murphy wrote:
> On 2021-02-02 08:53, Keqian Zhu wrote:
>> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
>> ---
>>   include/linux/iommu.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 77e561ed57fd..e8f2efae212b 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -68,7 +68,7 @@ struct iommu_domain_geometry {
>>    *                  devices
>>    *    IOMMU_DOMAIN_IDENTITY    - DMA addresses are system physical addresses
>>    *    IOMMU_DOMAIN_UNMANAGED    - DMA mappings managed by IOMMU-API user, used
>> - *                  for VMs
>> + *                  for VMs or userspace driver frameworks
> 
> Given that "VMs" effectively has to mean VFIO, doesn't it effectively already imply other uses of VFIO anyway? Unmanaged domains are also used in other subsystems/drivers inside the kernel and we're not naming those, so I don't see that it's particularly helpful to specifically call out one more VFIO use-case.
> 
> Perhaps the current wording could be generalised a little more, but we certainly don't want to start trying to maintain an exhaustive list of users here...
Yep, a more generalised description is better. After I have a look at all the use cases...

Thanks,
Keqian

> 
> Robin.
> 
>>    *    IOMMU_DOMAIN_DMA    - Internally used for DMA-API implementations.
>>    *                  This flag allows IOMMU drivers to implement
>>    *                  certain optimizations for these domains
>>
> .
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-02-02 13:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02  8:53 [PATCH] iommu: Update the document of IOMMU_DOMAIN_UNMANAGED Keqian Zhu
2021-02-02  8:53 ` Keqian Zhu
2021-02-02  8:53 ` Keqian Zhu
2021-02-02 12:58 ` Robin Murphy
2021-02-02 12:58   ` Robin Murphy
2021-02-02 12:58   ` Robin Murphy
2021-02-02 13:14   ` Keqian Zhu
2021-02-02 13:14     ` Keqian Zhu
2021-02-02 13:14     ` Keqian Zhu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.