* [PATCH] video: fbdev: via: hide unused procfs helpers
@ 2018-07-13 7:56 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-07-13 7:56 UTC (permalink / raw)
To: FlorianSchandinat, b.zolnierkie
Cc: linux-kernel, dri-devel, linux-fbdev, YueHaibing
When CONFIG_PROC_FS isn't set, gcc warning this:
drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
^
fix this by adding #ifdef around it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/via/viafbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
index d2f7850..edca3e0 100644
--- a/drivers/video/fbdev/via/viafbdev.c
+++ b/drivers/video/fbdev/via/viafbdev.c
@@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
#endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
+#ifdef CONFIG_PROC_FS
static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
{
via_odev_to_seq(m, supported_odev_map[
viaparinfo->shared->chip_info.gfx_chip_name]);
return 0;
}
+#endif
static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
{
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: via: hide unused procfs helpers
@ 2018-07-13 7:56 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-07-13 7:56 UTC (permalink / raw)
To: FlorianSchandinat, b.zolnierkie
Cc: linux-kernel, dri-devel, linux-fbdev, YueHaibing
When CONFIG_PROC_FS isn't set, gcc warning this:
drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
^
fix this by adding #ifdef around it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/via/viafbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
index d2f7850..edca3e0 100644
--- a/drivers/video/fbdev/via/viafbdev.c
+++ b/drivers/video/fbdev/via/viafbdev.c
@@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
#endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
+#ifdef CONFIG_PROC_FS
static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
{
via_odev_to_seq(m, supported_odev_map[
viaparinfo->shared->chip_info.gfx_chip_name]);
return 0;
}
+#endif
static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
{
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: via: hide unused procfs helpers
@ 2018-07-13 7:56 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-07-13 7:56 UTC (permalink / raw)
To: FlorianSchandinat, b.zolnierkie
Cc: linux-kernel, dri-devel, linux-fbdev, YueHaibing
When CONFIG_PROC_FS isn't set, gcc warning this:
drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
^
fix this by adding #ifdef around it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/via/viafbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
index d2f7850..edca3e0 100644
--- a/drivers/video/fbdev/via/viafbdev.c
+++ b/drivers/video/fbdev/via/viafbdev.c
@@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
#endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
+#ifdef CONFIG_PROC_FS
static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
{
via_odev_to_seq(m, supported_odev_map[
viaparinfo->shared->chip_info.gfx_chip_name]);
return 0;
}
+#endif
static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
{
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: via: hide unused procfs helpers
2018-07-13 7:56 ` YueHaibing
(?)
@ 2018-07-13 9:41 ` YueHaibing
-1 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-07-13 9:41 UTC (permalink / raw)
To: FlorianSchandinat, b.zolnierkie; +Cc: linux-kernel, dri-devel, linux-fbdev
Pls ignore this.there has a fix:
[PATCH] fbdev/via: fix defined but not used warning
On 2018/7/13 15:56, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
> static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/video/fbdev/via/viafbdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
> index d2f7850..edca3e0 100644
> --- a/drivers/video/fbdev/via/viafbdev.c
> +++ b/drivers/video/fbdev/via/viafbdev.c
> @@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
>
> #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
>
> +#ifdef CONFIG_PROC_FS
> static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
> {
> via_odev_to_seq(m, supported_odev_map[
> viaparinfo->shared->chip_info.gfx_chip_name]);
> return 0;
> }
> +#endif
>
> static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
> {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: via: hide unused procfs helpers
@ 2018-07-13 9:41 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-07-13 9:41 UTC (permalink / raw)
To: FlorianSchandinat, b.zolnierkie; +Cc: linux-kernel, dri-devel, linux-fbdev
Pls ignore this.there has a fix:
[PATCH] fbdev/via: fix defined but not used warning
On 2018/7/13 15:56, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
> static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/video/fbdev/via/viafbdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
> index d2f7850..edca3e0 100644
> --- a/drivers/video/fbdev/via/viafbdev.c
> +++ b/drivers/video/fbdev/via/viafbdev.c
> @@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
>
> #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
>
> +#ifdef CONFIG_PROC_FS
> static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
> {
> via_odev_to_seq(m, supported_odev_map[
> viaparinfo->shared->chip_info.gfx_chip_name]);
> return 0;
> }
> +#endif
>
> static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
> {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: via: hide unused procfs helpers
@ 2018-07-13 9:41 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-07-13 9:41 UTC (permalink / raw)
To: FlorianSchandinat, b.zolnierkie; +Cc: linux-kernel, dri-devel, linux-fbdev
Pls ignore this.there has a fix:
[PATCH] fbdev/via: fix defined but not used warning
On 2018/7/13 15:56, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
> static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/video/fbdev/via/viafbdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
> index d2f7850..edca3e0 100644
> --- a/drivers/video/fbdev/via/viafbdev.c
> +++ b/drivers/video/fbdev/via/viafbdev.c
> @@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
>
> #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
>
> +#ifdef CONFIG_PROC_FS
> static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
> {
> via_odev_to_seq(m, supported_odev_map[
> viaparinfo->shared->chip_info.gfx_chip_name]);
> return 0;
> }
> +#endif
>
> static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
> {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-13 9:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 7:56 [PATCH] video: fbdev: via: hide unused procfs helpers YueHaibing
2018-07-13 7:56 ` YueHaibing
2018-07-13 7:56 ` YueHaibing
2018-07-13 9:41 ` YueHaibing
2018-07-13 9:41 ` YueHaibing
2018-07-13 9:41 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.