* [PATCH] bcache: remove unused function closure_set_ret_ip()
@ 2020-09-29 6:47 Jason Yan
2020-09-29 6:49 ` Coly Li
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-09-29 6:47 UTC (permalink / raw)
To: colyli, kent.overstreet, yanaijie, linux-bcache
This function has no caller after commit e4bf791937d8 ("bcache: Fix,
improve efficiency of closure_sync()").
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/md/bcache/closure.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
index c88cdc4ae4ec..35f3f87f74e4 100644
--- a/drivers/md/bcache/closure.h
+++ b/drivers/md/bcache/closure.h
@@ -205,13 +205,6 @@ static inline void closure_set_ip(struct closure *cl)
#endif
}
-static inline void closure_set_ret_ip(struct closure *cl)
-{
-#ifdef CONFIG_BCACHE_CLOSURES_DEBUG
- cl->ip = _RET_IP_;
-#endif
-}
-
static inline void closure_set_waiting(struct closure *cl, unsigned long f)
{
#ifdef CONFIG_BCACHE_CLOSURES_DEBUG
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bcache: remove unused function closure_set_ret_ip()
2020-09-29 6:47 [PATCH] bcache: remove unused function closure_set_ret_ip() Jason Yan
@ 2020-09-29 6:49 ` Coly Li
2020-09-29 7:31 ` Jason Yan
0 siblings, 1 reply; 3+ messages in thread
From: Coly Li @ 2020-09-29 6:49 UTC (permalink / raw)
To: Jason Yan, kent.overstreet, linux-bcache
On 2020/9/29 14:47, Jason Yan wrote:
> This function has no caller after commit e4bf791937d8 ("bcache: Fix,
> improve efficiency of closure_sync()").
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
NACK. Indeed, it is necessary for closure debug, you don't want to make
current life even worse.
Coly Li
> ---
> drivers/md/bcache/closure.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
> index c88cdc4ae4ec..35f3f87f74e4 100644
> --- a/drivers/md/bcache/closure.h
> +++ b/drivers/md/bcache/closure.h
> @@ -205,13 +205,6 @@ static inline void closure_set_ip(struct closure *cl)
> #endif
> }
>
> -static inline void closure_set_ret_ip(struct closure *cl)
> -{
> -#ifdef CONFIG_BCACHE_CLOSURES_DEBUG
> - cl->ip = _RET_IP_;
> -#endif
> -}
> -
> static inline void closure_set_waiting(struct closure *cl, unsigned long f)
> {
> #ifdef CONFIG_BCACHE_CLOSURES_DEBUG
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bcache: remove unused function closure_set_ret_ip()
2020-09-29 6:49 ` Coly Li
@ 2020-09-29 7:31 ` Jason Yan
0 siblings, 0 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-29 7:31 UTC (permalink / raw)
To: Coly Li, kent.overstreet, linux-bcache
在 2020/9/29 14:49, Coly Li 写道:
> On 2020/9/29 14:47, Jason Yan wrote:
>> This function has no caller after commit e4bf791937d8 ("bcache: Fix,
>> improve efficiency of closure_sync()").
>>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> NACK. Indeed, it is necessary for closure debug, you don't want to make
> current life even worse.
>
Get it. Thanks.
Jason
>
> Coly Li
>
>
>> ---
>> drivers/md/bcache/closure.h | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
>> index c88cdc4ae4ec..35f3f87f74e4 100644
>> --- a/drivers/md/bcache/closure.h
>> +++ b/drivers/md/bcache/closure.h
>> @@ -205,13 +205,6 @@ static inline void closure_set_ip(struct closure *cl)
>> #endif
>> }
>>
>> -static inline void closure_set_ret_ip(struct closure *cl)
>> -{
>> -#ifdef CONFIG_BCACHE_CLOSURES_DEBUG
>> - cl->ip = _RET_IP_;
>> -#endif
>> -}
>> -
>> static inline void closure_set_waiting(struct closure *cl, unsigned long f)
>> {
>> #ifdef CONFIG_BCACHE_CLOSURES_DEBUG
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-29 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29 6:47 [PATCH] bcache: remove unused function closure_set_ret_ip() Jason Yan
2020-09-29 6:49 ` Coly Li
2020-09-29 7:31 ` Jason Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.