From: Atish Patra <Atish.Patra@wdc.com> To: "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>, "anup@brainfault.org" <anup@brainfault.org> Cc: "alankao@andestech.com" <alankao@andestech.com>, "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>, Anup Patel <Anup.Patel@wdc.com>, "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "johan@kernel.org" <johan@kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "palmer@sifive.com" <palmer@sifive.com>, "allison@lohutok.net" <allison@lohutok.net> Subject: Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing. Date: Mon, 29 Jul 2019 18:31:47 +0000 [thread overview] Message-ID: <8ed4d461ffe5ac41b475d22b38019578b29a8d09.camel@wdc.com> (raw) In-Reply-To: <alpine.DEB.2.21.9999.1907270108420.26998@viisi.sifive.com> On Sat, 2019-07-27 at 01:16 -0700, Paul Walmsley wrote: > On Sat, 27 Jul 2019, Anup Patel wrote: > > > If your only objection is uppercase letter not agreeing with YMAL > > schema > > then why not fix the YMAL schema to have regex for RISC-V ISA > > string? > > I don't agree with you that the specification compels software to > accept > arbitrary case combinations in the riscv,isa DT string. > > > The YMAL schema should not enforce any artificial restriction which > > is > > theoretically allowed in the RISC-V spec. > > Unless someone can come up with a compelling reason for why > restricting > the DT ISA strings to all lowercase letters and numbers is > insufficient to > express the full range of options in the spec, The yaml document did not specify anything about all isa-strings has to be lowercase unless I missed something. The two enum values are all lowercase but the description says all ISA strings are documented in ISA specification which describes the ISA strings to be case insensitive. IMHO, this creates confusion resulting the patch. The existing enum strings are already outdated with kvm patchset. I am fine with dropping this patch if yaml clearly document the case sensititve thing. Following approaches can done to avoid this confusion in future. 1. Update the enum strings with every new extension added. - Good chance that somebody miss something and this gets outdated in future. 2. Just add one line in DT binding description saying that "All isa strings has to be lowercase strings". We should mandate this in Unix Platform specification as well to be in sync. Thoughts ? > the additional complexity > to add mixed-case parsing, both in this patch and in the other > patches in > this series, seems pointless. > > > - Paul > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Regards, Atish
WARNING: multiple messages have this Message-ID (diff)
From: Atish Patra <Atish.Patra@wdc.com> To: "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>, "anup@brainfault.org" <anup@brainfault.org> Cc: "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>, "alankao@andestech.com" <alankao@andestech.com>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, Anup Patel <Anup.Patel@wdc.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "johan@kernel.org" <johan@kernel.org>, "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>, "palmer@sifive.com" <palmer@sifive.com>, "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>, "tglx@linutronix.de" <tglx@linutronix.de>, "allison@lohutok.net" <allison@lohutok.net> Subject: Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing. Date: Mon, 29 Jul 2019 18:31:47 +0000 [thread overview] Message-ID: <8ed4d461ffe5ac41b475d22b38019578b29a8d09.camel@wdc.com> (raw) In-Reply-To: <alpine.DEB.2.21.9999.1907270108420.26998@viisi.sifive.com> On Sat, 2019-07-27 at 01:16 -0700, Paul Walmsley wrote: > On Sat, 27 Jul 2019, Anup Patel wrote: > > > If your only objection is uppercase letter not agreeing with YMAL > > schema > > then why not fix the YMAL schema to have regex for RISC-V ISA > > string? > > I don't agree with you that the specification compels software to > accept > arbitrary case combinations in the riscv,isa DT string. > > > The YMAL schema should not enforce any artificial restriction which > > is > > theoretically allowed in the RISC-V spec. > > Unless someone can come up with a compelling reason for why > restricting > the DT ISA strings to all lowercase letters and numbers is > insufficient to > express the full range of options in the spec, The yaml document did not specify anything about all isa-strings has to be lowercase unless I missed something. The two enum values are all lowercase but the description says all ISA strings are documented in ISA specification which describes the ISA strings to be case insensitive. IMHO, this creates confusion resulting the patch. The existing enum strings are already outdated with kvm patchset. I am fine with dropping this patch if yaml clearly document the case sensititve thing. Following approaches can done to avoid this confusion in future. 1. Update the enum strings with every new extension added. - Good chance that somebody miss something and this gets outdated in future. 2. Just add one line in DT binding description saying that "All isa strings has to be lowercase strings". We should mandate this in Unix Platform specification as well to be in sync. Thoughts ? > the additional complexity > to add mixed-case parsing, both in this patch and in the other > patches in > this series, seems pointless. > > > - Paul > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Regards, Atish _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-07-29 18:31 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-26 19:46 [PATCH 1/4] RISC-V: Remove per cpu clocksource Atish Patra 2019-07-26 19:46 ` Atish Patra 2019-07-26 19:46 ` [PATCH 2/4] RISC-V: Add riscv_isa reprensenting ISA features common across CPUs Atish Patra 2019-07-26 19:46 ` Atish Patra 2019-07-26 19:46 ` [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing Atish Patra 2019-07-26 19:46 ` Atish Patra 2019-07-26 20:47 ` Paul Walmsley 2019-07-26 20:47 ` Paul Walmsley 2019-07-26 22:20 ` Atish Patra 2019-07-26 22:20 ` Atish Patra 2019-07-26 23:29 ` Paul Walmsley 2019-07-26 23:29 ` Paul Walmsley 2019-07-27 2:23 ` Anup Patel 2019-07-27 2:23 ` Anup Patel 2019-07-27 7:52 ` Paul Walmsley 2019-07-27 7:52 ` Paul Walmsley 2019-07-27 8:05 ` Anup Patel 2019-07-27 8:05 ` Anup Patel 2019-07-27 8:16 ` Paul Walmsley 2019-07-27 8:16 ` Paul Walmsley 2019-07-27 8:49 ` Anup Patel 2019-07-27 8:49 ` Anup Patel 2019-07-29 14:03 ` Andreas Schwab 2019-07-29 14:03 ` Andreas Schwab 2019-07-30 22:58 ` Paul Walmsley 2019-07-30 22:58 ` Paul Walmsley 2019-07-29 18:31 ` Atish Patra [this message] 2019-07-29 18:31 ` Atish Patra 2019-07-31 0:08 ` Paul Walmsley 2019-07-31 0:08 ` Paul Walmsley 2019-07-31 0:34 ` Atish Patra 2019-07-31 0:34 ` Atish Patra 2019-07-30 3:42 ` Palmer Dabbelt 2019-07-30 3:42 ` Palmer Dabbelt 2019-07-30 20:41 ` Atish Patra 2019-07-30 20:41 ` Atish Patra 2019-07-26 19:46 ` [PATCH 4/4] RISC-V: Fix unsupported isa string info Atish Patra 2019-07-26 19:46 ` Atish Patra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8ed4d461ffe5ac41b475d22b38019578b29a8d09.camel@wdc.com \ --to=atish.patra@wdc.com \ --cc=Anup.Patel@wdc.com \ --cc=alankao@andestech.com \ --cc=allison@lohutok.net \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=daniel.lezcano@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=johan@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@sifive.com \ --cc=paul.walmsley@sifive.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.