From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Ming Lei <ming.lei@redhat.com>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2 5/5] nvme-fc: Freeze queues before destroying them
Date: Thu, 8 Jul 2021 12:14:11 +0200 [thread overview]
Message-ID: <8edf09e2-52c1-5b96-6d45-ec210ffc33e1@suse.de> (raw)
In-Reply-To: <20210708092755.15660-6-dwagner@suse.de>
On 7/8/21 11:27 AM, Daniel Wagner wrote:
> nvme_wait_freeze_timeout() in nvme_fc_recreate_io_queues() needs to be
> paired with a nvme_start_freeze(). Without freezing first we will always
> timeout in nvme_wait_freeze_timeout().
>
> Note there is a similiar fix for RDMA 9f98772ba307 ("nvme-rdma: fix
> controller reset hang during traffic") which happens to follow the PCI
> strategy how to handle resetting the queues.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/host/fc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 8e1fc3796735..a38b01485939 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -3249,6 +3249,7 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
> nvme_fc_xmt_ls_rsp(disls);
>
> if (ctrl->ctrl.tagset) {
> + nvme_start_freeze(&ctrl->ctrl);
> nvme_fc_delete_hw_io_queues(ctrl);
> nvme_fc_free_io_queues(ctrl);
> }
>
Please add a comment here about the pairing. We've missed it once, so we
should make it clear why it has to be placed here.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Ming Lei <ming.lei@redhat.com>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2 5/5] nvme-fc: Freeze queues before destroying them
Date: Thu, 8 Jul 2021 12:14:11 +0200 [thread overview]
Message-ID: <8edf09e2-52c1-5b96-6d45-ec210ffc33e1@suse.de> (raw)
In-Reply-To: <20210708092755.15660-6-dwagner@suse.de>
On 7/8/21 11:27 AM, Daniel Wagner wrote:
> nvme_wait_freeze_timeout() in nvme_fc_recreate_io_queues() needs to be
> paired with a nvme_start_freeze(). Without freezing first we will always
> timeout in nvme_wait_freeze_timeout().
>
> Note there is a similiar fix for RDMA 9f98772ba307 ("nvme-rdma: fix
> controller reset hang during traffic") which happens to follow the PCI
> strategy how to handle resetting the queues.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/host/fc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 8e1fc3796735..a38b01485939 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -3249,6 +3249,7 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
> nvme_fc_xmt_ls_rsp(disls);
>
> if (ctrl->ctrl.tagset) {
> + nvme_start_freeze(&ctrl->ctrl);
> nvme_fc_delete_hw_io_queues(ctrl);
> nvme_fc_free_io_queues(ctrl);
> }
>
Please add a comment here about the pairing. We've missed it once, so we
should make it clear why it has to be placed here.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-07-08 10:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 9:27 [PATCH v2 0/5] Handle update hardware queues and queue freeze more carefully Daniel Wagner
2021-07-08 9:27 ` Daniel Wagner
2021-07-08 9:27 ` [PATCH v2 1/5] nvme-fc: Update hardware queues before using them Daniel Wagner
2021-07-08 9:27 ` Daniel Wagner
2021-07-08 10:08 ` Hannes Reinecke
2021-07-08 10:08 ` Hannes Reinecke
2021-07-08 9:27 ` [PATCH v2 2/5] nvme-tcp: Update number of " Daniel Wagner
2021-07-08 9:27 ` Daniel Wagner
2021-07-08 9:27 ` [PATCH v2 3/5] nvme-rdma: " Daniel Wagner
2021-07-08 9:27 ` Daniel Wagner
2021-07-08 9:27 ` [PATCH v2 4/5] nvme-fc: Wait with a timeout for queue to freeze Daniel Wagner
2021-07-08 9:27 ` Daniel Wagner
2021-07-08 10:12 ` Hannes Reinecke
2021-07-08 10:12 ` Hannes Reinecke
2021-07-08 9:27 ` [PATCH v2 5/5] nvme-fc: Freeze queues before destroying them Daniel Wagner
2021-07-08 9:27 ` Daniel Wagner
2021-07-08 10:14 ` Hannes Reinecke [this message]
2021-07-08 10:14 ` Hannes Reinecke
2021-07-09 16:14 ` James Smart
2021-07-09 16:14 ` James Smart
2021-07-09 16:42 ` Daniel Wagner
2021-07-09 16:42 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8edf09e2-52c1-5b96-6d45-ec210ffc33e1@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.