All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] oeqa: Extend parselogs to rpi4
@ 2020-03-16 19:06 Khem Raj
  2020-03-16 19:12 ` akuster808
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-03-16 19:06 UTC (permalink / raw)
  To: openembedded-core

rpi had additional diagnostics which should be ignored [1]

[1] https://github.com/raspberrypi/linux/issues/3195

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/lib/oeqa/runtime/cases/parselogs.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
index cc4f5f8c78..48712d4dac 100644
--- a/meta/lib/oeqa/runtime/cases/parselogs.py
+++ b/meta/lib/oeqa/runtime/cases/parselogs.py
@@ -183,6 +183,11 @@ ignore_errors = {
         'Failed to make EGL context current',
         'glamor initialization failed',
         ] + common_errors,
+    'raspberrypi4-64' : [
+        'bcmgenet fd580000.genet: failed to get enet-eee clock',
+        'bcmgenet fd580000.genet: failed to get enet-wol clock',
+        'bcmgenet fd580000.genet: failed to get enet clock',
+        ] + common_errors,
 }
 
 log_locations = ["/var/log/","/var/log/dmesg", "/tmp/dmesg_output.log"]
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] oeqa: Extend parselogs to rpi4
  2020-03-16 19:06 [PATCH] oeqa: Extend parselogs to rpi4 Khem Raj
@ 2020-03-16 19:12 ` akuster808
  2020-03-16 19:17   ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: akuster808 @ 2020-03-16 19:12 UTC (permalink / raw)
  To: Khem Raj, openembedded-core



On 3/16/20 12:06 PM, Khem Raj wrote:
> rpi had additional diagnostics which should be ignored [1]
>
> [1] https://github.com/raspberrypi/linux/issues/3195

So does this mean OE will take similar patches for every BSP in the world?

- armin
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/lib/oeqa/runtime/cases/parselogs.py | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
> index cc4f5f8c78..48712d4dac 100644
> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> @@ -183,6 +183,11 @@ ignore_errors = {
>          'Failed to make EGL context current',
>          'glamor initialization failed',
>          ] + common_errors,
> +    'raspberrypi4-64' : [
> +        'bcmgenet fd580000.genet: failed to get enet-eee clock',
> +        'bcmgenet fd580000.genet: failed to get enet-wol clock',
> +        'bcmgenet fd580000.genet: failed to get enet clock',
> +        ] + common_errors,
>  }
>  
>  log_locations = ["/var/log/","/var/log/dmesg", "/tmp/dmesg_output.log"]



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] oeqa: Extend parselogs to rpi4
  2020-03-16 19:12 ` akuster808
@ 2020-03-16 19:17   ` Khem Raj
  2020-03-16 20:36     ` André Draszik
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-03-16 19:17 UTC (permalink / raw)
  To: akuster808; +Cc: Patches and discussions about the oe-core layer

On Mon, Mar 16, 2020 at 12:12 PM akuster808 <akuster808@gmail.com> wrote:
>
>
>
> On 3/16/20 12:06 PM, Khem Raj wrote:
> > rpi had additional diagnostics which should be ignored [1]
> >
> > [1] https://github.com/raspberrypi/linux/issues/3195
>
> So does this mean OE will take similar patches for every BSP in the world?
>

suggest a better way and I will do that in BSP layer.

> - armin
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/lib/oeqa/runtime/cases/parselogs.py | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
> > index cc4f5f8c78..48712d4dac 100644
> > --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> > +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> > @@ -183,6 +183,11 @@ ignore_errors = {
> >          'Failed to make EGL context current',
> >          'glamor initialization failed',
> >          ] + common_errors,
> > +    'raspberrypi4-64' : [
> > +        'bcmgenet fd580000.genet: failed to get enet-eee clock',
> > +        'bcmgenet fd580000.genet: failed to get enet-wol clock',
> > +        'bcmgenet fd580000.genet: failed to get enet clock',
> > +        ] + common_errors,
> >  }
> >
> >  log_locations = ["/var/log/","/var/log/dmesg", "/tmp/dmesg_output.log"]
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] oeqa: Extend parselogs to rpi4
  2020-03-16 19:17   ` Khem Raj
@ 2020-03-16 20:36     ` André Draszik
  2020-03-16 20:50       ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: André Draszik @ 2020-03-16 20:36 UTC (permalink / raw)
  To: openembedded-core

On Mon, 2020-03-16 at 12:17 -0700, Khem Raj wrote:
> On Mon, Mar 16, 2020 at 12:12 PM akuster808 <akuster808@gmail.com> wrote:
> > 
> > 
> > On 3/16/20 12:06 PM, Khem Raj wrote:
> > > rpi had additional diagnostics which should be ignored [1]
> > > 
> > > [1] https://github.com/raspberrypi/linux/issues/3195
> > 
> > So does this mean OE will take similar patches for every BSP in the world?
> > 
> 
> suggest a better way and I will do that in BSP layer.

Not sure about better way, but in my BSP layer I have:

layer.conf:
-----------
DEFAULT_TEST_SUITES_remove_mx7d = "parselogs"
DEFAULT_TEST_SUITES_append_mx7d = " parselogs_mx7bsp"

lib/oeqa/runtime/cases/parselogs_mx7bsp.py:
-------------------------------------------
from oeqa.runtime.cases.parselogs import *

mx7bsp_errors = [
    'list of messages',
]

ignore_errors['mymachine'] = mx7bsp_errors + common_errors

class ParseLogsTestMX7BSP(ParseLogsTest):
    pass


A.

> 
> > - armin
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > >  meta/lib/oeqa/runtime/cases/parselogs.py | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
> > > index cc4f5f8c78..48712d4dac 100644
> > > --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> > > +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> > > @@ -183,6 +183,11 @@ ignore_errors = {
> > >          'Failed to make EGL context current',
> > >          'glamor initialization failed',
> > >          ] + common_errors,
> > > +    'raspberrypi4-64' : [
> > > +        'bcmgenet fd580000.genet: failed to get enet-eee clock',
> > > +        'bcmgenet fd580000.genet: failed to get enet-wol clock',
> > > +        'bcmgenet fd580000.genet: failed to get enet clock',
> > > +        ] + common_errors,
> > >  }
> > > 
> > >  log_locations = ["/var/log/","/var/log/dmesg", "/tmp/dmesg_output.log"]



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] oeqa: Extend parselogs to rpi4
  2020-03-16 20:36     ` André Draszik
@ 2020-03-16 20:50       ` Khem Raj
  2020-03-16 22:20         ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-03-16 20:50 UTC (permalink / raw)
  To: André Draszik; +Cc: Patches and discussions about the oe-core layer

On Mon, Mar 16, 2020 at 1:37 PM André Draszik <git@andred.net> wrote:
>
> On Mon, 2020-03-16 at 12:17 -0700, Khem Raj wrote:
> > On Mon, Mar 16, 2020 at 12:12 PM akuster808 <akuster808@gmail.com> wrote:
> > >
> > >
> > > On 3/16/20 12:06 PM, Khem Raj wrote:
> > > > rpi had additional diagnostics which should be ignored [1]
> > > >
> > > > [1] https://github.com/raspberrypi/linux/issues/3195
> > >
> > > So does this mean OE will take similar patches for every BSP in the world?
> > >
> >
> > suggest a better way and I will do that in BSP layer.
>
> Not sure about better way, but in my BSP layer I have:
>

thanks it certainly is better than what I have, I will adapt to it

> layer.conf:
> -----------
> DEFAULT_TEST_SUITES_remove_mx7d = "parselogs"
> DEFAULT_TEST_SUITES_append_mx7d = " parselogs_mx7bsp"
>
> lib/oeqa/runtime/cases/parselogs_mx7bsp.py:
> -------------------------------------------
> from oeqa.runtime.cases.parselogs import *
>
> mx7bsp_errors = [
>     'list of messages',
> ]
>
> ignore_errors['mymachine'] = mx7bsp_errors + common_errors
>
> class ParseLogsTestMX7BSP(ParseLogsTest):
>     pass
>
>
> A.
>
> >
> > > - armin
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > ---
> > > >  meta/lib/oeqa/runtime/cases/parselogs.py | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
> > > > index cc4f5f8c78..48712d4dac 100644
> > > > --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> > > > +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> > > > @@ -183,6 +183,11 @@ ignore_errors = {
> > > >          'Failed to make EGL context current',
> > > >          'glamor initialization failed',
> > > >          ] + common_errors,
> > > > +    'raspberrypi4-64' : [
> > > > +        'bcmgenet fd580000.genet: failed to get enet-eee clock',
> > > > +        'bcmgenet fd580000.genet: failed to get enet-wol clock',
> > > > +        'bcmgenet fd580000.genet: failed to get enet clock',
> > > > +        ] + common_errors,
> > > >  }
> > > >
> > > >  log_locations = ["/var/log/","/var/log/dmesg", "/tmp/dmesg_output.log"]
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] oeqa: Extend parselogs to rpi4
  2020-03-16 20:50       ` Khem Raj
@ 2020-03-16 22:20         ` Richard Purdie
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2020-03-16 22:20 UTC (permalink / raw)
  To: Khem Raj, André Draszik
  Cc: Patches and discussions about the oe-core layer

On Mon, 2020-03-16 at 13:50 -0700, Khem Raj wrote:
> On Mon, Mar 16, 2020 at 1:37 PM André Draszik <git@andred.net> wrote:
> > On Mon, 2020-03-16 at 12:17 -0700, Khem Raj wrote:
> > > On Mon, Mar 16, 2020 at 12:12 PM akuster808 <akuster808@gmail.com
> > > > wrote:
> > > > 
> > > > On 3/16/20 12:06 PM, Khem Raj wrote:
> > > > > rpi had additional diagnostics which should be ignored [1]
> > > > > 
> > > > > [1] https://github.com/raspberrypi/linux/issues/3195
> > > > 
> > > > So does this mean OE will take similar patches for every BSP in
> > > > the world?
> > > > 
> > > 
> > > suggest a better way and I will do that in BSP layer.
> > 
> > Not sure about better way, but in my BSP layer I have:
> > 
> 
> thanks it certainly is better than what I have, I will adapt to it
> 
> > layer.conf:
> > -----------
> > DEFAULT_TEST_SUITES_remove_mx7d = "parselogs"
> > DEFAULT_TEST_SUITES_append_mx7d = " parselogs_mx7bsp"
> > 
> > lib/oeqa/runtime/cases/parselogs_mx7bsp.py:
> > -------------------------------------------
> > from oeqa.runtime.cases.parselogs import *
> > 
> > mx7bsp_errors = [
> >     'list of messages',
> > ]
> > 
> > ignore_errors['mymachine'] = mx7bsp_errors + common_errors
> > 
> > class ParseLogsTestMX7BSP(ParseLogsTest):
> >     pass

Its definitely better. I'd also take patches to further improve things
to allow easier customisation by BSPs. I did think there was some
mechanism but I'm struggling to remember what was intended.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-03-16 22:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 19:06 [PATCH] oeqa: Extend parselogs to rpi4 Khem Raj
2020-03-16 19:12 ` akuster808
2020-03-16 19:17   ` Khem Raj
2020-03-16 20:36     ` André Draszik
2020-03-16 20:50       ` Khem Raj
2020-03-16 22:20         ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.