All of lore.kernel.org
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 02/14] nubus: Fix up header split
Date: Tue,  5 Dec 2017 01:20:01 -0500 (EST)	[thread overview]
Message-ID: <8f12ffa3b20dd2e40149da3512b2dc6d4943270f.1512454057.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <cover.1512454057.git.fthain@telegraphics.com.au>

Due to the '#ifdef __KERNEL__' being located in the wrong place, some
definitions from the kernel API were placed in the UAPI header during
the scripted header split. Fix this. Also, remove the duplicate comment
which is only relevant to the UAPI header.

Fixes: 607ca46e97a1 ("UAPI: (Scripted) Disintegrate include/linux")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
 include/linux/nubus.h      | 27 +++++++++++++++++++++++----
 include/uapi/linux/nubus.h | 23 -----------------------
 2 files changed, 23 insertions(+), 27 deletions(-)

diff --git a/include/linux/nubus.h b/include/linux/nubus.h
index 18c300222362..a6edf7838e22 100644
--- a/include/linux/nubus.h
+++ b/include/linux/nubus.h
@@ -5,16 +5,28 @@
   Originally written by Alan Cox.
 
   Hacked to death by C. Scott Ananian and David Huggins-Daines.
-  
-  Some of the constants in here are from the corresponding
-  NetBSD/OpenBSD header file, by Allen Briggs.  We figured out the
-  rest of them on our own. */
+*/
+
 #ifndef LINUX_NUBUS_H
 #define LINUX_NUBUS_H
 
 #include <asm/nubus.h>
 #include <uapi/linux/nubus.h>
 
+struct nubus_dir {
+	unsigned char *base;
+	unsigned char *ptr;
+	int done;
+	int mask;
+};
+
+struct nubus_dirent {
+	unsigned char *base;
+	unsigned char type;
+	__u32 data;	/* Actually 24 bits used */
+	int mask;
+};
+
 struct nubus_board {
 	struct nubus_board* next;
 	struct nubus_dev* first_dev;
@@ -130,4 +142,11 @@ void nubus_get_rsrc_mem(void *dest, const struct nubus_dirent *dirent,
                         unsigned int len);
 void nubus_get_rsrc_str(char *dest, const struct nubus_dirent *dirent,
                         unsigned int maxlen);
+
+/* Returns a pointer to the "standard" slot space. */
+static inline void *nubus_slot_addr(int slot)
+{
+	return (void *)(0xF0000000 | (slot << 24));
+}
+
 #endif /* LINUX_NUBUS_H */
diff --git a/include/uapi/linux/nubus.h b/include/uapi/linux/nubus.h
index f3776cc80f4d..48031e7858f1 100644
--- a/include/uapi/linux/nubus.h
+++ b/include/uapi/linux/nubus.h
@@ -221,27 +221,4 @@ enum nubus_display_res_id {
 	NUBUS_RESID_SIXTHMODE   = 0x0085
 };
 
-struct nubus_dir
-{
-	unsigned char *base;
-	unsigned char *ptr;
-	int done;
-	int mask;
-};
-
-struct nubus_dirent
-{
-	unsigned char *base;
-	unsigned char type;
-	__u32 data;	/* Actually 24bits used */
-	int mask;
-};
-
-
-/* We'd like to get rid of this eventually.  Only daynaport.c uses it now. */
-static inline void *nubus_slot_addr(int slot)
-{
-	return (void *)(0xF0000000|(slot<<24));
-}
-
 #endif /* _UAPILINUX_NUBUS_H */
-- 
2.13.6

  reply	other threads:[~2017-12-05  6:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  6:20 [PATCH v3 00/14] Modernization and fixes for NuBus subsystem Finn Thain
2017-12-05  6:20 ` Finn Thain [this message]
2017-12-05  6:20 ` [PATCH v3 01/14] nubus: Avoid array underflow and overflow Finn Thain
2017-12-05  6:20 ` [PATCH v3 03/14] nubus: Use static functions where possible Finn Thain
2017-12-05  6:20 ` [PATCH v3 09/14] nubus: Generalize block resource handling Finn Thain
2017-12-05  6:20 ` [PATCH v3 08/14] nubus: Clean up whitespace Finn Thain
2017-12-05  6:20 ` [PATCH v3 10/14] nubus: Rework /proc/bus/nubus/s/ implementation Finn Thain
2017-12-05  6:20 ` [PATCH v3 13/14] nubus: Add expansion_type values for various Mac models Finn Thain
2017-12-05  6:20 ` [PATCH v3 06/14] nubus: Call proc_mkdir() not more than once per slot directory Finn Thain
2017-12-05  6:20 ` [PATCH v3 05/14] nubus: Validate slot resource IDs Finn Thain
2017-12-05  6:20 ` [PATCH v3 07/14] nubus: Remove redundant code Finn Thain
2017-12-05  6:20 ` [PATCH v3 11/14] nubus: Rename struct nubus_dev Finn Thain
2017-12-05  6:20   ` Finn Thain
2017-12-05 13:50   ` Bartlomiej Zolnierkiewicz
2017-12-05 13:50     ` Bartlomiej Zolnierkiewicz
2017-12-05  6:20 ` [PATCH v3 12/14] nubus: Adopt standard linked list implementation Finn Thain
2017-12-05  6:20   ` Finn Thain
2017-12-05 13:51   ` Bartlomiej Zolnierkiewicz
2017-12-05 13:51     ` Bartlomiej Zolnierkiewicz
2017-12-05 13:51     ` Bartlomiej Zolnierkiewicz
2017-12-05  6:20 ` [PATCH v3 14/14] nubus: Add support for the driver model Finn Thain
2017-12-05  8:25   ` Greg Kroah-Hartman
2017-12-07  9:57   ` Philippe Ombredanne
2017-12-10 10:03     ` Finn Thain
2017-12-10 12:08       ` Philippe Ombredanne
2017-12-05  6:20 ` [PATCH v3 04/14] nubus: Fix log spam Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f12ffa3b20dd2e40149da3512b2dc6d4943270f.1512454057.git.fthain@telegraphics.com.au \
    --to=fthain@telegraphics.com.au \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.