All of lore.kernel.org
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 14/14] nubus: Add support for the driver model
Date: Sun, 10 Dec 2017 21:03:03 +1100 (AEDT)	[thread overview]
Message-ID: <alpine.LNX.2.21.1712102042340.3@nippy.intranet> (raw)
In-Reply-To: <CAOFm3uGWw0_Dvt0k533g8ovVyz0ehHZi6fSXC4jSpq3JjQCyAg@mail.gmail.com>

On Thu, 7 Dec 2017, Philippe Ombredanne wrote:

> > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c
> > new file mode 100644
> > index 000000000000..b5045e639b4d
> > --- /dev/null
> > +++ b/drivers/nubus/bus.c
> > @@ -0,0 +1,119 @@
> > +/*
> > + * Bus implementation for the NuBus subsystem.
> > + *
> > + * Copyright (C) 2017 Finn Thain
> > + *
> > + * SPDX-License-Identifier: GPL-2.0
> > + */
> 
> I think the SPDX id should be on the first line using C++-style // comments.

Sure, why not.

Since Linus has explicitly allowed conversion of the entire block comment 
to C++ style, I think I may prefer that as being less ugly than the 
mixture of styles (though fwiw this will always read like top posting to 
me).

> See tglx's doc patches

I didn't find any mention of SPDX under Documentation...

> and Linus posts explaining why he wants it this way!
> 

I suspect that you are referring to his posts in this thread (?)
https://lkml.org/lkml/2017/11/2/728

-- 

  reply	other threads:[~2017-12-10 10:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  6:20 [PATCH v3 00/14] Modernization and fixes for NuBus subsystem Finn Thain
2017-12-05  6:20 ` [PATCH v3 02/14] nubus: Fix up header split Finn Thain
2017-12-05  6:20 ` [PATCH v3 01/14] nubus: Avoid array underflow and overflow Finn Thain
2017-12-05  6:20 ` [PATCH v3 03/14] nubus: Use static functions where possible Finn Thain
2017-12-05  6:20 ` [PATCH v3 09/14] nubus: Generalize block resource handling Finn Thain
2017-12-05  6:20 ` [PATCH v3 08/14] nubus: Clean up whitespace Finn Thain
2017-12-05  6:20 ` [PATCH v3 10/14] nubus: Rework /proc/bus/nubus/s/ implementation Finn Thain
2017-12-05  6:20 ` [PATCH v3 13/14] nubus: Add expansion_type values for various Mac models Finn Thain
2017-12-05  6:20 ` [PATCH v3 06/14] nubus: Call proc_mkdir() not more than once per slot directory Finn Thain
2017-12-05  6:20 ` [PATCH v3 05/14] nubus: Validate slot resource IDs Finn Thain
2017-12-05  6:20 ` [PATCH v3 07/14] nubus: Remove redundant code Finn Thain
2017-12-05  6:20 ` [PATCH v3 11/14] nubus: Rename struct nubus_dev Finn Thain
2017-12-05  6:20   ` Finn Thain
2017-12-05 13:50   ` Bartlomiej Zolnierkiewicz
2017-12-05 13:50     ` Bartlomiej Zolnierkiewicz
2017-12-05  6:20 ` [PATCH v3 12/14] nubus: Adopt standard linked list implementation Finn Thain
2017-12-05  6:20   ` Finn Thain
2017-12-05 13:51   ` Bartlomiej Zolnierkiewicz
2017-12-05 13:51     ` Bartlomiej Zolnierkiewicz
2017-12-05 13:51     ` Bartlomiej Zolnierkiewicz
2017-12-05  6:20 ` [PATCH v3 14/14] nubus: Add support for the driver model Finn Thain
2017-12-05  8:25   ` Greg Kroah-Hartman
2017-12-07  9:57   ` Philippe Ombredanne
2017-12-10 10:03     ` Finn Thain [this message]
2017-12-10 12:08       ` Philippe Ombredanne
2017-12-05  6:20 ` [PATCH v3 04/14] nubus: Fix log spam Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.21.1712102042340.3@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.