From: Samuel Holland <samuel@sholland.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 1/4] regulator: dt-bindings: Add Allwinner D1 LDOs Date: Wed, 17 Aug 2022 03:39:25 -0500 [thread overview] Message-ID: <8f133166-dff8-e376-3ac4-a464724d5421@sholland.org> (raw) In-Reply-To: <29e6a293-29c4-a9ab-0767-9adfa982226b@linaro.org> On 8/17/22 3:27 AM, Krzysztof Kozlowski wrote: > On 17/08/2022 11:15, Samuel Holland wrote: >>>> +examples: >>>> + - | >>>> + audio-codec@2030000 { >>>> + compatible = "simple-mfd", "syscon"; >>> >>> This cannot be on its own. Both require device specific compatible. >> >> Again, the device-specific compatible does not exist, because the binding for >> the audio codec has not been written (and it will be quite nontrivial). >> >> So I can: >> 1) Leave the example as-is until the audio codec binding gets written, >> and fill in the specific compatible at that time. >> 2) Remove the example, with the reasoning that the example really >> belongs with the MFD parent (like for the other regulator). Then >> there will be no example until the audio codec binding is written. >> 3) Drop the analog LDOs from this series entirely, and some parts >> of the SoC (like thermal monitoring) cannot be added to the DTSI >> until the audio codec binding is written. >> >> What do you think? > > How about just removing the audio-codec node? The schema is about > regulators, not audio-codec. That works for me. I put the extra node there to signify that this is a MFD child and requires some parent node to work, but I suppose it is not that helpful to have. > OTOH, if you have parent device schema, you could put the example only > there. But as I understand, you don't have, right? Right. >> The same question applies for the D1 SoC DTSI, where I use this same construct. > > This is not correct and should be fixed. Either you add the schema with > compatible or please drop the device node from the DTSI. That's what I was afraid of. Regards, Samuel >> (And technically this does validate with the current schema.)
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 1/4] regulator: dt-bindings: Add Allwinner D1 LDOs Date: Wed, 17 Aug 2022 03:39:25 -0500 [thread overview] Message-ID: <8f133166-dff8-e376-3ac4-a464724d5421@sholland.org> (raw) In-Reply-To: <29e6a293-29c4-a9ab-0767-9adfa982226b@linaro.org> On 8/17/22 3:27 AM, Krzysztof Kozlowski wrote: > On 17/08/2022 11:15, Samuel Holland wrote: >>>> +examples: >>>> + - | >>>> + audio-codec@2030000 { >>>> + compatible = "simple-mfd", "syscon"; >>> >>> This cannot be on its own. Both require device specific compatible. >> >> Again, the device-specific compatible does not exist, because the binding for >> the audio codec has not been written (and it will be quite nontrivial). >> >> So I can: >> 1) Leave the example as-is until the audio codec binding gets written, >> and fill in the specific compatible at that time. >> 2) Remove the example, with the reasoning that the example really >> belongs with the MFD parent (like for the other regulator). Then >> there will be no example until the audio codec binding is written. >> 3) Drop the analog LDOs from this series entirely, and some parts >> of the SoC (like thermal monitoring) cannot be added to the DTSI >> until the audio codec binding is written. >> >> What do you think? > > How about just removing the audio-codec node? The schema is about > regulators, not audio-codec. That works for me. I put the extra node there to signify that this is a MFD child and requires some parent node to work, but I suppose it is not that helpful to have. > OTOH, if you have parent device schema, you could put the example only > there. But as I understand, you don't have, right? Right. >> The same question applies for the D1 SoC DTSI, where I use this same construct. > > This is not correct and should be fixed. Either you add the schema with > compatible or please drop the device node from the DTSI. That's what I was afraid of. Regards, Samuel >> (And technically this does validate with the current schema.) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-17 8:39 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-15 4:34 [PATCH v3 0/4] regulator: Add support for Allwinner D1 LDOs Samuel Holland 2022-08-15 4:34 ` Samuel Holland 2022-08-15 4:34 ` [PATCH v3 1/4] regulator: dt-bindings: Add " Samuel Holland 2022-08-15 4:34 ` Samuel Holland 2022-08-15 15:32 ` Heiko Stübner 2022-08-15 15:32 ` Heiko Stübner 2022-08-16 10:00 ` Krzysztof Kozlowski 2022-08-16 10:00 ` Krzysztof Kozlowski 2022-08-16 9:55 ` Krzysztof Kozlowski 2022-08-16 9:55 ` Krzysztof Kozlowski 2022-08-17 8:15 ` Samuel Holland 2022-08-17 8:15 ` Samuel Holland 2022-08-17 8:27 ` Krzysztof Kozlowski 2022-08-17 8:27 ` Krzysztof Kozlowski 2022-08-17 8:39 ` Samuel Holland [this message] 2022-08-17 8:39 ` Samuel Holland 2022-08-17 8:46 ` Krzysztof Kozlowski 2022-08-17 8:46 ` Krzysztof Kozlowski 2022-08-17 13:46 ` Krzysztof Kozlowski 2022-08-17 13:46 ` Krzysztof Kozlowski 2022-08-16 9:57 ` Krzysztof Kozlowski 2022-08-16 9:57 ` Krzysztof Kozlowski 2022-08-15 4:34 ` [PATCH v3 2/4] regulator: sun20i: Add support for " Samuel Holland 2022-08-15 4:34 ` Samuel Holland 2022-08-15 17:00 ` Heiko Stübner 2022-08-15 17:00 ` Heiko Stübner 2022-08-17 8:28 ` Samuel Holland 2022-08-17 8:28 ` Samuel Holland 2022-08-17 10:01 ` Heiko Stübner 2022-08-17 10:01 ` Heiko Stübner 2022-08-15 4:34 ` [PATCH v3 3/4] dt-bindings: sram: sunxi-sram: Add optional regulators child Samuel Holland 2022-08-15 4:34 ` Samuel Holland 2022-08-15 14:01 ` Rob Herring 2022-08-15 14:01 ` Rob Herring 2022-08-15 17:02 ` Heiko Stübner 2022-08-15 17:02 ` Heiko Stübner 2022-08-16 9:59 ` Krzysztof Kozlowski 2022-08-16 9:59 ` Krzysztof Kozlowski 2022-08-17 8:47 ` Samuel Holland 2022-08-17 8:47 ` Samuel Holland 2022-08-17 13:22 ` Krzysztof Kozlowski 2022-08-17 13:22 ` Krzysztof Kozlowski 2022-08-15 4:34 ` [PATCH v3 4/4] soc: sunxi: sram: Only iterate over SRAM children Samuel Holland 2022-08-15 4:34 ` Samuel Holland 2022-08-15 17:04 ` Heiko Stübner 2022-08-15 17:04 ` Heiko Stübner 2022-08-16 10:01 ` Krzysztof Kozlowski 2022-08-16 10:01 ` Krzysztof Kozlowski 2022-08-16 10:03 ` Krzysztof Kozlowski 2022-08-16 10:03 ` Krzysztof Kozlowski 2022-08-17 8:50 ` Samuel Holland 2022-08-17 8:50 ` Samuel Holland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8f133166-dff8-e376-3ac4-a464724d5421@sholland.org \ --to=samuel@sholland.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.