All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay
@ 2017-08-30 15:53 Eric Sandeen
  2017-08-30 16:24 ` Darrick J. Wong
  2017-08-31 13:17 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2017-08-30 15:53 UTC (permalink / raw)
  To: linux-xfs; +Cc: Christoph Hellwig

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 1b625d0..79cb5b3 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -520,7 +520,6 @@
 	struct inode		*inode,
 	loff_t			offset,
 	loff_t			count,
-	unsigned		flags,
 	struct iomap		*iomap)
 {
 	struct xfs_inode	*ip = XFS_I(inode);
@@ -984,8 +983,7 @@ static inline bool need_excl_ilock(struct xfs_inode *ip, unsigned flags)
 	if (((flags & (IOMAP_WRITE | IOMAP_DIRECT)) == IOMAP_WRITE) &&
 			!IS_DAX(inode) && !xfs_get_extsz_hint(ip)) {
 		/* Reserve delalloc blocks for regular writeback. */
-		return xfs_file_iomap_begin_delay(inode, offset, length, flags,
-				iomap);
+		return xfs_file_iomap_begin_delay(inode, offset, length, iomap);
 	}
 
 	if (need_excl_ilock(ip, flags)) {


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay
  2017-08-30 15:53 [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay Eric Sandeen
@ 2017-08-30 16:24 ` Darrick J. Wong
  2017-08-31 13:17 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2017-08-30 16:24 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-xfs, Christoph Hellwig

On Wed, Aug 30, 2017 at 10:53:22AM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
> 
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 1b625d0..79cb5b3 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -520,7 +520,6 @@
>  	struct inode		*inode,
>  	loff_t			offset,
>  	loff_t			count,
> -	unsigned		flags,
>  	struct iomap		*iomap)
>  {
>  	struct xfs_inode	*ip = XFS_I(inode);
> @@ -984,8 +983,7 @@ static inline bool need_excl_ilock(struct xfs_inode *ip, unsigned flags)
>  	if (((flags & (IOMAP_WRITE | IOMAP_DIRECT)) == IOMAP_WRITE) &&
>  			!IS_DAX(inode) && !xfs_get_extsz_hint(ip)) {
>  		/* Reserve delalloc blocks for regular writeback. */
> -		return xfs_file_iomap_begin_delay(inode, offset, length, flags,
> -				iomap);
> +		return xfs_file_iomap_begin_delay(inode, offset, length, iomap);
>  	}
>  
>  	if (need_excl_ilock(ip, flags)) {
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay
  2017-08-30 15:53 [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay Eric Sandeen
  2017-08-30 16:24 ` Darrick J. Wong
@ 2017-08-31 13:17 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-31 13:17 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-xfs, Christoph Hellwig

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-31 13:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 15:53 [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay Eric Sandeen
2017-08-30 16:24 ` Darrick J. Wong
2017-08-31 13:17 ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.