All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset
@ 2021-07-13  9:36 Clements, John
  2021-07-13  9:39 ` Zhang, Hawking
  0 siblings, 1 reply; 4+ messages in thread
From: Clements, John @ 2021-07-13  9:36 UTC (permalink / raw)
  To: amd-gfx; +Cc: Zhang, Hawking


[-- Attachment #1.1: Type: text/plain, Size: 125 bytes --]

[AMD Official Use Only]

Submitting patch to resolve bug in UMC 6.7 error offset calculation

Thank you,
John Clements

[-- Attachment #1.2: Type: text/html, Size: 1964 bytes --]

[-- Attachment #2: 0001-drm-amdgpu-Resolve-bug-in-UMC-6.7-UMC-error-offset-c.patch --]
[-- Type: application/octet-stream, Size: 1235 bytes --]

From d5fc78ee70a54eaa48da311bd9320c7ed964fc35 Mon Sep 17 00:00:00 2001
From: John Clements <john.clements@amd.com>
Date: Tue, 13 Jul 2021 17:33:53 +0800
Subject: [PATCH 1/1] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset
 calculation

Use correct channel and instance values

Change-Id: Iddb11d1ba62f7751698fbc4440fe17306343fbe4
---
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 600eaf1971d2..e3158204965f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -1171,8 +1171,8 @@ static void gmc_v9_0_set_umc_funcs(struct amdgpu_device *adev)
 		break;
 	case CHIP_ALDEBARAN:
 		adev->umc.max_ras_err_cnt_per_query = UMC_V6_7_TOTAL_CHANNEL_NUM;
-		adev->umc.channel_inst_num = UMC_V6_7_CHANNEL_INSTANCE_NUM;
-		adev->umc.umc_inst_num = UMC_V6_7_UMC_INSTANCE_NUM;
+		adev->umc.channel_inst_num = UMC_V6_7_UMC_INSTANCE_NUM;
+		adev->umc.umc_inst_num = UMC_V6_7_CHANNEL_INSTANCE_NUM;
 		adev->umc.channel_offs = UMC_V6_7_PER_CHANNEL_OFFSET;
 		if (!adev->gmc.xgmi.connected_to_cpu)
 			adev->umc.ras_funcs = &umc_v6_7_ras_funcs;
-- 
2.17.1


[-- Attachment #3: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset
  2021-07-13  9:36 [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset Clements, John
@ 2021-07-13  9:39 ` Zhang, Hawking
  2021-07-13 11:02   ` Christian König
  0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Hawking @ 2021-07-13  9:39 UTC (permalink / raw)
  To: Clements, John, amd-gfx


[-- Attachment #1.1: Type: text/plain, Size: 568 bytes --]

[AMD Official Use Only]

Let's submit the quick fix first and then work out better naming styles to fix confusing

The patch is

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>

Regards,
Hawking
From: Clements, John <John.Clements@amd.com>
Sent: Tuesday, July 13, 2021 17:37
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>
Subject: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset


[AMD Official Use Only]

Submitting patch to resolve bug in UMC 6.7 error offset calculation

Thank you,
John Clements

[-- Attachment #1.2: Type: text/html, Size: 3436 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset
  2021-07-13  9:39 ` Zhang, Hawking
@ 2021-07-13 11:02   ` Christian König
  2021-07-13 11:19     ` Zhang, Hawking
  0 siblings, 1 reply; 4+ messages in thread
From: Christian König @ 2021-07-13 11:02 UTC (permalink / raw)
  To: Zhang, Hawking, Clements, John, amd-gfx


[-- Attachment #1.1: Type: text/plain, Size: 965 bytes --]

And let me guess you "git send-email" with an AMD address doesn't work 
for you either?

I think we need to ping our IT once more.

Regards,
Christian.

Am 13.07.21 um 11:39 schrieb Zhang, Hawking:
>
> [AMD Official Use Only]
>
> Let’s submit the quick fix first and then work out better naming 
> styles to fix confusing
>
> The patch is
>
> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
>
> Regards,
> Hawking
>
> *From:* Clements, John <John.Clements@amd.com>
> *Sent:* Tuesday, July 13, 2021 17:37
> *To:* amd-gfx@lists.freedesktop.org
> *Cc:* Zhang, Hawking <Hawking.Zhang@amd.com>
> *Subject:* [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset
>
> [AMD Official Use Only]
>
> Submitting patch to resolve bug in UMC 6.7 error offset calculation
>
> Thank you,
>
> John Clements
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[-- Attachment #1.2: Type: text/html, Size: 4558 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset
  2021-07-13 11:02   ` Christian König
@ 2021-07-13 11:19     ` Zhang, Hawking
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Hawking @ 2021-07-13 11:19 UTC (permalink / raw)
  To: Christian König, Clements, John, amd-gfx


[-- Attachment #1.1: Type: text/plain, Size: 1953 bytes --]

[AMD Official Use Only]

Yeah, seems like switching the smtp server helps. Someone sents notes to brahma_sw_dev.

Regards,
Hawking

From: Christian König <ckoenig.leichtzumerken@gmail.com>
Sent: Tuesday, July 13, 2021 19:03
To: Zhang, Hawking <Hawking.Zhang@amd.com>; Clements, John <John.Clements@amd.com>; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset

And let me guess you "git send-email" with an AMD address doesn't work for you either?

I think we need to ping our IT once more.

Regards,
Christian.
Am 13.07.21 um 11:39 schrieb Zhang, Hawking:

[AMD Official Use Only]

Let's submit the quick fix first and then work out better naming styles to fix confusing

The patch is

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com><mailto:Hawking.Zhang@amd.com>

Regards,
Hawking
From: Clements, John <John.Clements@amd.com><mailto:John.Clements@amd.com>
Sent: Tuesday, July 13, 2021 17:37
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Cc: Zhang, Hawking <Hawking.Zhang@amd.com><mailto:Hawking.Zhang@amd.com>
Subject: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset


[AMD Official Use Only]

Submitting patch to resolve bug in UMC 6.7 error offset calculation

Thank you,
John Clements


_______________________________________________

amd-gfx mailing list

amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>

https://lists.freedesktop.org/mailman/listinfo/amd-gfx<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CHawking.Zhang%40amd.com%7C4ca213a09de544cb4ad708d945edbc20%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637617709639276832%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Cn4YEVo40Mg3euPBaz5WFpMcPdwQgDwe4qJmKyDyBBo%3D&reserved=0>


[-- Attachment #1.2: Type: text/html, Size: 6415 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-13 11:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13  9:36 [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset Clements, John
2021-07-13  9:39 ` Zhang, Hawking
2021-07-13 11:02   ` Christian König
2021-07-13 11:19     ` Zhang, Hawking

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.