* [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.
@ 2022-07-28 20:11 Yonggang Luo
2022-07-28 21:39 ` Daniel Henrique Barboza
2022-08-04 11:48 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Yonggang Luo @ 2022-07-28 20:11 UTC (permalink / raw)
To: qemu-devel
Cc: Cédric Le Goater, qemu-trivial, Daniel Henrique Barboza,
David Gibson, Greg Kurz, qemu-ppc, Yonggang Luo
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
target/ppc/excp_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index cb752b184a..7550aafed6 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
}
-#define MSR_BOOK3S_MASK
#if defined(TARGET_PPC64)
void helper_rfid(CPUPPCState *env)
{
--
2.36.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.
2022-07-28 20:11 [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK Yonggang Luo
@ 2022-07-28 21:39 ` Daniel Henrique Barboza
2022-08-04 11:48 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Henrique Barboza @ 2022-07-28 21:39 UTC (permalink / raw)
To: Yonggang Luo, qemu-devel
Cc: Cédric Le Goater, qemu-trivial, David Gibson, Greg Kurz, qemu-ppc
On 7/28/22 17:11, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> target/ppc/excp_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index cb752b184a..7550aafed6 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
> do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
> }
>
> -#define MSR_BOOK3S_MASK
The tag was introduced by a2e71b28e832 ("ppc: Fix rfi/rfid/hrfi/... emulation").
Even back then it wasn't being used.
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Laurent, I believe this is qemu-trivial material. Let me know if you want
me to get it via the ppc tree instead.
Daniel
> #if defined(TARGET_PPC64)
> void helper_rfid(CPUPPCState *env)
> {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.
2022-07-28 20:11 [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK Yonggang Luo
2022-07-28 21:39 ` Daniel Henrique Barboza
@ 2022-08-04 11:48 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2022-08-04 11:48 UTC (permalink / raw)
To: Yonggang Luo, qemu-devel
Cc: Cédric Le Goater, qemu-trivial, Daniel Henrique Barboza,
David Gibson, Greg Kurz, qemu-ppc
Le 28/07/2022 à 22:11, Yonggang Luo a écrit :
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> target/ppc/excp_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index cb752b184a..7550aafed6 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
> do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
> }
>
> -#define MSR_BOOK3S_MASK
> #if defined(TARGET_PPC64)
> void helper_rfid(CPUPPCState *env)
> {
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 20:11 [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK Yonggang Luo
2022-07-28 21:39 ` Daniel Henrique Barboza
2022-08-04 11:48 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.